Bmesh: removed deform parameter of from_object still in PyDoc #89013

Closed
opened 2021-06-09 23:40:31 +02:00 by jon denning · 8 comments
Member

System Information
Operating system: Ubuntu 18.04.5 LTS
Graphics card: nvidia GTX 1050 Ti

Blender Version
Broken: 3.0.0, 93fd07e19cf, master, 2021-06-09
Worked: 2.93.0 LTS

Short description of error
The deform parameter for from_object method of BMesh object was deprecated in 2.93 and removed in 3.0 (task D10086). The latest code in master branch has indeed removed deform from kwlist, and attempting to use in Python console results in TypeError: 'deform' is an invalid keyword argument for from_object() (expected), but deform argument info still exists in PyDoc.

Related, the depsgraph argument was never added to PyDoc (since task D4065).

Exact steps for others to reproduce the error
From starting blend file, open Python console and type:

import bmesh
bm = bmesh.new()
bm.from_object( # press tab to see deform in list, but not depsgraph
bm.from_object(bpy.data.objects['Cube'], bpy.context.evaluated_depsgraph_get(), deform=True) # fails

Note to devs
I have a patch to update PyDoc to exclude deform and include depsgraph. I haven't built Blender from source in many months, so once I have finished installing all deps, rebuilt blender, and have tested the patch, I can submit the patch.

**System Information** Operating system: Ubuntu 18.04.5 LTS Graphics card: nvidia GTX 1050 Ti **Blender Version** Broken: 3.0.0, 93fd07e19cf, master, 2021-06-09 Worked: 2.93.0 LTS **Short description of error** The `deform` parameter for `from_object` method of `BMesh` object was deprecated in 2.93 and removed in 3.0 (task [D10086](https://archive.blender.org/developer/D10086)). The latest code in `master` branch has indeed removed `deform` from `kwlist`, and attempting to use in Python console results in `TypeError: 'deform' is an invalid keyword argument for from_object()` (expected), but `deform` argument info still exists in PyDoc. Related, the `depsgraph` argument was never added to PyDoc (since task [D4065](https://archive.blender.org/developer/D4065)). **Exact steps for others to reproduce the error** From starting blend file, open Python console and type: ``` import bmesh bm = bmesh.new() bm.from_object( # press tab to see deform in list, but not depsgraph bm.from_object(bpy.data.objects['Cube'], bpy.context.evaluated_depsgraph_get(), deform=True) # fails ``` **Note to devs** I have a patch to update PyDoc to exclude `deform` and include `depsgraph`. I haven't built Blender from source in many months, so once I have finished installing all deps, rebuilt blender, and have tested the patch, I can submit the patch.
Author
Member

Added subscriber: @gfxcoder

Added subscriber: @gfxcoder
Member

Added subscriber: @Blendify

Added subscriber: @Blendify
Member

This comment was removed by @Blendify

*This comment was removed by @Blendify*
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
jon denning was assigned by Aaron Carlisle 2021-06-10 02:12:18 +02:00
Member

I have a patch to update PyDoc to exclude deform and include depsgraph. I haven't built Blender from source in many months, so once I have finished installing all deps, rebuilt blender, and have tested the patch, I can submit the patch.

Let us know if you need any help, feel free to reach out on https://blender.chat/channel/blender-coders

> I have a patch to update PyDoc to exclude deform and include depsgraph. I haven't built Blender from source in many months, so once I have finished installing all deps, rebuilt blender, and have tested the patch, I can submit the patch. Let us know if you need any help, feel free to reach out on https://blender.chat/channel/blender-coders

This issue was referenced by blender/blender@ba7f110753

This issue was referenced by blender/blender@ba7f11075354fa541cfab58c5f8a900c0cac6937

This issue was referenced by blender/blender@aa0bd29546

This issue was referenced by blender/blender@aa0bd29546d412d5d3af591af6104a7a5532446a

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender-manual#89013
No description provided.