Fillet Curve Node: Add a point selection input #100031

New Issue

Hans Goudey · 2022-07-27T19:49:47+02:00

Hans Goudey commented

2022-07-27 19:49:47 +02:00

The node should have a point selection input in order to the limit the effect without having to adjust the "radius" input.

Some hints on the implementation:

Add a selection input, retrieved as an IndexMask from the field evaluator
Use slice_and_offset in calculate_result_offsets to get the IndexMask local to each curve
The existing implicit deselection of points with zero radius can be removed
- To keep the behavior the same, the radius input can be connected to the new selection input in versioning code (Searching bNodeSocket in versioning_300.c gives some similar code).

The node should have a point selection input in order to the limit the effect without having to adjust the "radius" input. Some hints on the implementation: - Add a selection input, retrieved as an `IndexMask` from the field evaluator - Use `slice_and_offset` in `calculate_result_offsets` to get the `IndexMask` local to each curve - The existing implicit deselection of points with zero radius can be removed - To keep the behavior the same, the radius input can be connected to the new selection input in versioning code (Searching `bNodeSocket` in `versioning_300.c` gives some similar code).

Hans Goudey commented

2022-07-27 19:49:47 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Hans Goudey commented

2022-07-27 19:49:47 +02:00

Added subscriber: @HooglyBoogly

Shan Huang commented

2022-09-19 02:03:51 +02:00

Added subscriber: @Shan-Huang

Shan Huang self-assigned this 2022-09-19 02:03:51 +02:00

Shan Huang commented

2022-09-19 02:03:51 +02:00

Hi there! I was able to make some progress on this (WIP: D16009). A couple of questions:

I'm having trouble with getting slice_and_offset to localize the selection to each curve. To slice and offset, I first need a per-curve IndexRange to slice with, which seems tricky to compute without looping through the mask multiple times. My current approach is to extract inverse selection ranges and skip filleting the deselected points, which.. could be more efficient. If there's a more elegant way to do it, I'd love to know :)
Could you give a more specific bNodeSocket pointer in versioning_300? There are too many occurrences for a total noob like me to make sense of what's going on... @_@. Doc pointers are highly appreciated too!

Hi there! I was able to make some progress on this (WIP: [D16009](https://archive.blender.org/developer/D16009)). A couple of questions: - I'm having trouble with getting `slice_and_offset` to localize the selection to each curve. To slice and offset, I first need a per-curve `IndexRange` to slice with, which seems tricky to compute without looping through the mask multiple times. My current approach is to extract inverse selection ranges and skip filleting the deselected points, which.. could be more efficient. If there's a more elegant way to do it, I'd love to know :) - Could you give a more specific `bNodeSocket` pointer in `versioning_300`? There are too many occurrences for a total noob like me to make sense of what's going on... @_@. Doc pointers are highly appreciated too!

Hans Goudey commented

2022-09-23 22:02:02 +02:00

Hey @Shan-Huang, sorry for the late reply.

About slice_and_offset, I think you're right, it's a bit more complicated than I expected. We may have to resort to using boolean arrays, or build one extra array first to store the offset into the selection at the start of each curve (or something like that).
dedc679eca has some examples of versioning changes to node groups. There aren't too many docs about such things though.

Let me know if I can answer any other questions.

Hey @Shan-Huang, sorry for the late reply. - About `slice_and_offset`, I think you're right, it's a bit more complicated than I expected. We may have to resort to using boolean arrays, or build one extra array first to store the offset into the selection at the start of each curve (or something like that). - dedc679eca has some examples of versioning changes to node groups. There aren't too many docs about such things though. Let me know if I can answer any other questions.

Shan Huang commented

2022-09-26 02:20:49 +02:00

Sweet. Thanks for the pointers! I've updated the patch and it's ready for review. It's my very first patch so please don't hold back any nits :)

Prakhar-Singh-Chouhan commented

2024-01-23 15:28:50 +01:00

@HooglyBoogly is this issue still open ??

Hans Goudey commented

2024-01-23 15:31:40 +01:00

Yes, it's open.

Shan Huang was unassigned by Hans Goudey

2024-01-23 15:31:48 +01:00

Prakhar-Singh-Chouhan commented

2024-01-24 18:10:11 +01:00

@HooglyBoogly how close is this fix https://archive.blender.org/developer/D16009 with regards to the main one because I was reading through this fix and found a lot of stuff being fixed....