Regression: UI freeze for Render Animation AND changing frame being previewed #100074

New Issue

Ellen Dash · 2022-07-30T01:35:43+02:00

Ellen Dash commented

2022-07-30 01:35:43 +02:00

(NOTE: I am opening this on behalf of someone else, since I have a developer.blender.org account and she doesn't.)

System Information
Operating system: Manjaro Linux
Graphics card: 2x Radeon RX 6600 (only one used for Blender renders)

Blender Version
Broken: 3.2.0, 3.2.1, 3.2.2, c857405c0d
Worked: 3.1.2

This was tested in 3.2.1 on Windows 10, as well, and it had the same problem.

All of these were tested with the --factory-startup flag.

Short description of error

Exact steps for others to reproduce the error

Open the attached LightSwitchScene.blend file.
Render -> Render Animation.
The first frame renders, then the Blender UI freezes.

If you choose Render -> Render Image, it works.

OR:

Open the attached LightSwitchScene.blend file.
Select a different frame. Any frame.
As soon as it tries to render the preview for the newly-selected frame, the Blender UI freezes.

Notes about the file

There are two view layers. View Layer is the actual light switch, View Layer_001 is a watermark. These are composited together.

LightSwitchScene.blend

(**NOTE**: I am opening this on behalf of someone else, since I have a developer.blender.org account and she doesn't.) **System Information** Operating system: Manjaro Linux Graphics card: 2x Radeon RX 6600 (only one used for Blender renders) **Blender Version** Broken: 3.2.0, 3.2.1, 3.2.2, c857405c0d28 Worked: 3.1.2 This was tested in 3.2.1 on Windows 10, as well, and it had the same problem. All of these were tested with the `--factory-startup` flag. **Short description of error** **Exact steps for others to reproduce the error** 1. Open the attached LightSwitchScene.blend file. 2. Render -> Render Animation. 3. The first frame renders, then the Blender UI freezes. If you choose Render -> Render Image, it works. OR: 1. Open the attached LightSwitchScene.blend file. 2. Select a different frame. Any frame. 3. As soon as it tries to render the preview for the newly-selected frame, the Blender UI freezes. **Notes about the file** There are two view layers. `View Layer` is the actual light switch, `View Layer_001` is a watermark. These are composited together. [LightSwitchScene.blend](https://archive.blender.org/developer/F13326008/LightSwitchScene.blend)

Ellen Dash commented

2022-07-30 01:35:43 +02:00

Added subscriber: @duckinator

Pratik Borhade commented

2022-08-01 06:46:31 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-08-01 06:46:31 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-08-01 06:46:31 +02:00

Thanks for the report. In 3.2 and above version UI did not freeze instead rendering stuck at first frame is what I noticed.
While final render animation works in 3.1. I'll search for the affecting commit.

Thanks for the report. In 3.2 and above version UI did not freeze instead rendering stuck at first frame is what I noticed. While final render animation works in 3.1. I'll search for the affecting commit.

Pratik Borhade commented

2022-08-01 08:31:03 +02:00

Tried to bisect between 52a5f6856268 - e5a738af6d51 and pointed me to 8399375098 (I don't think this commit is responsible)

Tried to bisect between `52a5f6856268` - `e5a738af6d51` and pointed me to 8399375098 (I don't think this commit is responsible)

Ghost commented

2022-08-01 09:45:57 +02:00

Added subscriber: @ErickNyanduKabongo

Ghost commented

2022-08-01 09:45:57 +02:00

This sounds like the same problem as in #100061

Pratik Borhade changed title from ~~UI freeze for Render Animation AND changing frame being previewed~~ to Regression: UI freeze for Render Animation AND changing frame being previewed

2022-08-02 08:02:30 +02:00

Pratik Borhade commented

2022-08-02 08:02:55 +02:00

Seems a regression so raising the priority.

Brecht Van Lommel commented

2022-08-05 19:17:24 +02:00

Added subscribers: @neXyon, @brecht

Brecht Van Lommel commented

2022-08-05 19:17:24 +02:00

The reason this was difficult to bisect is that what makes the difference is the ffmpeg library version. The same Blender code works with the older ffmpeg does not hang.

I verified it by temporarily restoring the old libraries like this (make update will set them to the latest again):

cd ../lib/linux_centos7_x86_64/ffmpeg
svn switch https://svn.blender.org/svnroot/bf-blender/tags/blender-3.1-release/lib/linux_centos7_x86_64/ffmpeg

Backtrace where it hangs in audaspace: P3130

CC @neXyon

The reason this was difficult to bisect is that what makes the difference is the ffmpeg library version. The same Blender code works with the older ffmpeg does not hang. I verified it by temporarily restoring the old libraries like this (`make update` will set them to the latest again): ``` cd ../lib/linux_centos7_x86_64/ffmpeg svn switch https://svn.blender.org/svnroot/bf-blender/tags/blender-3.1-release/lib/linux_centos7_x86_64/ffmpeg ``` Backtrace where it hangs in audaspace: [P3130](https://archive.blender.org/developer/P3130.txt) CC @neXyon

Brecht Van Lommel commented

2022-08-05 19:28:09 +02:00

Proposed solution:

diff --git a/extern/audaspace/plugins/ffmpeg/FFMPEGReader.cpp b/extern/audaspace/plugins/ffmpeg/FFMPEGReader.cpp
index ad33c26..4ad6ff5 100644
--- a/extern/audaspace/plugins/ffmpeg/FFMPEGReader.cpp
+++ b/extern/audaspace/plugins/ffmpeg/FFMPEGReader.cpp
@@ -363,8 +363,10 @@ int FFMPEGReader::read_packet(void* opaque, uint8_t* buf, int buf_size)
 
        long long size = std::min(static_cast<long long>(buf_size), reader->m_membuffer->getSize() - reader->m_membufferpos);
 
+       if(size == 0)
+               return AVERROR_EOF;
        if(size < 0)
-               return -1;
+               return AVERROR(EIO);
 
        std::memcpy(buf, ((data_t*)reader->m_membuffer->getBuffer()) + reader->m_membufferpos, size);
        reader->m_membufferpos += size;

Based on what one ffmpeg's own tools does:
https://github.com/FFmpeg/FFmpeg/blob/master/tools/target_dem_fuzzer.c#L50

Proposed solution: ``` diff --git a/extern/audaspace/plugins/ffmpeg/FFMPEGReader.cpp b/extern/audaspace/plugins/ffmpeg/FFMPEGReader.cpp index ad33c26..4ad6ff5 100644 --- a/extern/audaspace/plugins/ffmpeg/FFMPEGReader.cpp +++ b/extern/audaspace/plugins/ffmpeg/FFMPEGReader.cpp @@ -363,8 +363,10 @@ int FFMPEGReader::read_packet(void* opaque, uint8_t* buf, int buf_size) long long size = std::min(static_cast<long long>(buf_size), reader->m_membuffer->getSize() - reader->m_membufferpos); + if(size == 0) + return AVERROR_EOF; if(size < 0) - return -1; + return AVERROR(EIO); std::memcpy(buf, ((data_t*)reader->m_membuffer->getBuffer()) + reader->m_membufferpos, size); reader->m_membufferpos += size; ``` Based on what one ffmpeg's own tools does: https://github.com/FFmpeg/FFmpeg/blob/master/tools/target_dem_fuzzer.c#L50

Joerg Mueller commented

2022-08-05 19:34:56 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Joerg Mueller closed this issue

2022-08-05 19:34:56 +02:00

Joerg Mueller self-assigned this 2022-08-05 19:34:56 +02:00

Joerg Mueller commented

2022-08-05 19:34:56 +02:00

This has already been fixed with e4fd2d5754

This has already been fixed with e4fd2d5754

Brecht Van Lommel commented

2022-08-05 19:40:45 +02:00

Ok, this fix should have been committed to blender-v3.3-release, I will backport it.

Ok, this fix should have been committed to `blender-v3.3-release`, I will backport it.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: UI freeze for Render Animation AND changing frame being previewed #100074