nodes downstream of a mix node are still processed if the socket they are downstream is inactive based on the factor. #100091

Open
opened 2022-07-31 07:48:00 +02:00 by michael campbell · 8 comments

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.96

Blender Version
Broken: version: 3.3.0 Alpha, branch: master, commit date: 2022-06-27 22:46, hash: 7a44f62bdb
Worked: (newest version of Blender that worked as expected)

Short description of error
nodes downstream of a mix node are still processed if the socket they are downstream of is inactive based on the fac value of that mix node.

I'm not sure if this is a bug or a wet dream, but I know in the shader editor any nodes that are only downstream of a mix node are not calculated if the input socket they lead to on the mix node is inactive based on the fac value.

I reported a similar issue recently in the compositor where if there are multiple composite nodes, branches that are downstream of inactive composite node's are still calculated. I'm not sure if this is related?

Steps to Reproduce

  • Open .blend file
  • Each time you change the use alpha value (or any value on the viewer node), the denoise node recalculates, even though the bottom input of the mix node is turned off via the fac value

downstream of inactive mix node socket still calculates.blend

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 512.96 **Blender Version** Broken: version: 3.3.0 Alpha, branch: master, commit date: 2022-06-27 22:46, hash: `7a44f62bdb` Worked: (newest version of Blender that worked as expected) **Short description of error** nodes downstream of a mix node are still processed if the socket they are downstream of is inactive based on the fac value of that mix node. I'm not sure if this is a bug or a wet dream, but I know in the shader editor any nodes that are only downstream of a mix node are not calculated if the input socket they lead to on the mix node is inactive based on the fac value. I reported a similar issue recently in the compositor where if there are multiple composite nodes, branches that are downstream of inactive composite node's are still calculated. I'm not sure if this is related? **Steps to Reproduce** - Open .blend file - Each time you change the use alpha value (or any value on the viewer node), the denoise node recalculates, even though the bottom input of the mix node is turned off via the fac value [downstream of inactive mix node socket still calculates.blend](https://archive.blender.org/developer/F13328314/downstream_of_inactive_mix_node_socket_still_calculates.blend)

Added subscriber: @3di

Added subscriber: @3di
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'
Member

@3di hi, thanks for the report. I did not understand the issue completely. Do you have a test .blend file which I can use as a reference?

@3di hi, thanks for the report. I did not understand the issue completely. Do you have a test .blend file which I can use as a reference?

@PratikPB2123 sure thing. Open the compositor and click the use alpha on the viewer node. Each time you change the use alpha value (or any value on the viewer node), the denoise node recalculates, even though the bottom input of the mix node is turned off via the fac value. I'm not sure if what I'm suggesting is possible, probably the denoise node is a bad example because it has to work on the full frame, but for branches that only contain nodes that can work on a per pixel basis, I think they also still recalculate if the current pixel being calculated by the mix node has a fac of 0.

downstream of inactive mix node socket still calculates.blend

@PratikPB2123 sure thing. Open the compositor and click the use alpha on the viewer node. Each time you change the use alpha value (or any value on the viewer node), the denoise node recalculates, even though the bottom input of the mix node is turned off via the fac value. I'm not sure if what I'm suggesting is possible, probably the denoise node is a bad example because it has to work on the full frame, but for branches that only contain nodes that can work on a per pixel basis, I think they also still recalculate if the current pixel being calculated by the mix node has a fac of 0. [downstream of inactive mix node socket still calculates.blend](https://archive.blender.org/developer/F13328314/downstream_of_inactive_mix_node_socket_still_calculates.blend)
Member

Changed status from 'Needs User Info' to: 'Confirmed'

Changed status from 'Needs User Info' to: 'Confirmed'

Added subscriber: @Sergey

Added subscriber: @Sergey

Thanks for the report, but this is limitation of the current design of the compositor.
Something what would would be nice to work on in the future, but the size of the project is beyond of what could be handled as a bug fix.

Thanks for the report, but this is limitation of the current design of the compositor. Something what would would be nice to work on in the future, but the size of the project is beyond of what could be handled as a bug fix.
Philipp Oeser removed the
Interest
VFX & Video
label 2023-02-10 09:31:30 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#100091
No description provided.