Mouse selection is inaccurate in NLA Editor #100491

New Issue

Colin Basnett · 2022-08-19T04:20:24+02:00

Colin Basnett commented

2022-08-19 04:20:24 +02:00

System Information
Operating system: Windows 11
Graphics card: NVIDIA RTX 3060 TI

Blender Version
Broken: 3.2.2
Worked: Unknown

Short description of error
The mouse selection appears to have some sort of offset that makes it so that the user can select a track that they were not hovering over. The video below clearly shows the issue:

nlaselectbug.mp4

Exact steps for others to reproduce the error
nlatrackbug.blend

**System Information** Operating system: Windows 11 Graphics card: NVIDIA RTX 3060 TI **Blender Version** Broken: 3.2.2 Worked: Unknown **Short description of error** The mouse selection appears to have some sort of offset that makes it so that the user can select a track that they were not hovering over. The video below clearly shows the issue: [nlaselectbug.mp4](https://archive.blender.org/developer/F13402637/nlaselectbug.mp4) **Exact steps for others to reproduce the error** [nlatrackbug.blend](https://archive.blender.org/developer/F13402643/nlatrackbug.blend)

Colin Basnett commented

2022-08-19 04:20:24 +02:00

Added subscriber: @cmbasnett

Colin Basnett commented

2022-08-19 04:49:31 +02:00

Just had a look at the code for this. It seems there is a built-in fudge-factor tolerance to the click, and the code explains why this is the case.

https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_nla/nla_select.c$286-290

  /* x-range to check is +/- 7 (in screen/region-space) on either side of mouse click
   * (that is the size of keyframe icons, so user should be expecting similar tolerances)
   */
  float xmin = UI_view2d_region_to_view_x(v2d, region_x - 7);
  float xmax = UI_view2d_region_to_view_x(v2d, region_x + 7);

So this function will return the right-most track that is (more or less) under the mouse. I think that if multiple strips are under the mouse, it should be doing a more precise check to avoid the situation shown in the video.

Just had a look at the code for this. It seems there is a built-in fudge-factor tolerance to the click, and the code explains why this is the case. https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/space_nla/nla_select.c$286-290 ``` /* x-range to check is +/- 7 (in screen/region-space) on either side of mouse click * (that is the size of keyframe icons, so user should be expecting similar tolerances) */ float xmin = UI_view2d_region_to_view_x(v2d, region_x - 7); float xmax = UI_view2d_region_to_view_x(v2d, region_x + 7); ``` So this function will return the right-most track that is (more or less) under the mouse. I think that if multiple strips are under the mouse, it should be doing a more precise check to avoid the situation shown in the video.

Richard Antalik commented

2022-08-19 06:14:54 +02:00

Added subscriber: @iss

Richard Antalik commented

2022-08-19 06:14:54 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2022-08-19 06:14:54 +02:00

On one hand, code works as intended so hard for me to say it is a bug, but then I don't think it works well and it does not seem consistent with timeline (and other) editor selection. If there should be tolerance, I would expect to pick closest strip to cursor position.

Will confirm as known issue and make a patch - should be very easy. Will see if there will be any concerns during review.

On one hand, code works as intended so hard for me to say it is a bug, but then I don't think it works well and it does not seem consistent with timeline (and other) editor selection. If there should be tolerance, I would expect to pick closest strip to cursor position. Will confirm as known issue and make a patch - should be very easy. Will see if there will be any concerns during review.

Brad Clark commented

2022-08-19 07:31:10 +02:00

Added subscriber: @BClark

Brad Clark commented

2022-08-19 07:31:10 +02:00

"that is the size of keyframe icons, so user should be expecting similar tolerances"

Thanks for finding that, I disagree that I would expect the same kind of thing, if I click even at the end of a clip, I want the clip I clicked on.

Agree that it would be nice to remove this "odd" feeling choice in the code.

"that is the size of keyframe icons, so user should be expecting similar tolerances" Thanks for finding that, I disagree that I would expect the same kind of thing, if I click even at the end of a clip, I want the clip I clicked on. Agree that it would be nice to remove this "odd" feeling choice in the code.

Brad Clark commented

2022-08-19 07:32:26 +02:00

it would also be nice to remove it so that if we ever add in "manipulators" to the start/end of the clip edges so that users an drag trim or blend the clips that they don't pick the wrong area.

blender-admin commented

2022-11-14 19:57:42 +01:00

This issue was referenced by 970be7e65a

This issue was referenced by 970be7e65ae7fce9d58839c3c0bd65bd6dced74b

Richard Antalik commented

2022-11-14 20:09:16 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Richard Antalik closed this issue

2022-11-14 20:09:16 +01:00

Richard Antalik self-assigned this 2022-11-14 20:09:16 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Mouse selection is inaccurate in NLA Editor #100491