Operator to convert input node to new group input socket #100646

New Issue

Simon Thommes · 2022-08-26T15:24:40+02:00

Simon Thommes commented

2022-08-26 15:24:40 +02:00

Make an operator to convert input node to new group input socket

Behaviour:

Create a new input on the current node group.
Use the input node's...
... type as the group input socket type
... value as default value and of the new group input and value of all instances where the group is used
... label as the new group input's name
Replace the input node with a group input node and reconnect the new output to all previous connections
Hide all outputs on the new group input node except the newly create one (same as drag realease search way of adding a new group input socket)

Make an operator to convert input node to new group input socket ![Screenshot from 2022-08-26 14-55-28.png](https://archive.blender.org/developer/F13418493/Screenshot_from_2022-08-26_14-55-28.png) - > ![image.png](https://archive.blender.org/developer/F13418503/image.png) ![image.png](https://archive.blender.org/developer/F13418495/image.png) Behaviour: - Create a new input on the current node group. - Use the input node's... ... type as the group input socket type ... value as default value and of the new group input and value of all instances where the group is used ... label as the new group input's name - Replace the input node with a group input node and reconnect the new output to all previous connections - Hide all outputs on the new group input node except the newly create one (same as drag realease search way of adding a new group input socket)

Simon Thommes commented

2022-08-26 15:24:40 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Simon Thommes commented

2022-08-26 15:24:40 +02:00

Added subscriber: @SimonThommes

Michael Fraser commented

2022-11-17 01:23:03 +01:00

Added subscriber: @MichaelFraser

Michael Fraser self-assigned this 2022-11-17 01:23:03 +01:00

Michael Fraser commented

2022-11-17 01:23:03 +01:00

Hi! I had a first pass at this operator. I'll post a diff soon. Stay tuned.

T100646_01.mp4

Hi! I had a first pass at this operator. I'll post a diff soon. Stay tuned. [T100646_01.mp4](https://archive.blender.org/developer/F13934739/T100646_01.mp4)

Michael Fraser commented

2022-11-17 08:59:12 +01:00

The operator initially supports conversion of these input nodes:

boolean
color
integer
material
string
value
vector

T100646_02.mp4

The operator initially supports conversion of these input nodes: - boolean - color - integer - material - string - value - vector [T100646_02.mp4](https://archive.blender.org/developer/F13934754/T100646_02.mp4)

Simon Thommes commented

2022-11-17 13:07:07 +01:00

Thanks for picking this up, looks great already!

A couple of notes:

The name of the operator is really long right now. I would suggest something shorter like convert_to_group_input. That should still give enough information.
It would be great if the newly created input would not show up in existing input nodes, but just be hidden there by default. That is also how creating an input using the link drag search behaves.
This operator should probably show up in the context menu as well for discoverability. This also concerns the refactoring of that menu in D16216

Thanks for picking this up, looks great already! A couple of notes: - The name of the operator is really long right now. I would suggest something shorter like `convert_to_group_input`. That should still give enough information. - It would be great if the newly created input would not show up in existing input nodes, but just be hidden there by default. That is also how creating an input using the link drag search behaves. - This operator should probably show up in the context menu as well for discoverability. This also concerns the refactoring of that menu in [D16216](https://archive.blender.org/developer/D16216)

Michael Fraser commented

2022-11-17 20:11:39 +01:00

Thanks for the feedback, @simonthommes. I made these updates and posted to D16539.

Changed operator name to convert_to_group_input
Hid the newly created socket on existing input nodes
Added to the node context menu

T100646_03.mp4

Thanks for the feedback, @simonthommes. I made these updates and posted to [D16539](https://archive.blender.org/developer/D16539). - Changed operator name to `convert_to_group_input` - Hid the newly created socket on existing input nodes - Added to the node context menu [T100646_03.mp4](https://archive.blender.org/developer/F13937725/T100646_03.mp4)

Iliya Katushenock commented

2022-11-17 20:30:32 +01:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2022-11-17 20:30:32 +01:00

@MichaelFraser Now it's best to have a discussion in the comments to the patch. There may be a design discussion here.

Michael Fraser commented

2022-11-17 20:43:39 +01:00

@mod_moder Sounds good. I'm available.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Operator to convert input node to new group input socket #100646