"Add F-Curve Modifier" applies only to Active F-Curve #100659

System Information
Operating system: Ubuntu 20.04
Graphics card: Geforce MX230

Blender Version
Broken: 3.2.1. and next

Short description of error
"Add F-Curve Modifier" applies only to the active F curve, although even the description of the operator says that it should be applied to all selected, not just the active curve

2022-08-27 01-19-17.mp4

Exact steps for others to reproduce the error

Create animation
Select F Curves
Add F Curve Modifier through "Keys->Add F-Curve Modifier"

**System Information** Operating system: Ubuntu 20.04 Graphics card: Geforce MX230 **Blender Version** Broken: 3.2.1. and next **Short description of error** "Add F-Curve Modifier" applies only to the active F curve, although even the description of the operator says that it should be applied to all selected, not just the active curve [2022-08-27 01-19-17.mp4](https://archive.blender.org/developer/F13419215/2022-08-27_01-19-17.mp4) **Exact steps for others to reproduce the error** 1. Create animation 2. Select F Curves 3. Add F Curve Modifier through "Keys->Add F-Curve Modifier"

Added subscriber: @sanek2005

Added subscriber: @PratikPB2123

Changed status from 'Needs Triage' to: 'Needs User Info'

Thanks for the report. This is not a bug as far as I understand.
Uncheck Only Active from redo panel. This will work for you. Can you check?

Thanks for the report. This is not a bug as far as I understand. Uncheck `Only Active` from redo panel. This will work for you. Can you check?

Now it works. but still, users are more likely to expect operators to be applied to all curves rather than just the active one. someone from the animation and rigging module should take this into account, changing the default presets is not so difficult

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

yes, changing the default value is straightforward. I'll leave the decision on developers.

Added subscriber: @dr.sybren

"Add F-Curve Modifier" applies only to the active F curve, although even the description of the operator says that it should be applied to all selected, not just the active curve

The tooltip states "Add F-Modifier to the active/selected F-Curves". It could be rewritten to be a bit more explicit, and state "Add F-Modifier to the active or selected F-Curves" (emphasis just for clarity here, I don't intend to introduce bold text to the tooltip system).

Personally I feel that the current behaviour is the right one, for two reasons:

It performs the first-mentioned alternative ("active").
The performed action modifies what is visible; you can see in the side-panel that the modifier is added to the active curve. Making the modification of "invisible FCurves" (you see the curves themselves, but not their modifier list) an explicit step seems the right way to me.

This is of course still subjective, so I'll discuss this in today's module meeting to see what others think.

> "Add F-Curve Modifier" applies only to the active F curve, although even the description of the operator says that it should be applied to all selected, not just the active curve The tooltip states "*Add F-Modifier to the active/selected F-Curves*". It could be rewritten to be a bit more explicit, and state "Add F-Modifier to the active **or** selected F-Curves" (emphasis just for clarity here, I don't intend to introduce bold text to the tooltip system). Personally I feel that the current behaviour is the right one, for two reasons: 1. It performs the first-mentioned alternative ("active"). 2. The performed action modifies what is visible; you can see in the side-panel that the modifier is added to the active curve. Making the modification of "invisible FCurves" (you see the curves themselves, but not their modifier list) an explicit step seems the right way to me. This is of course still subjective, so I'll discuss this in today's module meeting to see what others think.

Added subscribers: @JasonSchleifer, @LucianoMunoz, @BClark

My expectation is that it would apply to selected curves, not only active (the current default).
If I use the channels- extrapolate cycle, it works on selected channels.
Checking my defaults I have "active" turned off so it applies the modifier to what I have selected not the thing I accidentally left active and then have to undo or copy it or edit it after.

So my request/expectation would be to default it to work on selected not only Active.

Maybe @LucianoMunoz or @JasonSchleifer has some input as well.

My expectation is that it would apply to selected curves, not only active (the current default). If I use the channels- extrapolate cycle, it works on selected channels. Checking my defaults I have "active" turned off so it applies the modifier to what I have selected not the thing I accidentally left active and then have to undo or copy it or edit it after. So my request/expectation would be to default it to work on selected not only Active. Maybe @LucianoMunoz or @JasonSchleifer has some input as well.

Marking as bug, as discussed in yesterday's A&R module meeting

Marking as bug, as discussed in [yesterday's A&R module meeting](https://devtalk.blender.org/t/2023-03-09-animation-rigging-module-meeting/28204)

Didn't Christoph already tackled this issue with this commit coming in 3.5? https://archive.blender.org/developer/D17066

That patch adds "Add F-Curve Modifier" to more places. It doesn't change the behaviour of the menu items where already present.

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Labels Milestones

"Add F-Curve Modifier" applies only to Active F-Curve #100659