Regression: Paint initialize glitch color attribute #100760

New Issue

Sun Kim · 2022-09-01T20:52:56+02:00

Sun Kim commented

2022-09-01 20:52:56 +02:00

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: Radeon RX 570 Series ATI Technologies Inc. 4.5.0 Core Profile Context 22.7.1.220725

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-09-01 12:39, hash: 06005b0870
Worked: 3.4.0 August 30 build (5ae3fa50e224), 3.3 beta

Caused by 25237d2625 (not in 3.3)

Short description of error
Sculpt paint initialize random glitch color attribute. Sometimes it's pure black than glitch colors but normal behavior expect initialization with white canvas.

SculptPaintGlitch.mp4

Exact steps for others to reproduce the error

In Sculpt mode, when there is no color attributes to the mesh, paint stroke

SculptPaintGlitch.blend

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: Radeon RX 570 Series ATI Technologies Inc. 4.5.0 Core Profile Context 22.7.1.220725 **Blender Version** Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-09-01 12:39, hash: `06005b0870` Worked: 3.4.0 August 30 build (`5ae3fa50e224`), 3.3 beta Caused by 25237d2625 (not in 3.3) **Short description of error** Sculpt paint initialize random glitch color attribute. Sometimes it's pure black than glitch colors but normal behavior expect initialization with white canvas. [SculptPaintGlitch.mp4](https://archive.blender.org/developer/F13447727/SculptPaintGlitch.mp4) **Exact steps for others to reproduce the error** * In Sculpt mode, when there is no color attributes to the mesh, paint stroke [SculptPaintGlitch.blend](https://archive.blender.org/developer/F13447702/SculptPaintGlitch.blend)

Sun Kim commented

2022-09-01 20:52:56 +02:00

Added subscriber: @persun

Hans Goudey commented

2022-09-01 21:05:16 +02:00

Added subscriber: @HooglyBoogly

Hans Goudey commented

2022-09-01 21:05:16 +02:00

Thanks for the report. I can see where this would happen in the code code. I found the probably fix but haven't tested it yet:

diff --git a/source/blender/blenkernel/intern/paint.cc b/source/blender/blenkernel/intern/paint.cc
index 4c3da5eabc4..b5aeaea3198 100644
--- a/source/blender/blenkernel/intern/paint.cc
+++ b/source/blender/blenkernel/intern/paint.cc
@@ -1917,7 +1917,7 @@ void BKE_sculpt_color_layer_create_if_needed(Object *object)
     return;
   }
 
-  CustomData_add_layer(&orig_me->vdata, CD_PROP_COLOR, CD_CONSTRUCT, nullptr, orig_me->totvert);
+  CustomData_add_layer(&orig_me->vdata, CD_PROP_COLOR, CD_SET_DEFAULT, nullptr, orig_me->totvert);
   CustomDataLayer *layer = orig_me->vdata.layers +
                            CustomData_get_layer_index(&orig_me->vdata, CD_PROP_COLOR);

Thanks for the report. I can see where this would happen in the code code. I found the probably fix but haven't tested it yet: ``` diff --git a/source/blender/blenkernel/intern/paint.cc b/source/blender/blenkernel/intern/paint.cc index 4c3da5eabc4..b5aeaea3198 100644 --- a/source/blender/blenkernel/intern/paint.cc +++ b/source/blender/blenkernel/intern/paint.cc @@ -1917,7 +1917,7 @@ void BKE_sculpt_color_layer_create_if_needed(Object *object) return; } - CustomData_add_layer(&orig_me->vdata, CD_PROP_COLOR, CD_CONSTRUCT, nullptr, orig_me->totvert); + CustomData_add_layer(&orig_me->vdata, CD_PROP_COLOR, CD_SET_DEFAULT, nullptr, orig_me->totvert); CustomDataLayer *layer = orig_me->vdata.layers + CustomData_get_layer_index(&orig_me->vdata, CD_PROP_COLOR); ```

TheRedWaxPolice commented

2022-09-01 22:16:15 +02:00

Added subscriber: @TheRedWaxPolice