Cycles GPU rendering is broken on Apple M1/macOS Ventura #100824

New Issue

Meils Dühnforth · 2022-09-05T09:50:20+02:00

Meils Dühnforth commented

2022-09-05 09:50:20 +02:00

System Information
Operating system: macOS-13.0-arm64-arm-64bit 64 Bits
Graphics card: Apple M1 Max Apple 4.1 Metal - 83

Blender Version
Broken: version: 3.3.0 Release Candidate, branch: master, commit date: 2022-09-03 09:36, hash: a631dc5575
Worked: 3.2.2

Short description of error
Cycles GPU rendering is broken, CPU rendering works as expected.

Cycles - CPU:

Cycles - GPU Compute:

Exact steps for others to reproduce the error

Create any scene
Switch Cycles to GPU Compute
simple_test.blend

**System Information** Operating system: macOS-13.0-arm64-arm-64bit 64 Bits Graphics card: Apple M1 Max Apple 4.1 Metal - 83 **Blender Version** Broken: version: 3.3.0 Release Candidate, branch: master, commit date: 2022-09-03 09:36, hash: `a631dc5575` Worked: 3.2.2 **Short description of error** Cycles GPU rendering is broken, CPU rendering works as expected. Cycles - CPU: ![cpu.png](https://archive.blender.org/developer/F13460888/cpu.png) Cycles - GPU Compute: ![gpu.png](https://archive.blender.org/developer/F13460890/gpu.png) **Exact steps for others to reproduce the error** 1. Create any scene 2. Switch Cycles to GPU Compute [simple_test.blend](https://archive.blender.org/developer/F13460896/simple_test.blend)

Meils Dühnforth commented

2022-09-05 09:50:20 +02:00

Added subscriber: @meils

Thomas Dinges commented

2022-09-05 10:52:48 +02:00

Added subscriber: @ThomasDinges

Thomas Dinges commented

2022-09-05 10:52:48 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Thomas Dinges commented

2022-09-05 10:52:48 +02:00

Cannot confirm this on macOS 12.3 with latest master (3.4 Alpha), GPU renders fine here. Can you please check with 3.4 Alpha as well?

Thomas Dinges commented

2022-09-05 10:54:48 +02:00

Also please note that macOS 13 is not released yet, might be a bug in the OS itself.

Brecht Van Lommel commented

2022-09-05 11:25:22 +02:00

Added subscribers: @Michael-Jones, @brecht

Brecht Van Lommel commented

2022-09-05 11:25:22 +02:00

CC @michael_jones.

Meils Dühnforth commented

2022-09-05 12:57:22 +02:00

The result with the latest 3.4 Alpha is different, but still broken.

This might very well be a macOS Beta bug, but I thought it might be worth reporting due to the fact that Blender 3.2.2 renders fine on the latest macOS 13 Beta.

The result with the latest 3.4 Alpha is different, but still broken. ![gpu_3.4.png](https://archive.blender.org/developer/F13461154/gpu_3.4.png) This might very well be a macOS Beta bug, but I thought it might be worth reporting due to the fact that Blender 3.2.2 renders fine on the latest macOS 13 Beta.

Thomas Dinges commented

2022-09-05 12:58:36 +02:00

Changed status from 'Needs User Info' to: 'Needs Developer To Reproduce'

Thomas Dinges commented

2022-09-05 12:58:36 +02:00

Thanks for testing, let's wait for feedback from Michael then.

Michael Jones (Apple) commented

2022-09-05 21:37:19 +02:00

I am on an older 13.0 beta and see the same broken rendering as posted in the description. A local build based on 03aeef64d5 seems to be rendering correctly on the same OS. As a next step, I will try to narrow this down further.

I am on an older 13.0 beta and see the same broken rendering as posted in the description. A local build based on 03aeef64d5c2bd1eb1aa790bddbce728857778f3 seems to be rendering correctly on the same OS. As a next step, I will try to narrow this down further.

Anton Raves commented

2022-09-06 07:29:53 +02:00

Added subscriber: @Memento

Michael Jones (Apple) commented

2022-09-06 13:08:49 +02:00

For some reason reverting e11c899e71 (which disabled slow-to-compile inlining) fixed the bad render. I will follow up internally as this could be a shader compiler bug.

For some reason reverting e11c899e715b (which disabled slow-to-compile inlining) fixed the bad render. I will follow up internally as this could be a shader compiler bug.

Michael Jones (Apple) commented

2022-09-06 16:32:36 +02:00

This patch fixes the issue by disabling the ccl_device_noinline macro. Total compile time on first render increases to ~2 minutes on M1 Max, which is not fast but better than the previous ~4.5 minutes with aggressive inlining enabled. The resulting benchmark score is about 5% higher with this change on M1 Max.

Fix #100824.patch

This patch fixes the issue by disabling the `ccl_device_noinline` macro. Total compile time on first render increases to ~2 minutes on M1 Max, which is not fast but better than the previous ~4.5 minutes with aggressive inlining enabled. The resulting benchmark score is about 5% higher with this change on M1 Max. [Fix #100824.patch](https://archive.blender.org/developer/F13462967/Fix_T100824.patch)

Brecht Van Lommel commented

2022-09-06 16:57:45 +02:00

@Michael-Jones the release process for Blender 3.3.0 already started, so it's difficult to fix this still. 2 minutes is still a longer wait than I think is good for users.

Do you think the macOS 13 release is far enough away that this can wait for 3.3.1 in a few weeks or even get fixed in macOS? Or is the macOS 13 release going to be soon?

@Michael-Jones the release process for Blender 3.3.0 already started, so it's difficult to fix this still. 2 minutes is still a longer wait than I think is good for users. Do you think the macOS 13 release is far enough away that this can wait for 3.3.1 in a few weeks or even get fixed in macOS? Or is the macOS 13 release going to be soon?

blender-admin commented

2022-09-06 17:27:55 +02:00

This issue was referenced by 6d08ba8a50

This issue was referenced by 6d08ba8a5082ee6bbac8e735a4817d704a03212b

blender-admin commented

2022-09-06 17:27:55 +02:00

This issue was referenced by 0759f671ce

This issue was referenced by 0759f671ce1ff687c4e3518ee518717c577ed22c

Brecht Van Lommel commented

2022-09-06 17:45:09 +02:00

Uploaded as D15897: Fix #100824: Cycles GPU render broken on macOS 13 Beta to test on the buildbot. So far seems to work as expected on macOS 12 + MacBook Air M1.

I'm installing macOS 13 Beta 4 now as well to test that.

Uploaded as [D15897: Fix #100824: Cycles GPU render broken on macOS 13 Beta](https://archive.blender.org/developer/D15897) to test on the buildbot. So far seems to work as expected on macOS 12 + MacBook Air M1. I'm installing macOS 13 Beta 4 now as well to test that.

Brecht Van Lommel commented

2022-09-06 18:38:00 +02:00

The relative improvement in compile times seems bigger than on the M1 Max, and even better on macOS 13.

Full inlining on macOS 12: 370s
Partial inlining on macOS 12: 120s
Partial inlining on macOS 13 Beta 4: 70s

The relative improvement in compile times seems bigger than on the M1 Max, and even better on macOS 13. * Full inlining on macOS 12: 370s * Partial inlining on macOS 12: 120s * Partial inlining on macOS 13 Beta 4: 70s

Brecht Van Lommel commented

2022-09-06 18:52:19 +02:00

Testing this on macOS 13 with the tests and various benchmark scenes, it seems the partial inlining patch works at least as well as full inlining, and no inlining just always gives wrong renders.

However I still saw two issue regardless of inlining:

Test reports/T139823 fails, the sphere with SSS is black (but other SSS tests work).
MetalRT with the junkshop either renders without hair or crashes.

So still some compiler bug to be fixed there I think. But committing the patch seems like the best solution for 3.3.0, so I'll go ahead and do that.

Testing this on macOS 13 with the tests and various benchmark scenes, it seems the partial inlining patch works at least as well as full inlining, and no inlining just always gives wrong renders. However I still saw two issue regardless of inlining: * Test `reports/T139823` fails, the sphere with SSS is black (but other SSS tests work). * MetalRT with the junkshop either renders without hair or crashes. So still some compiler bug to be fixed there I think. But committing the patch seems like the best solution for 3.3.0, so I'll go ahead and do that.

Brecht Van Lommel commented

2022-09-06 19:07:42 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'

Brecht Van Lommel closed this issue

2022-09-06 19:07:42 +02:00

Brecht Van Lommel self-assigned this 2022-09-06 19:07:42 +02:00

Brecht Van Lommel commented

2022-09-06 19:08:57 +02:00

Changed status from 'Resolved' to: 'Confirmed'

Brecht Van Lommel reopened this issue

2022-09-06 19:08:57 +02:00

Brecht Van Lommel commented

2022-09-06 19:08:57 +02:00

Will leave this report open for investigation of other macOS 13 issues than the simple scene from the description.

Brecht Van Lommel commented

2022-09-06 19:12:31 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Brecht Van Lommel closed this issue

2022-09-06 19:12:31 +02:00

Brecht Van Lommel commented

2022-09-06 19:15:07 +02:00

Rendering without hair in the MetalRT + junkshop is happening in macOS 12 too, probably just a mistake in the code. Luckily MetalRT is just an experimental test option, so we can fix that in 3.3.1. However the crashing may be a more difficult issue.