make test should build and/or update the test suite if necessary #100843

New Issue

Loren Osborn · 2022-09-06T02:45:17+02:00

Loren Osborn commented

2022-09-06 02:45:17 +02:00

System Information
Operating system: macOS 12.3.1
Graphics card: AMD Radeon Pro 5500M / Intel UHD Graphics 630

Blender Version
Broken: (example: ff7a7a6f77)
Worked: (not sure if this ever worked as intended)

Short description of error

linux_dr@Lorens-MBP blender % make test

should ensure that the test suite exists and is up to date before attempting to run it.

Exact steps for others to reproduce the error
From the command prompt type cd ~/blender-git/blender ; rm -rf ../build_* ; make test:

linux_dr@Lorens-MBP blender % cd ~/blender-git/blender ; rm -rf ../build_* ; make test
ctest . --output-on-failure -O /Users/linux_dr/blender-git/build_darwin/tests/log.txt
Test project /Users/linux_dr/blender-git/build_darwin
No tests were found!!!
linux_dr@Lorens-MBP blender %

You will see in the output No tests were found!!! because the test suite doesn't exist yet.

I believe the bug also appears as running stale tests after the tests or code are modified, but describing how to test that is a bit more involved.

Developer notes:
I was looking at this as an issue in GNUmakefile, which is outside the mainline CMake-based Blender build pipeline. In discussions with @ideasman42, he suggested I try to fix it in build_files/utils/make_test.py, so the whole pipeline can benefit.

**System Information** Operating system: macOS 12.3.1 Graphics card: AMD Radeon Pro 5500M / Intel UHD Graphics 630 **Blender Version** Broken: (example: ff7a7a6f77a) Worked: (not sure if this ever worked as intended) **Short description of error** ``` linux_dr@Lorens-MBP blender % make test ``` should ensure that the test suite exists and is up to date before attempting to run it. **Exact steps for others to reproduce the error** From the command prompt type `cd ~/blender-git/blender ; rm -rf ../build_* ; make test`: ``` linux_dr@Lorens-MBP blender % cd ~/blender-git/blender ; rm -rf ../build_* ; make test ctest . --output-on-failure -O /Users/linux_dr/blender-git/build_darwin/tests/log.txt Test project /Users/linux_dr/blender-git/build_darwin No tests were found!!! linux_dr@Lorens-MBP blender % ``` You will see in the output `No tests were found!!!` because the test suite doesn't exist yet. I believe the bug also appears as running stale tests after the tests or code are modified, but describing how to test that is a bit more involved. **Developer notes:** I was looking at this as an issue in `GNUmakefile`, which is outside the mainline CMake-based Blender build pipeline. In discussions with @ideasman42, he suggested I try to fix it in `build_files/utils/make_test.py`, so the whole pipeline can benefit.

Loren Osborn commented

2022-09-06 02:45:17 +02:00

Added subscriber: @linux_dr

Pratik Borhade commented

2022-09-06 07:31:44 +02:00

Added subscribers: @ideasman42, @PratikPB2123

Pratik Borhade commented

2022-09-06 07:31:44 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-09-06 07:31:44 +02:00

Looks like you've discussed about this with @ideasman42 already. I'll mark it as "confirmed" (feel free to revert the status)
AFAIK make update adds or updates the existing test at present

Looks like you've discussed about this with @ideasman42 already. I'll mark it as "confirmed" (feel free to revert the status) AFAIK `make update` adds or updates the existing test at present

Loren Osborn commented

2022-09-06 08:37:54 +02:00

In #100843#1412853, @PratikPB2123 wrote:
Looks like you've discussed about this with @ideasman42 already. I'll mark it as "confirmed" (feel free to revert the status)

We've only discussed how to resolve this. I am unaware of anyone trying to reproduce this besides myself. (I'm especially curious if Linux or Windows builds work any better.)

It should be easy enough to test, but I would either try to reproduce it yourself, or change it back to "unconfirmed".

> In #100843#1412853, @PratikPB2123 wrote: > Looks like you've discussed about this with @ideasman42 already. I'll mark it as "confirmed" (feel free to revert the status) We've only discussed how to resolve this. I am unaware of anyone trying to reproduce this besides myself. (I'm especially curious if Linux or Windows builds work any better.) It should be easy enough to test, but I would either try to reproduce it yourself, or change it back to "unconfirmed".

Loren Osborn commented

2022-09-06 21:40:13 +02:00

Changed status from 'Confirmed' to: 'Needs Triage'

Loren Osborn commented

2022-09-06 21:44:19 +02:00

I reverted this to "Needs Triage" as I am only aware of it being specifically seen on my machine so far.

Also
This may originally have been a "by design" issue, but as, for make, this is contrary to expected behavior, I am considering this a "defect".

I reverted this to "Needs Triage" as I am only aware of it being specifically seen on my machine so far. **Also** This may originally have been a "by design" issue, but as, for `make`, this is contrary to expected behavior, I am considering this a "defect".

Omar Emara commented

2022-09-13 14:37:29 +02:00

Added subscriber: @OmarEmaraDev

Omar Emara commented

2022-09-13 14:37:29 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Omar Emara commented

2022-09-13 14:37:29 +02:00

I can reproduce the behavior on Linux and the python test file is straightforward, so I don't think we need any more reproduction.
But since this is not a bug, but rather something you intend to do and discuss, I will change the subtype to match the intent.

I can reproduce the behavior on Linux and the python test file is straightforward, so I don't think we need any more reproduction. But since this is not a bug, but rather something you intend to do and discuss, I will change the subtype to match the intent.

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

make test should build and/or update the test suite if necessary #100843

`make test` should build and/or update the test suite if necessary #100843