Regression: Drag and Drop seems to be broken for image files from desktop #100899

New Issue

Christopher Choo · 2022-09-08T04:50:28+02:00

Christopher Choo commented

2022-09-08 04:50:28 +02:00

Operating system: Mac OS
Graphics card: Apple M1 Pro 16 core

Broken: 3.30, caused by bbf87c4f75
Worked: 3.2.2, bcfdb14560, master, 2022-08-29

I can no longer drag and drop image textures from my desktop into blender when using two monitors.

Steps to reproduce

Open blender on external monitor
Fullscreen blender

Drag image into some editor (that supports it)

It does not work...
Drag and drop still works when blender is on left side of Main display

Operating system: Mac OS Graphics card: Apple M1 Pro 16 core Broken: 3.30, caused by bbf87c4f75 Worked: 3.2.2, bcfdb14560e7, master, 2022-08-29 I can no longer drag and drop image textures from my desktop into blender when using two monitors. **Steps to reproduce** - Open blender on external monitor - Fullscreen blender # Drag image into some editor (that supports it) It does not work... Drag and drop still works when blender is on left side of Main display

Christopher Choo commented

2022-09-08 04:50:28 +02:00

Added subscriber: @C22Raptor

blender-admin commented

2022-09-08 04:50:28 +02:00

#101184 was marked as duplicate of this issue

blender-admin commented

2022-09-08 04:50:28 +02:00

#101064 was marked as duplicate of this issue

blender-admin commented

2022-09-08 04:50:28 +02:00

#101033 was marked as duplicate of this issue

blender-admin commented

2022-09-08 04:50:28 +02:00

#100938 was marked as duplicate of this issue

Pratik Borhade commented

2022-09-08 06:30:57 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-09-08 06:38:56 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Pratik Borhade commented

2022-09-08 06:38:56 +02:00

Thanks for the report. Do you run Blender as administrator? Doing so will not allow to drag and drop images

Christopher Choo commented

2022-09-12 04:07:40 +02:00

I never changed any run settings for blender, I just opened it up after installing.

Christopher Choo commented

2022-09-13 07:50:04 +02:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Omar Emara commented

2022-09-13 13:48:25 +02:00

Added subscribers: @Piergiorgio_PG, @OmarEmaraDev

Omar Emara commented

2022-09-13 13:51:02 +02:00

Added subscriber: @mano-wii

Omar Emara commented

2022-09-13 13:51:02 +02:00

@mano-wii Can you give this a try on Mac?

Richard Antalik commented

2022-09-13 22:56:53 +02:00

Added subscriber: @iss

Richard Antalik commented

2022-09-13 22:56:53 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2022-09-13 22:56:53 +02:00

I think I can reproduce, though not quite sure if this is same as reported issue - files dragged to any editor are added with offset to the left. So if I drag file to centre of the screen nothing is added.

Operating system: macOS-12.2.1-x86_64-i386-64bit 64 Bits
Graphics card: AMD Radeon Pro 5700 XT OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.7.10

I think I can reproduce, though not quite sure if this is same as reported issue - files dragged to any editor are added with offset to the left. So if I drag file to centre of the screen nothing is added. Operating system: macOS-12.2.1-x86_64-i386-64bit 64 Bits Graphics card: AMD Radeon Pro 5700 XT OpenGL Engine ATI Technologies Inc. 4.1 ATI-4.7.10

Richard Antalik commented

2022-09-14 01:20:57 +02:00

Added subscriber: @UseTheFarce

blender-admin commented

2022-09-14 02:56:01 +02:00

This issue was referenced by 81ec5ec366

This issue was referenced by 81ec5ec36651af6bc2c0f64c57add589facefef2

blender-admin commented

2022-09-14 02:56:01 +02:00

This issue was referenced by 5f4db28c24

This issue was referenced by 5f4db28c24943586536e6cc253756805ed9ed722

Germano Cavalcante commented

2022-09-14 04:49:32 +02:00

Added subscriber: @ideasman42

Germano Cavalcante changed title from ~~Drag and Drop seems to be broken for image files from desktop~~ to Regression: Drag and Drop seems to be broken for image files from desktop

2022-09-14 04:50:19 +02:00

Campbell Barton self-assigned this 2022-09-14 08:23:57 +02:00

Germano Cavalcante commented

2022-09-14 13:29:22 +02:00

The problem is that, unlike other OSs, on Mac GHOST_TEventDragnDropData::x/y are in "the base coordinate system of the destination object’s window". Converting to screen coordinates seems to fix the problem.

diff --git a/intern/ghost/intern/GHOST_SystemCocoa.mm b/intern/ghost/intern/GHOST_SystemCocoa.mm
index c247ef3daa0..5562db7d67f 100644
--- a/intern/ghost/intern/GHOST_SystemCocoa.mm
+++ b/intern/ghost/intern/GHOST_SystemCocoa.mm
@@ -1123,6 +1123,7 @@ - (void)windowWillClose:(NSNotification *)notification
     case GHOST_kEventDraggingEntered:
     case GHOST_kEventDraggingUpdated:
     case GHOST_kEventDraggingExited:
+      window->clientToScreenIntern(mouseX, mouseY, mouseX, mouseY);
       pushEvent(new GHOST_EventDragnDrop(
           getMilliSeconds(), eventType, draggedObjectType, window, mouseX, mouseY, NULL));
       break;
@@ -1331,6 +1332,8 @@ - (void)windowWillClose:(NSNotification *)notification
           return GHOST_kFailure;
           break;
       }
+
+      window->clientToScreenIntern(mouseX, mouseY, mouseX, mouseY);
       pushEvent(new GHOST_EventDragnDrop(
           getMilliSeconds(), eventType, draggedObjectType, window, mouseX, mouseY, eventData));

But I'm not familiar with this API.
Maybe you can get the screen coordinates from the beginning.
And I'm not sure if we should use draggingDestinationWindow instead the GHOST_Window.

The problem is that, unlike other OSs, on Mac `GHOST_TEventDragnDropData::x/y` are in "the base coordinate system of the destination object’s window". Converting to screen coordinates seems to fix the problem. ``` diff --git a/intern/ghost/intern/GHOST_SystemCocoa.mm b/intern/ghost/intern/GHOST_SystemCocoa.mm index c247ef3daa0..5562db7d67f 100644 --- a/intern/ghost/intern/GHOST_SystemCocoa.mm +++ b/intern/ghost/intern/GHOST_SystemCocoa.mm @@ -1123,6 +1123,7 @@ - (void)windowWillClose:(NSNotification *)notification case GHOST_kEventDraggingEntered: case GHOST_kEventDraggingUpdated: case GHOST_kEventDraggingExited: + window->clientToScreenIntern(mouseX, mouseY, mouseX, mouseY); pushEvent(new GHOST_EventDragnDrop( getMilliSeconds(), eventType, draggedObjectType, window, mouseX, mouseY, NULL)); break; @@ -1331,6 +1332,8 @@ - (void)windowWillClose:(NSNotification *)notification return GHOST_kFailure; break; } + + window->clientToScreenIntern(mouseX, mouseY, mouseX, mouseY); pushEvent(new GHOST_EventDragnDrop( getMilliSeconds(), eventType, draggedObjectType, window, mouseX, mouseY, eventData)); ``` But I'm not familiar with this API. Maybe you can get the screen coordinates from the beginning. And I'm not sure if we should use `draggingDestinationWindow` instead the `GHOST_Window`.

Campbell Barton commented

2022-09-14 14:41:50 +02:00

@mano-wii checking over intern/ghost/intern/GHOST_WindowCocoa.mm it seems these coordinates are provided by macOS, although I suppose their might be a way to request screen-coordinates. If the fix works then I think it's reasonable commit.

Note that as this error is in 3.3 release, suggest to revert bbf87c4f75 there, and apply the fix from @mano-wii in master.

@mano-wii checking over `intern/ghost/intern/GHOST_WindowCocoa.mm` it seems these coordinates are provided by macOS, although I suppose their might be a way to request screen-coordinates. If the fix works then I think it's reasonable commit. ---- Note that as this error is in 3.3 release, suggest to revert bbf87c4f75 there, and apply the fix from @mano-wii in master.

Omar Emara commented

2022-09-14 15:15:52 +02:00

Added subscriber: @BGreenstone

Germano Cavalcante commented

2022-09-14 18:55:35 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Germano Cavalcante closed this issue

2022-09-14 18:55:35 +02:00

Juan Gómez commented

2022-09-14 21:44:45 +02:00

Sorry if this arrives late: I'd suggest to check the solution on a multimonitor setup, too, as I'm seeing a different behavior of the bug depending on which monitor the File Browser is in.

For example, if the FIle Browser is brought to a monitor different to the one Blender was launched in, drag and drop stops working completely, no matter what half of that screen it is set in.

Also, older systems such as macOS 10.14 Mojave can work with the Spaces feature (virtual desktops) on or off (I'm not sure if they are still optional in recent macOSes). That might be complicating things.

Sorry if this arrives late: I'd suggest to check the solution on a multimonitor setup, too, as I'm seeing a different behavior of the bug depending on which monitor the File Browser is in. For example, if the FIle Browser is brought to a monitor different to the one Blender was launched in, drag and drop stops working completely, no matter what half of that screen it is set in. Also, older systems such as macOS 10.14 Mojave can work with the Spaces feature (virtual desktops) on or off (I'm not sure if they are still optional in recent macOSes). That might be complicating things.

Christopher Choo commented

2022-09-15 07:00:15 +02:00

Added subscriber: @juan-20

Christopher Choo commented

2022-09-15 07:00:15 +02:00

I just realized that I never mentioned that I work on two displays(sorry this was my first bug report so my bad there). @juan-20 Gómez (UseTheFarce) gave a better example of my specific case. Dragging and dropping items from my desktop on my Mac to my external monitor results in nothing happening, despite drag and drop working on my Mac's display. Again, sorry for not explaining properly.