Regression: The start frame of NLA tracks can not be negative. #100918

New Issue

Alexandre Labedade · 2022-09-08T16:42:27+02:00

2022-09-08 16:42:27 +02:00

System Information
Operating system: Windows 10
Graphics card: NVIDIA GeForce RTX 2070

Blender Version
Broken: 3.3.0, branch: master, commit date: 2022-09-06 15:39
Worked: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22

Caused by bd00324c26

Short description of error
Tracks start frame can not be negative. I the track is moved left, as soon as its left bound reach frame 0, it stays stuck here and the right bound is shrunk down.

Exact steps for others to reproduce the error

create a simple animation on an object
put this action as a track in the NLA editor
try to move this track to the left, past frame 0

Working version (3.2)

Bug (3.3)

Test File
nla_track.blend

This seems linked to this upgrade : https://developer.blender.org/rBbd00324c264c

**System Information** Operating system: Windows 10 Graphics card: NVIDIA GeForce RTX 2070 **Blender Version** Broken: 3.3.0, branch: master, commit date: 2022-09-06 15:39 Worked: version: 3.2.0, branch: master, commit date: 2022-06-08 10:22 Caused by bd00324c26 **Short description of error** Tracks start frame can not be negative. I the track is moved left, as soon as its left bound reach frame 0, it stays stuck here and the right bound is shrunk down. **Exact steps for others to reproduce the error** - create a simple animation on an object - put this action as a track in the NLA editor - try to move this track to the left, past frame 0 Working version (3.2) ![nla_track_ok_blender_3.2.gif](https://archive.blender.org/developer/F13469365/nla_track_ok_blender_3.2.gif) Bug (3.3) ![nla_track_bug_blender_3.3.gif](https://archive.blender.org/developer/F13469367/nla_track_bug_blender_3.3.gif) Test File [nla_track.blend](https://archive.blender.org/developer/F13469372/nla_track.blend) This seems linked to this upgrade : https://developer.blender.org/rBbd00324c264c

Alexandre Labedade commented

2022-09-08 16:42:27 +02:00

Added subscriber: @Alesk

blender-admin commented

2022-09-08 16:42:27 +02:00

#101368 was marked as duplicate of this issue

Adam Janz commented

2022-09-09 15:36:31 +02:00

Added subscriber: @AdamJanz

Germano Cavalcante commented

2022-09-09 16:46:10 +02:00

Added subscribers: @thibaulltt, @BClark, @dr.sybren, @mano-wii

Germano Cavalcante commented

2022-09-09 16:46:10 +02:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Germano Cavalcante commented

2022-09-09 16:46:10 +02:00

I'm not very familiar with the area.

If it really is a bug, I wonder how such trivial behavior went unnoticed in the review of D14658.
Cc @dr.sybren, @BClark, @thibaulltt

I'm not very familiar with the area. If it really is a bug, I wonder how such trivial behavior went unnoticed in the review of [D14658](https://archive.blender.org/developer/D14658). Cc @dr.sybren, @BClark, @thibaulltt

Brad Clark commented

2022-09-09 20:09:16 +02:00

Oh I can see how we missed it because there were so many issues around this feature to get it working that we were testing the core clip behavior and not moving clips into negative ranges.

Does it change if "allow negative frames is on for the timeline?" I am downloading 3.3 now and will check but just wondering if that makes a difference.

Oh I can see how we missed it because there were so many issues around this feature to get it working that we were testing the core clip behavior and not moving clips into negative ranges. Does it change if "allow negative frames is on for the timeline?" I am downloading 3.3 now and will check but just wondering if that makes a difference.

Adam Janz commented

2022-09-09 20:12:47 +02:00

Hi Brad, no that setting doesn't make any difference, I actually checked that a bit earlier today. In fact, "Allow Negative Frames" only permits the user to make the current frame negative. It does not permit a user to set the Start frame of the timeline to negative. EDIT: At least that is the behavior in 3.3 beta b3fc8206be released on August 9 (I have not tried the official 3.3 release yet).

Hi Brad, no that setting doesn't make any difference, I actually checked that a bit earlier today. In fact, "Allow Negative Frames" only permits the user to make the current frame negative. It does not permit a user to set the Start frame of the timeline to negative. EDIT: At least that is the behavior in 3.3 beta b3fc8206be42 released on August 9 (I have not tried the official 3.3 release yet).

Germano Cavalcante commented

2022-09-09 20:16:25 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Artur Tavares commented

2022-09-11 21:30:29 +02:00

Added subscriber: @artutava

Artur Tavares commented

2022-09-11 21:30:29 +02:00

Happening here on 3.3 offical release. It's a very important bug... Wondering if opening files that were created in previous versions will affect the nla. @AdamJanz @BClark

Philipp Oeser changed title from ~~The start frame of NLA tracks can not be negative.~~ to Regression: The start frame of NLA tracks can not be negative.

2022-09-12 09:24:17 +02:00

Thibault de Villèle commented

2022-09-12 11:07:47 +02:00

Added subscriber: @lichtwerk

Thibault de Villèle commented

2022-09-12 11:07:47 +02:00

Hi there everyone, I've been on a bit of a crunch lately due to work. The fix is quite simple, I simply made a typo in the code for BKE_nlastrip_compute_frame_from_previous_strip().

In the NLA code, we have two sets of macros :

MINFRAME- [x] for the integer and floating-point macros for the smallest frame value which can be represented by the program (a.k.a the closest to 0),
MINAFRAME- [x] for the integer and floating-point macros for the lowest frame value which can be represented by the program.

In the function outlined above, I simply made a typo and forgot the A in the middle of the name :)

I'll make a patch, and see how fast I can make it available in a general release (could this maybe be a hotfix for the next patch version @lichtwerk ? maybe 3.3.1 ?)

Hi there everyone, I've been on a bit of a crunch lately due to work. The fix is quite simple, I simply made a typo in the code for `BKE_nlastrip_compute_frame_from_previous_strip()`. In the NLA code, we have two sets of macros : - `MINFRAME- [x]` for the integer and floating-point macros for the ***smallest*** frame value which can be represented by the program (a.k.a the closest to 0), - `MINAFRAME- [x]` for the integer and floating-point macros for the ***lowest*** frame value which can be represented by the program. In the function outlined above, I simply made a typo and forgot the `A` in the middle of the name :) I'll make a patch, and see how fast I can make it available in a general release (could this maybe be a hotfix for the next patch version @lichtwerk ? maybe 3.3.1 ?)

Thibault de Villèle commented

2022-09-12 11:16:53 +02:00

To everyone here, see : D15940

To everyone here, see : [D15940](https://archive.blender.org/developer/D15940)

Philipp Oeser commented

2022-09-12 11:56:32 +02:00

In #100918#1415460, @thibaulltt wrote:
I'll make a patch, and see how fast I can make it available in a general release (could this maybe be a hotfix for the next patch version @lichtwerk ? maybe 3.3.1 ?)

Once committed, could be added here, yes #100749 (Blender LTS: Maintenance Task 3.3)

> In #100918#1415460, @thibaulltt wrote: > I'll make a patch, and see how fast I can make it available in a general release (could this maybe be a hotfix for the next patch version @lichtwerk ? maybe 3.3.1 ?) Once committed, could be added here, yes #100749 (Blender LTS: Maintenance Task 3.3)

blender-admin commented

2022-09-12 17:07:29 +02:00

This issue was referenced by 7c33d7b4b5

This issue was referenced by 7c33d7b4b5b334ed6d9c9585367982dc02671b52

Sybren A. Stüvel commented

2022-09-12 17:13:35 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Sybren A. Stüvel closed this issue

2022-09-12 17:13:35 +02:00

Sybren A. Stüvel self-assigned this 2022-09-12 17:13:35 +02:00

Adam Janz commented

2022-09-12 17:49:54 +02:00

Wonderful! Thanks so much for the fix! Have a great week ahead guys. :-)

Alexandre Labedade commented

2022-09-12 19:04:33 +02:00

That was quick ! Thank you very much !

Artur Tavares commented

2022-09-12 19:14:41 +02:00

Very quick!! Is that a build for that already?

Thibault de Villèle commented

2022-09-12 19:38:11 +02:00

@artutava I don't think so. I would suggest checking back tomorrow at noon UTC for a daily master build over on https://builder.blender.org/download/daily/ to get the latest master build. However, be warned : those are technically beta builds and prone to crashing (not everything that ends up on master is stable, after all).

EDIT : while the link says daily builds of Blender are stable for the 3.3 version, I do not know which branch they originate from. If it's master, consider it beta. If it's blender-v3.3-release, it's way more stable since this is the LTS branch with a lot of fixes.

@artutava I don't think so. I would suggest checking back tomorrow at noon UTC for a daily master build over on https://builder.blender.org/download/daily/ to get the latest master build. However, be warned : those are technically beta builds and prone to crashing (not everything that ends up on master is stable, after all). EDIT : while the link says daily builds of Blender are stable for the 3.3 version, I do not know which branch they originate from. If it's `master`, consider it beta. If it's `blender-v3.3-release`, it's way more stable since this is the LTS branch with a lot of fixes.

cmto commented

2022-09-14 03:01:51 +02:00

Added subscriber: @CHARLES-MURRAY