UV editor: missing UV outlines in texture paint mode #100926

Closed
opened 2022-09-08 22:39:50 +02:00 by Pam Hampton · 14 comments

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: AMD Radeon(TM) Vega 8 Graphics ATI Technologies Inc. 4.5.14761 Core Profile Context 21.30.24.03 30.0.13024.3004

Blender Version
Broken: version: 3.3.0, branch: master, commit date: 2022-09-06 15:39, hash: 0759f671ce
Worked: 2.83.20

Short description of error
UV outlines are missing when in Texture paint mode

Exact steps for others to reproduce the error

  • Open default file or attached file
  • Switch to UV workspace
  • Enable Display Texture Paint UVs
    Sweater 3D paint.blend
**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: AMD Radeon(TM) Vega 8 Graphics ATI Technologies Inc. 4.5.14761 Core Profile Context 21.30.24.03 30.0.13024.3004 **Blender Version** Broken: version: 3.3.0, branch: master, commit date: 2022-09-06 15:39, hash: `0759f671ce` Worked: 2.83.20 **Short description of error** UV outlines are missing when in Texture paint mode **Exact steps for others to reproduce the error** - Open default file or attached file - Switch to UV workspace - Enable `Display Texture Paint UVs` [Sweater 3D paint.blend](https://archive.blender.org/developer/F13470505/Sweater_3D_paint.blend)
Author

Added subscriber: @PamelaHampton

Added subscriber: @PamelaHampton
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Pratik Borhade changed title from While in Texture Paint Mode UV outline not shown in Image Windo Version 3.3 to UV editor: missing UV outlines in texture paint mode 2022-09-09 05:40:43 +02:00
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

In #100842#1412945, @lichtwerk wrote:

In #100842#1412836, @PratikPB2123 wrote:
Display Texture Paint UVs option seems not working in UV editor for a while (2.93 is affected too)

We should unify conditions for showing this option show_texpaint in regards to what the code is doing

  • Image Editor overlay popup (IMAGE_PT_overlay_texture_paint) only shows this in paintmode
  • View menu (IMAGE_MT_view) shows this in view mode, too
  • Code wise, we need to check edit_uv.do_uv_shadow_overlay for actually being set for the UV Editor (might make sense to draw them here as well? -- otherwise this should be removed from the view menu in the UV Editor)

@lichtwerk , now we've separate report for it

> In #100842#1412945, @lichtwerk wrote: >> In #100842#1412836, @PratikPB2123 wrote: >> `Display Texture Paint UVs` option seems not working in UV editor for a while (2.93 is affected too) > > We should unify conditions for showing this option `show_texpaint` in regards to what the code is doing > - Image Editor overlay popup (`IMAGE_PT_overlay_texture_paint`) only shows this in paintmode > - View menu (`IMAGE_MT_view`) shows this in view mode, too > - Code wise, we need to check `edit_uv.do_uv_shadow_overlay` for actually being set for the UV Editor (might make sense to draw them here as well? -- otherwise this should be removed from the view menu in the UV Editor) @lichtwerk , now we've separate report for it
Author

I retested with the same file in other versions and had the same problem. I then tested with a much simpler mesh, just the cube and there was no problem. I also tested with the sweater file again in 3.3 muting the complex texture, but that still didn't show the outline in image editor.

I retested with the same file in other versions and had the same problem. I then tested with a much simpler mesh, just the cube and there was no problem. I also tested with the sweater file again in 3.3 muting the complex texture, but that still didn't show the outline in image editor.
Author

Just test the sweater file in daily update of 3.4 and it works as expected.
Should I download 3.3 from Daily Build to see if that's now working?
Thanks,
Pam

Just test the sweater file in daily update of 3.4 and it works as expected. Should I download 3.3 from Daily Build to see if that's now working? Thanks, Pam

Added subscriber: @Chris_Blackbourn

Added subscriber: @Chris_Blackbourn

Debugging this one a wee bit, the following patch appears to "fix" the problem:

  pd->edit_uv.do_uv_shadow_overlay = show_overlays && is_image_type &&
                                     ((is_paint_mode && do_tex_paint_shadows &&
                                       ((draw_ctx->object_mode &
                                         (OB_MODE_TEXTURE_PAINT | OB_MODE_EDIT)) != 0)) ||
                                      (is_view_mode && do_tex_paint_shadows &&
                                       ((draw_ctx->object_mode & (OB_MODE_TEXTURE_PAINT)) != 0)) ||
                                      (do_uv_overlay && (show_modified_uvs)));

  pd->edit_uv.do_uv_shadow_overlay = true; /* source/blender/draw/engines/overlay/overlay_edit_uv.c Line 146 */
Debugging this one a wee bit, the following patch appears to "fix" the problem: ``` pd->edit_uv.do_uv_shadow_overlay = show_overlays && is_image_type && ((is_paint_mode && do_tex_paint_shadows && ((draw_ctx->object_mode & (OB_MODE_TEXTURE_PAINT | OB_MODE_EDIT)) != 0)) || (is_view_mode && do_tex_paint_shadows && ((draw_ctx->object_mode & (OB_MODE_TEXTURE_PAINT)) != 0)) || (do_uv_overlay && (show_modified_uvs))); pd->edit_uv.do_uv_shadow_overlay = true; /* source/blender/draw/engines/overlay/overlay_edit_uv.c Line 146 */ ```
See also : https://developer.blender.org/T92614
Chris Blackbourn was assigned by Pratik Borhade 2022-11-14 04:31:10 +01:00

This issue was referenced by 34e9924086

This issue was referenced by 34e99240861ade6e03511cb7550f88de3271ff05

This issue was referenced by 5a03d212a9

This issue was referenced by 5a03d212a9ac25b44c299f05baf1b0f54d34c733

This issue was referenced by 4401c93e45

This issue was referenced by 4401c93e452fdfa537c701ddbd693a70a5247cd6

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#100926
No description provided.