Node editor: After cutting the node to Alt, the nodes are still moving apart #100958

New Issue

Iliya Katushenock · 2022-09-10T07:58:58+02:00

Iliya Katushenock commented

2022-09-10 07:58:58 +02:00

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.49

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-09-09 00:25, hash: 81558783e4
Worked: (newest version of Blender that worked as expected)

Short description of error
2022-09-10 08-57-53.mp4

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.49 **Blender Version** Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-09-09 00:25, hash: `81558783e4` Worked: (newest version of Blender that worked as expected) **Short description of error** [2022-09-10 08-57-53.mp4](https://archive.blender.org/developer/F13475644/2022-09-10_08-57-53.mp4)

Iliya Katushenock commented

2022-09-10 07:58:58 +02:00

Added subscriber: @mod_moder

Leon Schittek commented

2022-09-10 11:10:11 +02:00

Added subscriber: @lone_noel

Leon Schittek commented

2022-09-10 11:10:11 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Leon Schittek commented

2022-09-10 11:10:11 +02:00

I was able to reproduce this with an older build but it's fixed for me by this revert dc937c5aee. Can you confim that?

I agree that this and #100959 are probably related.

In e3ef6a6660 it was returning early with OPERATOR_CANCELLED, when no frame node was found (before it would always return OPERATOR_FINISHED). I assume that cancels the whole NODE_OT_translate_attach macro so it never gets to the NODE_OT_insert_offset operator which frees the NodeInsertOfsData.

The not freed NodeInsertOfsData then causes the auto-offset, when NODE_OT_move_detach_links is used to detach the links, since it also invokes NODE_OT_insert_offset.

I was able to reproduce this with an older build but it's fixed for me by this revert dc937c5aee. Can you confim that? --- I agree that this and #100959 are probably related. In e3ef6a6660 it was returning early with `OPERATOR_CANCELLED`, when no frame node was found (before it would always return `OPERATOR_FINISHED`). I assume that cancels the whole `NODE_OT_translate_attach` macro so it never gets to the `NODE_OT_insert_offset` operator which frees the `NodeInsertOfsData`. The not freed `NodeInsertOfsData` then causes the auto-offset, when `NODE_OT_move_detach_links` is used to detach the links, since it also invokes `NODE_OT_insert_offset`.

Iliya Katushenock commented

2022-09-10 11:16:42 +02:00

Changed status from 'Needs User Info' to: 'Archived'

Iliya Katushenock closed this issue

2022-09-10 11:16:42 +02:00

Iliya Katushenock commented

2022-09-10 11:16:42 +02:00

This happened to me in 1 assembly, rolled today at 3 am
Later, when I was looking for a memory leak, I downloaded a new version (~11 hours) and it no longer there

Yes, I noticed that if I drag the return node and hold Alt, immediately taking the 2nd node, a strange state occurs and now the nodes align incorrectly

This happened to me in 1 assembly, rolled today at 3 am Later, when I was looking for a memory leak, I downloaded a new version (~11 hours) and it no longer there Yes, I noticed that if I drag the return node and hold Alt, immediately taking the 2nd node, a strange state occurs and now the nodes align incorrectly

Iliya Katushenock commented

2022-09-10 11:17:14 +02:00

Oops, I accidentally changed the status, sorry

(This site may retain the selected feature even after a reboot. I forgot and didn't notice that it was chosen)

Oops, I accidentally changed the status, sorry (This site may retain the selected feature even after a reboot. I forgot and didn't notice that it was chosen)

Iliya Katushenock commented

2022-09-10 11:24:54 +02:00

Although, I think, if this was present only in the version that was at night, and in the current master it is no longer there, then okay

But at the expense of the leak, it was in a later build

Although, I think, if this was present only in the version that was at night, and in the current master it is no longer there, then okay But at the expense of the leak, it was in a later build

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Node editor: After cutting the node to Alt, the nodes are still moving apart #100958