Regression: Crash when left click on Point Density node #101001

Closed
opened 2022-09-12 12:30:46 +02:00 by Mohamed · 8 comments

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.65

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-09-12 00:27, hash: caf6225a3d
Caused by b0cb0a7854

Short description of error
Crash when left click on Point Density node

Exact steps for others to reproduce the error

  • open attached file crash bug 3.4.zip
  • in the Shading panel, left click Point Density node in the Circle material
**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 511.65 **Blender Version** Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-09-12 00:27, hash: `caf6225a3d` Caused by b0cb0a7854 **Short description of error** Crash when left click on Point Density node **Exact steps for others to reproduce the error** - open attached file [crash bug 3.4.zip](https://archive.blender.org/developer/F13483409/crash_bug_3.4.zip) - in the Shading panel, left click Point Density node in the Circle material
Author

Added subscriber: @MumuMundo

Added subscriber: @MumuMundo
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Can confirm in this particular case (havent been able to repro from scratch though)

Crashes when trying to set an image active in the Image Editor (syncing from the Node Editor) and ima->runtime.cache_mutex is garbled.

2  BLI_mutex_lock                              threads.cc         375  0xf412afd 
3  BKE_image_signal                            image.cc           3041 0x7f1be4  
4  ED_space_image_set                          image_edit.c       62   0x29007b3 
5  ED_node_set_active                          node_edit.cc       751  0x293b8bd 
6  blender::ed::space_node::node_mouse_select  node_select.cc     653  0x29518c9 
7  blender::ed::space_node::node_select_exec   node_select.cc     681  0x2951a0c 
8  blender::ed::space_node::node_select_invoke node_select.cc     694  0x2951a6c 
9  wm_operator_invoke                          wm_event_system.cc 1434 0x11685e2 
10 wm_handler_operator_call                    wm_event_system.cc 2469 0x116ac8f 
11 wm_handlers_do_keymap_with_keymap_handler   wm_event_system.cc 2861 0x116bd21 
12 wm_handlers_do_intern                       wm_event_system.cc 3187 0x116cca6 
13 wm_handlers_do                              wm_event_system.cc 3325 0x116d3aa 
14 wm_event_do_region_handlers                 wm_event_system.cc 3744 0x116e8bb 
15 wm_event_do_handlers_area_regions           wm_event_system.cc 3774 0x116ea03 
16 wm_event_do_handlers                        wm_event_system.cc 3970 0x116f4fe 
17 WM_main                                     wm.c               640  0x115f2f9 
Can confirm in this particular case (havent been able to repro from scratch though) Crashes when trying to set an image active in the Image Editor (syncing from the Node Editor) and `ima`->`runtime`.`cache_mutex` is garbled. ``` 2 BLI_mutex_lock threads.cc 375 0xf412afd 3 BKE_image_signal image.cc 3041 0x7f1be4 4 ED_space_image_set image_edit.c 62 0x29007b3 5 ED_node_set_active node_edit.cc 751 0x293b8bd 6 blender::ed::space_node::node_mouse_select node_select.cc 653 0x29518c9 7 blender::ed::space_node::node_select_exec node_select.cc 681 0x2951a0c 8 blender::ed::space_node::node_select_invoke node_select.cc 694 0x2951a6c 9 wm_operator_invoke wm_event_system.cc 1434 0x11685e2 10 wm_handler_operator_call wm_event_system.cc 2469 0x116ac8f 11 wm_handlers_do_keymap_with_keymap_handler wm_event_system.cc 2861 0x116bd21 12 wm_handlers_do_intern wm_event_system.cc 3187 0x116cca6 13 wm_handlers_do wm_event_system.cc 3325 0x116d3aa 14 wm_event_do_region_handlers wm_event_system.cc 3744 0x116e8bb 15 wm_event_do_handlers_area_regions wm_event_system.cc 3774 0x116ea03 16 wm_event_do_handlers wm_event_system.cc 3970 0x116f4fe 17 WM_main wm.c 640 0x115f2f9 ```
Philipp Oeser self-assigned this 2022-09-12 13:21:19 +02:00
Member

OK, can repro with other nodes.
The thing is that code tries to sync an image to the Image Editor and assumes

Image *image = (Image *)node->id;

But node->id is not always an image:

  • could be an object (as reported here with the Point Density node)
  • could be a textblock (as in the IES Texture node)

Will check on a fix

OK, can repro with other nodes. The thing is that code tries to sync an image to the Image Editor and assumes ``` Image *image = (Image *)node->id; ``` But `node->id` is not always an image: - could be an object (as reported here with the `Point Density` node) - could be a textblock (as in the `IES Texture` node) Will check on a fix

This issue was referenced by 3a880b820b

This issue was referenced by 3a880b820b4229481ec6dc91a5b597fe50da5926

This issue was referenced by 22b69ed08f

This issue was referenced by 22b69ed08f7b57a5ba6a53322481f984511b3ecf
Philipp Oeser changed title from Crash when left click on Point Density node to Regression: Crash when left click on Point Density node 2022-09-13 14:22:22 +02:00
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
FBX
Interest
Freestyle
Interest
Geometry Nodes
Interest
glTF
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Asset System
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#101001
No description provided.