Curves sculptmode: crash when using curve stroke in any tool #101062

New Issue

Dalai Felinto · 2022-09-14T12:49:20+02:00

Dalai Felinto commented

2022-09-14 12:49:20 +02:00

Blender Version
Broken: version: 3.3.0, branch: master, commit date: 2022-09-06 15:39, hash: 0759f671ce
Worked: -

Short description of error
Crash when trying to use the curve stroke with the Density tool in the new hair system.

Exact steps for others to reproduce the error
hair-curve.blend

Try to use the tool will lead to a crash.

**Blender Version** Broken: version: 3.3.0, branch: master, commit date: 2022-09-06 15:39, hash: `0759f671ce` Worked: - **Short description of error** Crash when trying to use the curve stroke with the Density tool in the new hair system. **Exact steps for others to reproduce the error** [hair-curve.blend](https://archive.blender.org/developer/F13491807/hair-curve.blend) Try to use the tool will lead to a crash.

Dalai Felinto commented

2022-09-14 12:49:21 +02:00

Added subscriber: @dfelinto

Dalai Felinto commented

2022-09-14 12:49:44 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-09-29 12:01:56 +02:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2022-09-29 12:01:56 +02:00

Philipp Oeser commented

2022-09-29 12:01:56 +02:00

On a fix...

blender-admin commented

2022-09-29 12:57:48 +02:00

This issue was referenced by 6810deb521

This issue was referenced by 6810deb5215df3ee7d92d7972988092f1aab5eae

blender-admin commented

2022-09-29 12:57:48 +02:00

This issue was referenced by 3f91540cef

This issue was referenced by 3f91540cef7e28e372248804b1f6fbe2fc271bbb

Philipp Oeser commented

2022-10-11 15:05:11 +02:00

Dropping a sidenote to myself (for a future bug report): even with D16099 applied, it is not possible to transform paintcurve points via the transform system, see TransConvertType_PaintCurve (instead, blender will move the hair object).
(it is possible though with mouse click-dragging)

Dropping a sidenote to myself (for a future bug report): even with [D16099](https://archive.blender.org/developer/D16099) applied, it is not possible to transform paintcurve points via the transform system, see `TransConvertType_PaintCurve` (instead, blender will move the hair object). (it is possible though with mouse click-dragging)

Philipp Oeser commented

2022-10-11 15:16:30 +02:00

In #101062#1430753, @lichtwerk wrote:
Dropping a sidenote to myself (for a future bug report): even with D16099 applied, it is not possible to transform paintcurve points via the transform system, see TransConvertType_PaintCurve (instead, blender will move the hair object).
(it is possible though with mouse click-dragging)

This might boil down to carefully checking/following the OB_MODE_ALL_PAINT or related macros, P3248 would work

> In #101062#1430753, @lichtwerk wrote: > Dropping a sidenote to myself (for a future bug report): even with [D16099](https://archive.blender.org/developer/D16099) applied, it is not possible to transform paintcurve points via the transform system, see `TransConvertType_PaintCurve` (instead, blender will move the hair object). > (it is possible though with mouse click-dragging) This might boil down to carefully checking/following the `OB_MODE_ALL_PAINT` or related macros, [P3248](https://archive.blender.org/developer/P3248.txt) would work

Philipp Oeser changed title from ~~Crash when using curve stroke for hair grooming~~ to Curves sculptmode: crash when using curve stroke in any tool

2022-10-12 10:42:34 +02:00

Dalai Felinto commented

2022-10-13 10:38:59 +02:00

Good finding, but following that line of thought the correct fix should be:

diff --git a/source/blender/makesdna/DNA_object_enums.h b/source/blender/makesdna/DNA_object_enums.h
index 3a3e4a01d7c..6793ccd64da 100644
--- a/source/blender/makesdna/DNA_object_enums.h
+++ b/source/blender/makesdna/DNA_object_enums.h
@@ -42,7 +42,8 @@ typedef enum eDrawType {
 
 /** Any mode where the brush system is used. */
 #define OB_MODE_ALL_PAINT \
-  (OB_MODE_SCULPT | OB_MODE_VERTEX_PAINT | OB_MODE_WEIGHT_PAINT | OB_MODE_TEXTURE_PAINT)
+  (OB_MODE_SCULPT | OB_MODE_VERTEX_PAINT | OB_MODE_WEIGHT_PAINT | OB_MODE_TEXTURE_PAINT | \
+   OB_MODE_SCULPT_CURVES)
 
 #define OB_MODE_ALL_PAINT_GPENCIL \
   (OB_MODE_PAINT_GPENCIL | OB_MODE_SCULPT_GPENCIL | OB_MODE_WEIGHT_GPENCIL | \

Good finding, but following that line of thought the correct fix should be: ``` diff --git a/source/blender/makesdna/DNA_object_enums.h b/source/blender/makesdna/DNA_object_enums.h index 3a3e4a01d7c..6793ccd64da 100644 --- a/source/blender/makesdna/DNA_object_enums.h +++ b/source/blender/makesdna/DNA_object_enums.h @@ -42,7 +42,8 @@ typedef enum eDrawType { /** Any mode where the brush system is used. */ #define OB_MODE_ALL_PAINT \ - (OB_MODE_SCULPT | OB_MODE_VERTEX_PAINT | OB_MODE_WEIGHT_PAINT | OB_MODE_TEXTURE_PAINT) + (OB_MODE_SCULPT | OB_MODE_VERTEX_PAINT | OB_MODE_WEIGHT_PAINT | OB_MODE_TEXTURE_PAINT | \ + OB_MODE_SCULPT_CURVES) #define OB_MODE_ALL_PAINT_GPENCIL \ (OB_MODE_PAINT_GPENCIL | OB_MODE_SCULPT_GPENCIL | OB_MODE_WEIGHT_GPENCIL | \ ```

Philipp Oeser commented

2022-10-13 11:24:52 +02:00

Yeah, after carefully checking all usages of OB_MODE_ALL_PAINT, that was the plan :)

Yeah, after carefully checking all usages of `OB_MODE_ALL_PAINT`, that was the plan :)

Philipp Oeser commented

2022-11-01 12:29:04 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2022-11-01 12:29:04 +01:00

Christoph Lendenfeld referenced this issue

2023-02-10 11:56:22 +01:00

Blender LTS: Maintenance Task 3.3 #100749