Curves sculptmode: crash when using curve stroke in any tool #101062

Closed
opened 2022-09-14 12:49:20 +02:00 by Dalai Felinto · 11 comments

Blender Version
Broken: version: 3.3.0, branch: master, commit date: 2022-09-06 15:39, hash: 0759f671ce
Worked: -

Short description of error
Crash when trying to use the curve stroke with the Density tool in the new hair system.

Exact steps for others to reproduce the error
hair-curve.blend

Try to use the tool will lead to a crash.

**Blender Version** Broken: version: 3.3.0, branch: master, commit date: 2022-09-06 15:39, hash: `0759f671ce` Worked: - **Short description of error** Crash when trying to use the curve stroke with the Density tool in the new hair system. **Exact steps for others to reproduce the error** [hair-curve.blend](https://archive.blender.org/developer/F13491807/hair-curve.blend) Try to use the tool will lead to a crash.
Author
Owner

Added subscriber: @dfelinto

Added subscriber: @dfelinto
Author
Owner

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Philipp Oeser self-assigned this 2022-09-29 12:01:56 +02:00
Member

On a fix...

On a fix...

This issue was referenced by 6810deb521

This issue was referenced by 6810deb5215df3ee7d92d7972988092f1aab5eae

This issue was referenced by 3f91540cef

This issue was referenced by 3f91540cef7e28e372248804b1f6fbe2fc271bbb
Member

Dropping a sidenote to myself (for a future bug report): even with D16099 applied, it is not possible to transform paintcurve points via the transform system, see TransConvertType_PaintCurve (instead, blender will move the hair object).
(it is possible though with mouse click-dragging)

Dropping a sidenote to myself (for a future bug report): even with [D16099](https://archive.blender.org/developer/D16099) applied, it is not possible to transform paintcurve points via the transform system, see `TransConvertType_PaintCurve` (instead, blender will move the hair object). (it is possible though with mouse click-dragging)
Member

In #101062#1430753, @lichtwerk wrote:
Dropping a sidenote to myself (for a future bug report): even with D16099 applied, it is not possible to transform paintcurve points via the transform system, see TransConvertType_PaintCurve (instead, blender will move the hair object).
(it is possible though with mouse click-dragging)

This might boil down to carefully checking/following the OB_MODE_ALL_PAINT or related macros, P3248 would work

> In #101062#1430753, @lichtwerk wrote: > Dropping a sidenote to myself (for a future bug report): even with [D16099](https://archive.blender.org/developer/D16099) applied, it is not possible to transform paintcurve points via the transform system, see `TransConvertType_PaintCurve` (instead, blender will move the hair object). > (it is possible though with mouse click-dragging) This might boil down to carefully checking/following the `OB_MODE_ALL_PAINT` or related macros, [P3248](https://archive.blender.org/developer/P3248.txt) would work
Philipp Oeser changed title from Crash when using curve stroke for hair grooming to Curves sculptmode: crash when using curve stroke in any tool 2022-10-12 10:42:34 +02:00
Author
Owner

Good finding, but following that line of thought the correct fix should be:

diff --git a/source/blender/makesdna/DNA_object_enums.h b/source/blender/makesdna/DNA_object_enums.h
index 3a3e4a01d7c..6793ccd64da 100644
--- a/source/blender/makesdna/DNA_object_enums.h
+++ b/source/blender/makesdna/DNA_object_enums.h
@@ -42,7 +42,8 @@ typedef enum eDrawType {
 
 /** Any mode where the brush system is used. */
 #define OB_MODE_ALL_PAINT \
-  (OB_MODE_SCULPT | OB_MODE_VERTEX_PAINT | OB_MODE_WEIGHT_PAINT | OB_MODE_TEXTURE_PAINT)
+  (OB_MODE_SCULPT | OB_MODE_VERTEX_PAINT | OB_MODE_WEIGHT_PAINT | OB_MODE_TEXTURE_PAINT | \
+   OB_MODE_SCULPT_CURVES)
 
 #define OB_MODE_ALL_PAINT_GPENCIL \
   (OB_MODE_PAINT_GPENCIL | OB_MODE_SCULPT_GPENCIL | OB_MODE_WEIGHT_GPENCIL | \
Good finding, but following that line of thought the correct fix should be: ``` diff --git a/source/blender/makesdna/DNA_object_enums.h b/source/blender/makesdna/DNA_object_enums.h index 3a3e4a01d7c..6793ccd64da 100644 --- a/source/blender/makesdna/DNA_object_enums.h +++ b/source/blender/makesdna/DNA_object_enums.h @@ -42,7 +42,8 @@ typedef enum eDrawType { /** Any mode where the brush system is used. */ #define OB_MODE_ALL_PAINT \ - (OB_MODE_SCULPT | OB_MODE_VERTEX_PAINT | OB_MODE_WEIGHT_PAINT | OB_MODE_TEXTURE_PAINT) + (OB_MODE_SCULPT | OB_MODE_VERTEX_PAINT | OB_MODE_WEIGHT_PAINT | OB_MODE_TEXTURE_PAINT | \ + OB_MODE_SCULPT_CURVES) #define OB_MODE_ALL_PAINT_GPENCIL \ (OB_MODE_PAINT_GPENCIL | OB_MODE_SCULPT_GPENCIL | OB_MODE_WEIGHT_GPENCIL | \ ```
Member

Yeah, after carefully checking all usages of OB_MODE_ALL_PAINT, that was the plan :)

Yeah, after carefully checking all usages of `OB_MODE_ALL_PAINT`, that was the plan :)
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset System
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Code Documentation
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Viewport & EEVEE
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Asset Browser Project
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Module
Viewport & EEVEE
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Severity
High
Severity
Low
Severity
Normal
Severity
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#101062
No description provided.