Regression: Screw Modifier Calculate Order is broken #101075

New Issue

Ziggy Spooner · 2022-09-14T23:22:04+02:00

Ziggy Spooner commented

2022-09-14 23:22:04 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: GeForce GTX 950M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 398.35

Blender Version
Broken: version: 3.3.1 Release Candidate, branch: master, commit date: 2022-09-12 18:27, hash: 19ae71c113
Worked: 3.2.2

Caused by: a5190dce9d

Short description of error
Vertex ordering calculation in the Screw Modifier no longer works properly in 3.3
Calculate Order Error.blend
I have included a Solidify modifier to make the problem obvious, but solidify does not appear to be part of the problem.

Exact steps for others to reproduce the error
Load attached file
Calculate Order Error.blend
in Blender 3.3.0 or later and the vertex order is calculated incorrectly:

In Blender 3.2.2 and earlier, it works properly:

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: GeForce GTX 950M/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 398.35 **Blender Version** Broken: version: 3.3.1 Release Candidate, branch: master, commit date: 2022-09-12 18:27, hash: `19ae71c113` Worked: 3.2.2 Caused by: a5190dce9d08a4fdaddf82d592e50083e0713e19 **Short description of error** Vertex ordering calculation in the Screw Modifier no longer works properly in 3.3 [Calculate Order Error.blend](https://archive.blender.org/developer/F13493580/Calculate_Order_Error.blend) I have included a Solidify modifier to make the problem obvious, but solidify does not appear to be part of the problem. **Exact steps for others to reproduce the error** Load attached file [Calculate Order Error.blend](https://archive.blender.org/developer/F13493580/Calculate_Order_Error.blend) in Blender 3.3.0 or later and the vertex order is calculated incorrectly: ![image.png](https://archive.blender.org/developer/F13493588/image.png) In Blender 3.2.2 and earlier, it works properly: ![image.png](https://archive.blender.org/developer/F13493603/image.png)

Ziggy Spooner commented

2022-09-14 23:22:04 +02:00

Added subscriber: @Dudecon

blender-admin commented

2022-09-14 23:22:04 +02:00

#101879 was marked as duplicate of this issue

Ziggy Spooner commented

2022-09-14 23:46:38 +02:00

I recommend using the "convert to curve" method of vertex ordering (split vertex), since it is robust under 3+ edges per vertex.

The old Screw modifier did not handle these cases well (arbitrary re-ordering with unpredictable break in normals)

I recommend using the "convert to curve" method of vertex ordering (split vertex), since it is robust under 3+ edges per vertex. ![image.png](https://archive.blender.org/developer/F13493759/image.png) The old Screw modifier did not handle these cases well (arbitrary re-ordering with unpredictable break in normals)

Omar Emara commented

2022-09-15 11:47:41 +02:00

Added subscriber: @OmarEmaraDev

Omar Emara commented

2022-09-15 12:31:03 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Omar Emara commented

2022-09-15 12:31:03 +02:00

Caused by a5190dce9d.

Caused by a5190dce9d08a4fdaddf82d592e50083e0713e19.

Omar Emara commented

2022-09-15 12:31:23 +02:00

Added subscriber: @HooglyBoogly

Omar Emara changed title from ~~Screw Modifier, Calculate Order broken~~ to Regression: Screw Modifier Calculate Order is broken

2022-09-15 12:31:54 +02:00

Hans Goudey self-assigned this 2022-09-15 13:54:21 +02:00

Hans Goudey commented

2022-09-26 23:38:07 +02:00

This problem was exposed by the above commit, but the actual problem is in the screw modifier, which creates invalid normals and then clears the dirty flag.

{F13576965 size=full}

Calculating normals eagerly in some cases is helpful, but I don't think the screw modifier is one of the places where it's necessary.

This problem was exposed by the above commit, but the actual problem is in the screw modifier, which creates invalid normals and then clears the dirty flag. | {[F13576965](https://archive.blender.org/developer/F13576965/image.png) size=full} | ![image.png](https://archive.blender.org/developer/F13577022/image.png) | ![image.png](https://archive.blender.org/developer/F13577025/image.png) | | -- | -- | -- | Calculating normals eagerly in some cases is helpful, but I don't think the screw modifier is one of the places where it's necessary.

blender-admin commented

2022-09-27 00:59:44 +02:00

This issue was referenced by 86538e31f5

This issue was referenced by 86538e31f5945009b6fae0f14b958ed07762f016

blender-admin commented

2022-09-27 00:59:44 +02:00

This issue was referenced by dcd909122f

This issue was referenced by dcd909122f9ad644dcc11e49f565e58dabe276e2

Hans Goudey commented

2022-09-27 01:06:41 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Hans Goudey closed this issue

2022-09-27 01:06:41 +02:00

Chipp Walters commented

2022-09-30 21:38:24 +02:00

Added subscriber: @chippwalters

Chipp Walters commented

2022-09-30 21:38:24 +02:00

I think you may have inadvertly screwed up the screw modifier again. Now it won't take a solidify modifier after it. See video below.

3.3.1 Release Candidate

https://youtu.be/hev_1-JGhl4

I've been told it's fixed in 3.4-- any chance of getting it fixed in 3.3?

Here's a solution FWIW for now:
You can also set the mode to Complex, and that fixes the issue. And because there are known workarounds and fixes, this isn't a high priority for me.

I think you may have inadvertly screwed up the screw modifier again. Now it won't take a solidify modifier after it. See video below. 3.3.1 Release Candidate https://youtu.be/hev_1-JGhl4 I've been told it's fixed in 3.4-- any chance of getting it fixed in 3.3? Here's a solution FWIW for now:![unknown.png](https://archive.blender.org/developer/F13599258/unknown.png) You can also set the mode to Complex, and that fixes the issue. And because there are known workarounds and fixes, this isn't a high priority for me.

Hans Goudey commented

2022-10-03 06:44:30 +02:00

Yeah, that looks like the same issue from this report. I added it to #100749 (Blender LTS: Maintenance Task 3.3), so the fix should hopefully make it into 3.3.1.