Selecting bones on linked rig has lag #101218

Open
opened 2022-09-20 14:42:02 +02:00 by Juan Pablo Bouza · 7 comments

Blender Version
Broken: version: 3.4.0 Alpha, branch: Unknown, commit date: Unknown Unknown, hash: rBUnknown
Worked: (newest version of Blender that worked as expected)

Short description of error
Alright, so I had a chat with Bastien and we agreed to make a bug report so that this had a record.

So in the zip you will find the files "character" and "link". The "link" file has the rig already linked. This is the new BlenRig 6 Rig and ever since we got library overrides people have been experiencing a certain lag when selecting bones on a linked rig.

This lag can go from milliseconds to a couple of seconds depending on scene load and CPU.

Bastien Suggested that disabling Global Undo could fix the lag and indeed it does fix it... but you know, it's not practical to be forced to working without Undo...

In the zip you will also find two files called "no_overrides", there I turned off library overrides for all properties. Unfortunately, the lag is still there when you link the rig.

I really don't know what could be causing this, animation playback works just fine, the lag happens when selecting bones and when scrubbing through the timeline. Maybe you could do some debugging and see what blender is doing on those two operations and why it's taking so long to perform them.

Exact steps for others to reproduce the error

  • Unzip the attached file - you will find the files "character" and "link"
  • Open the file link.blend
  • Select some bones to check the performance
  • Go to {nav Blender Preferences > System} and disable Global Undo
  • Select some bones to check the performance
    lib_overrides_lag.zip
**Blender Version** Broken: version: 3.4.0 Alpha, branch: Unknown, commit date: Unknown Unknown, hash: `rBUnknown` Worked: (newest version of Blender that worked as expected) **Short description of error** Alright, so I had a chat with Bastien and we agreed to make a bug report so that this had a record. So in the zip you will find the files "character" and "link". The "link" file has the rig already linked. This is the new [BlenRig 6 ](https://blenderartists.org/t/blenrig-6-release/660103) Rig and ever since we got library overrides people have been experiencing a certain lag when selecting bones on a linked rig. This lag can go from milliseconds to a couple of seconds depending on scene load and CPU. Bastien Suggested that disabling Global Undo could fix the lag and indeed it does fix it... but you know, it's not practical to be forced to working without Undo... In the zip you will also find two files called "no_overrides", there I turned off library overrides for all properties. Unfortunately, the lag is still there when you link the rig. I really don't know what could be causing this, animation playback works just fine, the lag happens when selecting bones and when scrubbing through the timeline. Maybe you could do some debugging and see what blender is doing on those two operations and why it's taking so long to perform them. **Exact steps for others to reproduce the error** - Unzip the attached file - you will find the files "character" and "link" - Open the file `link.blend` - Select some bones to check the performance - Go to {nav Blender Preferences > System} and disable `Global Undo` - Select some bones to check the performance [lib_overrides_lag.zip](https://archive.blender.org/developer/F13528517/lib_overrides_lag.zip)
Author
Member

Added subscriber: @jpbouza-4

Added subscriber: @jpbouza-4
Bastien Montagne was assigned by Juan Pablo Bouza 2022-09-20 14:43:41 +02:00
Author
Member

Added subscriber: @dr.sybren

Added subscriber: @dr.sybren

Added subscribers: @mont29, @mano-wii

Added subscribers: @mont29, @mano-wii

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

Thanks for the report, I can confirm the lag.

As a suggestion for future reports, please make sure to follow our submission template and guidelines, also read these tips about bug reports, to make a complete, valid bug report, with required info, precise description of the issue, precise steps to reproduce it, small and simple .blend and/or other files to do so if needed, etc.

Thanks for the report, I can confirm the lag. As a suggestion for future reports, please make sure to follow our [submission template and guidelines](https:*developer.blender.org/maniphest/task/edit/form/1/), also read [these tips about bug reports]( https:*wiki.blender.org/wiki/Process/Bug_Reports), to make a complete, valid bug report, with required info, precise description of the issue, precise steps to reproduce it, small and simple .blend and/or other files to do so if needed, etc.

This rig has about 2.5k bones, 1k drivers... This is just a giant amount of data to compare. On my machine, override diffing is around 200ms.

Thing is, override diffing is only performed as part of undo steps to ensure proper feedback for user in the UI (so that edited override property get proper color there).

Ideal solution would be to process these diffing in a completely async process, in some kind of jobs, but this has a lot of technical challenges.

band-aid solution would be to have an option to disable this override diffing on undo step storage, but that's fairly not satisfying.

This rig has about 2.5k bones, 1k drivers... This is just a giant amount of data to compare. On my machine, override diffing is around 200ms. Thing is, override diffing is only performed as part of undo steps to ensure proper feedback for user in the UI (so that edited override property get proper color there). Ideal solution would be to process these diffing in a completely async process, in some kind of jobs, but this has a lot of technical challenges. band-aid solution would be to have an option to disable this override diffing on undo step storage, but that's fairly not satisfying.
Bastien Montagne added this to the Core project 2023-02-07 14:18:22 +01:00
Philipp Oeser removed the
Interest
Core
label 2023-02-09 14:42:47 +01:00
Bastien Montagne removed this from the Core project 2023-02-09 18:20:30 +01:00
Member

The studio I'm working for has hit this and it is a big usability problem. Disabling global undo just to be able to animate properly is a bit extreme :)

The studio I'm working for has hit this and it is a big usability problem. Disabling global undo just to be able to animate properly is a bit extreme :)
Sybren A. Stüvel added the
Interest
Animation & Rigging
label 2023-06-22 10:34:25 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#101218
No description provided.