Regression: Node Editor: Crash On Typing or Scrolling In Add Search #101245

New Issue

RoyTheKoi · 2022-09-21T10:05:24+02:00

RoyTheKoi commented

2022-09-21 10:05:24 +02:00

System Information
MacBook Pro (16-inch, 2019)
Operating system: macOS Monterey 12.3
Processor: 2.3 GHz 8-Core Intel Core i9
Graphics card: AMD Radeon Pro 5500M 8 GB

Blender Version
Broken: 3.4.0, 6f15141f27, master, 2022-09-20
Worked: 3.4.0, ecf3435362, master, 2022-09-18
Broken by {bdb57541475f20ccc4f6e5f8fc075ac424becc19}

Short description of error
Blender crashes immediately after typing in the add node search bar, or scrolling past the last visible item. This occurs across all node editors including Shader Nodes, Geometry Nodes, and Compositing.

Exact steps for others to reproduce the error

Create an EXR image with width > 256 and a height of 1 (specifically any ratio greater than 256:1 horizontally or vertically)
Save the image externally in a folder
In Blender, assign that folder as an asset library under {nav Preferences > File Paths > Asset Libraries}
Restart Blender
Go to any node editor and use {nav Add > Search}
Type anything to crash Blender

**System Information** MacBook Pro (16-inch, 2019) Operating system: macOS Monterey 12.3 Processor: 2.3 GHz 8-Core Intel Core i9 Graphics card: AMD Radeon Pro 5500M 8 GB **Blender Version** Broken: 3.4.0, 6f15141f2731, master, 2022-09-20 Worked: 3.4.0, ecf3435362cf, master, 2022-09-18 Broken by {bdb57541475f20ccc4f6e5f8fc075ac424becc19} **Short description of error** Blender crashes immediately after typing in the add node search bar, or scrolling past the last visible item. This occurs across all node editors including Shader Nodes, Geometry Nodes, and Compositing. **Exact steps for others to reproduce the error** 1. Create an EXR image with width > 256 and a height of 1 (specifically any ratio greater than 256:1 horizontally or vertically) 2. Save the image externally in a folder 3. In Blender, assign that folder as an asset library under {nav Preferences > File Paths > Asset Libraries} 4. Restart Blender 5. Go to any node editor and use {nav Add > Search} 6. Type anything to crash Blender

RoyTheKoi commented

2022-09-21 10:05:24 +02:00

Added subscriber: @RoyTheKoi

Pratik Borhade commented

2022-09-21 11:55:50 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-09-21 11:55:50 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Pratik Borhade commented

2022-09-21 11:55:50 +02:00

Hi, thanks for the report. I'm not able to redo the crash as described in current master.
Do you use any add-ons? Maybe worth to check with factory settings: {nav File > Defaults > Load Factory Settings}

Hi, thanks for the report. I'm not able to redo the crash as described in current master. Do you use any add-ons? Maybe worth to check with factory settings: {nav File > Defaults > Load Factory Settings}

RoyTheKoi commented

2022-09-21 12:27:49 +02:00

Thanks for that suggestion, it solved the issue. It turned out to be some old versions of community addons that were causing python errors.

Pratik Borhade commented

2022-09-21 12:38:40 +02:00

It turned out to be some old versions of community addons that were causing python errors.

Thanks for the update. Which add-on BTW?

> It turned out to be some old versions of community addons that were causing python errors. Thanks for the update. Which add-on BTW?

RoyTheKoi commented

2022-09-21 13:18:08 +02:00

Actually after double checking, it seems the issue is related to something else, although I'm still trying to figure out what that is specifically.

I had thought that the addons (Radeon Pro Render and Animation Nodes, installed a while ago) were the problem since they were throwing python errors, and loading factory settings disabled them.
However without loading factory settings I was still getting crashes even after disabling all addons to be safe. So some other setting must be responsible instead.

Actually after double checking, it seems the issue is related to something else, although I'm still trying to figure out what that is specifically. I had thought that the addons (Radeon Pro Render and Animation Nodes, installed a while ago) were the problem since they were throwing python errors, and loading factory settings disabled them. However without loading factory settings I was still getting crashes even after disabling all addons to be safe. So some other setting must be responsible instead.

Pratik Borhade commented

2022-09-21 13:20:26 +02:00

bdb5754147 might be related but we need exact way to reproduce the crash to later fix it

bdb5754147 might be related but we need exact way to reproduce the crash to later fix it

RoyTheKoi commented

2022-09-21 14:49:28 +02:00

Asset libraries do seem to be the cause. Deleting the asset library paths under {nav Preferences -> File Paths -> Asset Libraries} stopped the crashes.

I am doing further testing to find the specific conditions that cause the crash.

Asset libraries do seem to be the cause. Deleting the asset library paths under {nav Preferences -> File Paths -> Asset Libraries} stopped the crashes. I am doing further testing to find the specific conditions that cause the crash.

RoyTheKoi commented

2022-09-21 16:01:20 +02:00

Opening Blender with terminal showed this message upon crashing:

OpenColorIO Error: PackedImageDesc Error: Invalid image dimensions.
Writing: /tmp/blender.crash.txt
Segmentation fault: 11

There was an EXR file with dimensions of 512x1 in one of my asset libraries. Removing it from the folder stopped the crashes.
I found that crashing would occur even if the folder contained nothing but this image alone.
To be thorough I tested other image dimensions and the threshold seems to be 256x1 pixels. Anything wider results in crashes.

To summarize the steps:

Create an EXR image with width > 256 and a height of 1 (specifically any ratio greater than 256:1 horizontally or vertically)
Save the image externally in a folder
In Blender, assign that folder as an asset library under {nav Preferences > File Paths > Asset Libraries}
Restart Blender
Go to any node editor and use {nav Add > Search}
Type anything to crash Blender

Opening Blender with terminal showed this message upon crashing: ``` OpenColorIO Error: PackedImageDesc Error: Invalid image dimensions. Writing: /tmp/blender.crash.txt Segmentation fault: 11 ``` There was an EXR file with dimensions of 512x1 in one of my asset libraries. Removing it from the folder stopped the crashes. I found that crashing would occur even if the folder contained nothing but this image alone. To be thorough I tested other image dimensions and the threshold seems to be 256x1 pixels. Anything wider results in crashes. To summarize the steps: 1. Create an EXR image with width > 256 and a height of 1 (specifically any ratio greater than 256:1 horizontally or vertically) 2. Save the image externally in a folder 3. In Blender, assign that folder as an asset library under {nav Preferences > File Paths > Asset Libraries} 4. Restart Blender 5. Go to any node editor and use {nav Add > Search} 6. Type anything to crash Blender

Pratik Borhade commented

2022-09-22 03:48:34 +02:00

Thanks for the further investigation. Still I'm unable to redo it.
Could you also upload the crash logs: https://docs.blender.org/manual/en/latest/troubleshooting/crash.html#macos

Thanks for the further investigation. Still I'm unable to redo it. Could you also upload the crash logs: https://docs.blender.org/manual/en/latest/troubleshooting/crash.html#macos

RoyTheKoi commented

2022-09-22 16:15:25 +02:00

It looks like Blender isn't generating logs for this crash. For what it's worth there is also no "Blender quit unexpectedly" dialog when the app closes like there is in some other cases.

I have reported a few other bugs/crashes before that only seem to affect this particular model of Mac, perhaps this is another one of those.

It looks like Blender isn't generating logs for this crash. For what it's worth there is also no "Blender quit unexpectedly" dialog when the app closes like there is in some other cases. I have reported a few other bugs/crashes before that only seem to affect this particular model of Mac, perhaps this is another one of those.

Pratik Borhade commented

2022-10-07 07:42:31 +02:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Pratik Borhade commented

2022-10-07 07:43:04 +02:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Pratik Borhade commented

2022-10-07 07:43:04 +02:00

Can you check again in recent 3.4 build?: https://builder.blender.org/download/daily/

Pratik Borhade commented

2022-10-20 07:54:19 +02:00

Hi, any news?

RoyTheKoi commented

2022-10-21 00:24:29 +02:00

Just checked on the most recent 3.4 daily build (October 20). The crash still occurs under the same conditions (placing a 257x1 pixel EXR image in an asset library folder then using the add-search menu).

Pratik Borhade commented

2022-10-21 03:37:56 +02:00

Changed status from 'Needs User Info' to: 'Needs Triage'

Germano Cavalcante commented

2022-10-22 18:15:24 +02:00

Added subscriber: @mano-wii

Germano Cavalcante commented

2022-10-22 18:15:24 +02:00

I cannot replicate the problem.
This is the image I tested:

Maybe it's a Mac only issue.
I don't have the Mac available at the moment to test (only next month).

I cannot replicate the problem. This is the image I tested: ![untitled.exr](https://archive.blender.org/developer/F13750154/untitled.exr) Maybe it's a Mac only issue. I don't have the Mac available at the moment to test (only next month).

Pratik Borhade commented

2022-12-02 13:04:41 +01:00

Added subscriber: @iss

Pratik Borhade commented

2022-12-02 13:04:41 +01:00

@iss, can you reproduce the crash in mac?

Richard Antalik commented

2022-12-03 01:19:08 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Richard Antalik commented

2022-12-03 01:19:08 +01:00

Can confirm, will bisect.

Richard Antalik changed title from ~~Node Editor: Crash On Typing or Scrolling In Add Search~~ to Regression: Node Editor: Crash On Typing or Scrolling In Add Search

2022-12-03 02:47:33 +01:00

Richard Antalik commented

2022-12-03 02:47:33 +01:00

Added subscriber: @HooglyBoogly

Hans Goudey self-assigned this 2022-12-05 15:58:06 +01:00

Hans Goudey removed their assignment 2022-12-05 19:31:38 +01:00

Hans Goudey commented

2022-12-05 19:31:38 +01:00

I can't reproduce this locally. Seems it is a mac-only issue. Without a stack trace at least, there's not much I can do right now.

Leon Schittek commented

2022-12-05 21:43:38 +01:00

Added subscriber: @lone_noel

Leon Schittek commented

2022-12-05 21:43:39 +01:00

Since I'm on mac I investigated this a bit.

The crash happens during the creation of thumbnails of .exr files with aspect ratio of greater than 256:1.
An easy and reliable way to reproduce the bug on mac is by opening the folder containing the problematic .exr in blender's file browser and switching to the thumbnail preview.

The core issue seems to be that because of float to int truncation imb_load_filepath_thumbnail_openexr creates the image buffer for the thumbnail with a height of 0, which causes OpenColorIO to abort with the following error:

OpenColorIO Error: PackedImageDesc Error: Invalid image dimensions.

Simply clamping the thumbnail dimensions to at least 1 like in the diff below fixes the crash for me, but I think someone with experience in this area should take a closer look :)

diff --git a/source/blender/imbuf/intern/openexr/openexr_api.cpp b/source/blender/imbuf/intern/openexr/openexr_api.cpp
index d2bdb5041c5..c17931827f7 100644
--- a/source/blender/imbuf/intern/openexr/openexr_api.cpp
+++ b/source/blender/imbuf/intern/openexr/openexr_api.cpp
@@ -2213,12 +2213,12 @@ struct ImBuf *imb_load_filepath_thumbnail_openexr(const char *filepath,
       colorspace_set_default_role(colorspace, IM_MAX_SPACE, COLOR_ROLE_DEFAULT_FLOAT);
     }
 
     float scale_factor = MIN2(float(max_thumb_size) / float(source_w),
                               float(max_thumb_size) / float(source_h));
-    int dest_w = int(source_w * scale_factor);
-    int dest_h = int(source_h * scale_factor);
+    int dest_w = MAX2(int(source_w * scale_factor), 1);
+    int dest_h = MAX2(int(source_h * scale_factor), 1);
 
     struct ImBuf *ibuf = IMB_allocImBuf(dest_w, dest_h, 32, IB_rectfloat);
 
     /* A single row of source pixels. */
     Imf::Array<Imf::Rgba> pixels(source_w);

Since I'm on mac I investigated this a bit. The crash happens during the creation of thumbnails of .exr files with aspect ratio of greater than 256:1. An easy and reliable way to reproduce the bug on mac is by opening the folder containing the problematic .exr in blender's file browser and switching to the thumbnail preview. The core issue seems to be that because of float to int truncation `imb_load_filepath_thumbnail_openexr` creates the image buffer for the thumbnail with a height of 0, which causes OpenColorIO to abort with the following error: ``` OpenColorIO Error: PackedImageDesc Error: Invalid image dimensions. ``` Simply clamping the thumbnail dimensions to at least 1 like in the diff below fixes the crash for me, but I think someone with experience in this area should take a closer look :) ``` diff --git a/source/blender/imbuf/intern/openexr/openexr_api.cpp b/source/blender/imbuf/intern/openexr/openexr_api.cpp index d2bdb5041c5..c17931827f7 100644 --- a/source/blender/imbuf/intern/openexr/openexr_api.cpp +++ b/source/blender/imbuf/intern/openexr/openexr_api.cpp @@ -2213,12 +2213,12 @@ struct ImBuf *imb_load_filepath_thumbnail_openexr(const char *filepath, colorspace_set_default_role(colorspace, IM_MAX_SPACE, COLOR_ROLE_DEFAULT_FLOAT); } float scale_factor = MIN2(float(max_thumb_size) / float(source_w), float(max_thumb_size) / float(source_h)); - int dest_w = int(source_w * scale_factor); - int dest_h = int(source_h * scale_factor); + int dest_w = MAX2(int(source_w * scale_factor), 1); + int dest_h = MAX2(int(source_h * scale_factor), 1); struct ImBuf *ibuf = IMB_allocImBuf(dest_w, dest_h, 32, IB_rectfloat); /* A single row of source pixels. */ Imf::Array<Imf::Rgba> pixels(source_w); ```

Hans Goudey commented

2022-12-05 21:56:23 +01:00

Added subscribers: @Harley, @ideasman42, @brecht

Hans Goudey commented

2022-12-05 21:56:23 +01:00

Thanks for investigating @lone_noel!

@brecht @ideasman42 @Harley (from D14663), the above solution looks simple enough to me, shall we use that?

Thanks for investigating @lone_noel! @brecht @ideasman42 @Harley (from [D14663](https://archive.blender.org/developer/D14663)), the above solution looks simple enough to me, shall we use that?

Harley Acheson commented

2022-12-05 22:09:19 +01:00

That looks like a great solution. Although... looks like I made the same mistake twice:

diff --git a/source/blender/imbuf/intern/openexr/openexr_api.cpp b/source/blender/imbuf/intern/openexr/openexr_api.cpp
index d2bdb5041c5d..c17931827f74 100644
--- a/source/blender/imbuf/intern/openexr/openexr_api.cpp
+++ b/source/blender/imbuf/intern/openexr/openexr_api.cpp
@@ -2215,8 +2215,8 @@ struct ImBuf *imb_load_filepath_thumbnail_openexr(const char *filepath,
 
     float scale_factor = MIN2(float(max_thumb_size) / float(source_w),
                               float(max_thumb_size) / float(source_h));
-    int dest_w = int(source_w * scale_factor);
-    int dest_h = int(source_h * scale_factor);
+    int dest_w = MAX2(int(source_w * scale_factor), 1);
+    int dest_h = MAX2(int(source_h * scale_factor), 1);
 
     struct ImBuf *ibuf = IMB_allocImBuf(dest_w, dest_h, 32, IB_rectfloat);
 
diff --git a/source/blender/imbuf/intern/webp.c b/source/blender/imbuf/intern/webp.c
index 3031b8c3e330..97a1d1981985 100644
--- a/source/blender/imbuf/intern/webp.c
+++ b/source/blender/imbuf/intern/webp.c
@@ -112,8 +112,8 @@ struct ImBuf *imb_load_filepath_thumbnail_webp(const char *filepath,
   *r_height = (size_t)config.input.height;
 
   const float scale = (float)max_thumb_size / MAX2(config.input.width, config.input.height);
-  const int dest_w = (int)(config.input.width * scale);
-  const int dest_h = (int)(config.input.height * scale);
+  const int dest_w = MAX2((int)(config.input.width * scale), 1);
+  const int dest_h = MAX2((int)(config.input.height * scale), 1);
 
   colorspace_set_default_role(colorspace, IM_MAX_SPACE, COLOR_ROLE_DEFAULT_BYTE);
   struct ImBuf *ibuf = IMB_allocImBuf(dest_w, dest_h, 32, IB_rect);

That looks like a great solution. Although... looks like I made the same mistake twice: ``` diff --git a/source/blender/imbuf/intern/openexr/openexr_api.cpp b/source/blender/imbuf/intern/openexr/openexr_api.cpp index d2bdb5041c5d..c17931827f74 100644 --- a/source/blender/imbuf/intern/openexr/openexr_api.cpp +++ b/source/blender/imbuf/intern/openexr/openexr_api.cpp @@ -2215,8 +2215,8 @@ struct ImBuf *imb_load_filepath_thumbnail_openexr(const char *filepath, float scale_factor = MIN2(float(max_thumb_size) / float(source_w), float(max_thumb_size) / float(source_h)); - int dest_w = int(source_w * scale_factor); - int dest_h = int(source_h * scale_factor); + int dest_w = MAX2(int(source_w * scale_factor), 1); + int dest_h = MAX2(int(source_h * scale_factor), 1); struct ImBuf *ibuf = IMB_allocImBuf(dest_w, dest_h, 32, IB_rectfloat); diff --git a/source/blender/imbuf/intern/webp.c b/source/blender/imbuf/intern/webp.c index 3031b8c3e330..97a1d1981985 100644 --- a/source/blender/imbuf/intern/webp.c +++ b/source/blender/imbuf/intern/webp.c @@ -112,8 +112,8 @@ struct ImBuf *imb_load_filepath_thumbnail_webp(const char *filepath, *r_height = (size_t)config.input.height; const float scale = (float)max_thumb_size / MAX2(config.input.width, config.input.height); - const int dest_w = (int)(config.input.width * scale); - const int dest_h = (int)(config.input.height * scale); + const int dest_w = MAX2((int)(config.input.width * scale), 1); + const int dest_h = MAX2((int)(config.input.height * scale), 1); colorspace_set_default_role(colorspace, IM_MAX_SPACE, COLOR_ROLE_DEFAULT_BYTE); struct ImBuf *ibuf = IMB_allocImBuf(dest_w, dest_h, 32, IB_rect); ```

Brecht Van Lommel commented

2022-12-06 01:52:55 +01:00

The patch from @Harley looks good to me for blender-v3.4-release.

The patch from @Harley looks good to me for `blender-v3.4-release`.

Harley Acheson self-assigned this 2022-12-06 16:48:07 +01:00

Harley Acheson commented

2022-12-06 16:48:07 +01:00

on it.