Regression: Stretched image in the viewport when viewed from the lamp object #101533

New Issue

Oleg · 2022-10-01T17:36:52+02:00

Oleg commented

2022-10-01 17:36:52 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.59

Blender Version
Broken: version: 3.3.0, branch: master, commit date: 2022-09-06 15:39, hash: 0759f671ce
Worked: (3.2.2)
Caused by 2e70d5cb98

Short description of error
Stretched image in the viewport when viewed from the lamp. Bug present on EEVEE and material preview

Exact steps for others to reproduce the error
Open default scene, select lamp, switch to view from a lamp (ctrl+numpad 0), switch to material preview mode or eevee rendered mode. Problem on all lamps except the Sun lamp.

stretched out.blend

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.59 **Blender Version** Broken: version: 3.3.0, branch: master, commit date: 2022-09-06 15:39, hash: `0759f671ce` Worked: (3.2.2) Caused by 2e70d5cb98 **Short description of error** Stretched image in the viewport when viewed from the lamp. Bug present on EEVEE and material preview **Exact steps for others to reproduce the error** Open default scene, select lamp, switch to view from a lamp (ctrl+numpad 0), switch to material preview mode or eevee rendered mode. Problem on all lamps except the Sun lamp. ![Снимок.PNG](https://archive.blender.org/developer/F13603039/Снимок.PNG) [stretched out.blend](https://archive.blender.org/developer/F13603038/stretched_out.blend)

Oleg commented

2022-10-01 17:36:52 +02:00

Added subscriber: @SamBacket

blender-admin commented

2022-10-01 17:36:52 +02:00

#101817 was marked as duplicate of this issue

Iliya Katushenock commented

2022-10-01 17:47:06 +02:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2022-10-01 17:47:06 +02:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Iliya Katushenock commented

2022-10-01 17:47:06 +02:00

Something strange. There are 2 things that confuse me here:

Is there a real opportunity to watch from the camera-lamp?
It looks like eevee does not take this into account, and converts the image for the camera, not the lamp (blur direction) (also, if you move the lamp to the camera and center it, as well as zoom in on the screen view, the effect is minimized)

Something strange. There are 2 things that confuse me here: - Is there a real opportunity to watch from the camera-lamp? - It looks like eevee does not take this into account, and converts the image for the camera, not the lamp (blur direction) (also, if you move the lamp to the camera and center it, as well as zoom in on the screen view, the effect is minimized)

Pratik Borhade commented

2022-10-02 11:31:59 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-10-02 11:31:59 +02:00

Changed status from 'Needs Developer To Reproduce' to: 'Confirmed'

Pratik Borhade commented

2022-10-02 11:31:59 +02:00

I'll bisect it later. Regression, so raising the priority.

Pratik Borhade changed title from ~~Stretched image in the viewport when viewed from the lamp object on eevee~~ to Regression: Stretched image in the viewport when viewed from the lamp object

2022-10-02 11:32:24 +02:00

Pratik Borhade commented

2022-10-03 05:42:30 +02:00

Added subscriber: @pioverfour

Pratik Borhade commented

2022-10-03 05:42:30 +02:00

First bad commit- 2e70d5cb98
cc @pioverfour

First bad commit- 2e70d5cb98 cc @pioverfour

Damien Picard commented

2022-10-03 16:08:19 +02:00

Changed status from 'Confirmed' to: 'Needs Developer To Reproduce'

Damien Picard commented

2022-10-03 16:08:20 +02:00

The single change that causes this is the addition of char focus_subtarget[64] in the CameraDOFSettings struct in DNA_camera_types.h.

After that, the lamp behaves exactly like a camera with f-stop and dof ratio at 0.0.

Actually, the behavior existed before, just not with lamps. It can be reproduced in Blender 3.2 with a mesh object for instance.
mesh_as_camera.blend

My understanding is that this revealed a pre-existing faulty behavior in Eevee’s DoF evaluation: it never checks that the cam->dof struct is actually defined for the object, which it’s not for lights, and it thus points to a bad location.

A possible fix?

diff --git a/source/blender/draw/engines/eevee/eevee_depth_of_field.c b/source/blender/draw/engines/eevee/eevee_depth_of_field.c
index 0d14a0c5f61..caa63b9c54c 100644
--- a/source/blender/draw/engines/eevee/eevee_depth_of_field.c
+++ b/source/blender/draw/engines/eevee/eevee_depth_of_field.c
@@ -189,7 +189,7 @@ int EEVEE_depth_of_field_init(EEVEE_ViewLayerData *UNUSED(sldata),
   const DRWContextState *draw_ctx = DRW_context_state_get();
   const Scene *scene_eval = DEG_get_evaluated_scene(draw_ctx->depsgraph);
 
-  Camera *cam = (camera != NULL) ? camera->data : NULL;
+  Camera *cam = (camera != NULL && camera->type == OB_CAMERA) ? camera->data : NULL;
 
   if (cam && (cam->dof.flag & CAM_DOF_ENABLED)) {
     RegionView3D *rv3d = draw_ctx->rv3d;

In #101533#1426210, @mod_moder wrote:

Is there a real opportunity to watch from the camera-lamp?

Do you mean is there a use case for setting the light as a camera? If so, yes: it can be very useful to aim the light at a specific location.

The single change that causes this is the addition of `char focus_subtarget[64]` in the `CameraDOFSettings` struct in DNA_camera_types.h. After that, the lamp behaves exactly like a camera with f-stop and dof ratio at 0.0. Actually, the behavior existed before, just not with lamps. It can be reproduced in Blender 3.2 with a mesh object for instance. [mesh_as_camera.blend](https://archive.blender.org/developer/F13610249/mesh_as_camera.blend) My understanding is that this revealed a pre-existing faulty behavior in Eevee’s DoF evaluation: it never checks that the `cam->dof` struct is actually defined for the object, which it’s not for lights, and it thus points to a bad location. A possible fix? ``` diff --git a/source/blender/draw/engines/eevee/eevee_depth_of_field.c b/source/blender/draw/engines/eevee/eevee_depth_of_field.c index 0d14a0c5f61..caa63b9c54c 100644 --- a/source/blender/draw/engines/eevee/eevee_depth_of_field.c +++ b/source/blender/draw/engines/eevee/eevee_depth_of_field.c @@ -189,7 +189,7 @@ int EEVEE_depth_of_field_init(EEVEE_ViewLayerData *UNUSED(sldata), const DRWContextState *draw_ctx = DRW_context_state_get(); const Scene *scene_eval = DEG_get_evaluated_scene(draw_ctx->depsgraph); - Camera *cam = (camera != NULL) ? camera->data : NULL; + Camera *cam = (camera != NULL && camera->type == OB_CAMERA) ? camera->data : NULL; if (cam && (cam->dof.flag & CAM_DOF_ENABLED)) { RegionView3D *rv3d = draw_ctx->rv3d; ``` > In #101533#1426210, @mod_moder wrote: > - Is there a real opportunity to watch from the camera-lamp? Do you mean is there a use case for setting the light as a camera? If so, yes: it can be very useful to aim the light at a specific location.

Iliya Katushenock commented

2022-10-03 16:29:22 +02:00

I meant exactly that the lamp is set as a render camera

Miguel Pozo self-assigned this 2022-11-07 13:03:27 +01:00

blender-admin commented

2022-11-07 15:30:15 +01:00

This issue was referenced by d0e9a8c46a

This issue was referenced by d0e9a8c46aba056144b1bfe8ddd55cc1d6ccc56e

blender-admin commented

2022-11-07 15:30:15 +01:00

This issue was referenced by 84d8698488

This issue was referenced by 84d86984885759f8f21d382cc8c699341be626a3

Miguel Pozo commented

2022-11-07 15:31:14 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'

Miguel Pozo closed this issue

2022-11-07 15:31:14 +01:00

Miguel Pozo commented

2022-11-07 15:42:05 +01:00

@pioverfour Your suggested fix was right.

There was a similar issue in the workbench and the GP engine that I fixed too.

@pioverfour Your suggested fix was right. There was a similar issue in the workbench and the GP engine that I fixed too.

Damien Picard commented

2022-11-07 15:59:32 +01:00

In #101533#1442040, @pragma37 wrote:
@pioverfour Your suggested fix was right.

Good to know, thanks! I wasn’t too sure whether there could be a better one.

> In #101533#1442040, @pragma37 wrote: > @pioverfour Your suggested fix was right. Good to know, thanks! I wasn’t too sure whether there could be a better one.

Miguel Pozo commented

2022-11-15 16:17:16 +01:00

Added subscribers: @Guilherme-Emerich-Setubal, @OmarEmaraDev

Christoph Lendenfeld referenced this issue

2023-02-10 11:56:22 +01:00

Blender LTS: Maintenance Task 3.3 #100749

Sign in to join this conversation.