Grease Pencil: New lines in Multiframe editing appear as Onion skinning overlay #101548

Closed
opened 2022-10-02 12:22:50 +02:00 by Julien Kaspar · 11 comments
Member

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.59

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-09-30 22:40, hash: 206dead860
Worked: (newest version of Blender that worked as expected)

Short description of error
When using Multiframe editing and drawing new lines in Draw Mode, the new lines will falsely be drawn with onion skinning colors.
The new line will have been drawn on all frames, so it should be drawn as its own color when switching to other frames.

gp_bug2.mp4

Exact steps for others to reproduce the error

  • Add a grease pencil object
  • Draw a new line on a bunch of different frames
  • Enable the onion skinning overlay
  • Enable multiframe editing and make sure all keyframes are selected
  • Draw a new line and move the current frame
**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1060/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.59 **Blender Version** Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-09-30 22:40, hash: `206dead860` Worked: (newest version of Blender that worked as expected) **Short description of error** When using Multiframe editing and drawing new lines in Draw Mode, the new lines will falsely be drawn with onion skinning colors. The new line will have been drawn on all frames, so it should be drawn as its own color when switching to other frames. [gp_bug2.mp4](https://archive.blender.org/developer/F13605948/gp_bug2.mp4) **Exact steps for others to reproduce the error** - Add a grease pencil object - Draw a new line on a bunch of different frames - Enable the onion skinning overlay - Enable multiframe editing and make sure all keyframes are selected - Draw a new line and move the current frame
Author
Member

Added subscriber: @JulienKaspar

Added subscriber: @JulienKaspar
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123

Added subscriber: @antoniov

Added subscriber: @antoniov

Can reproduce. The problem looks related to the copy to eval data. The stroke is created but not copied to eval data, so it's consider that the stroke is not in the frame, but really it is.

Maybe, this is related to the last optimization for copying only part of the eval data.

To reproduce:

Open file and draw a line. If you save and reopen works.

SimpleMultiframe.blend

Can reproduce. The problem looks related to the copy to eval data. The stroke is created but not copied to eval data, so it's consider that the stroke is not in the frame, but really it is. Maybe, this is related to the last optimization for copying only part of the eval data. To reproduce: Open file and draw a line. If you save and reopen works. [SimpleMultiframe.blend](https://archive.blender.org/developer/F13609145/SimpleMultiframe.blend)

Added subscriber: @filedescriptor

Added subscriber: @filedescriptor

@filedescriptor Could you take a look of this? I guess the error is located in these lines of gpencil_paint.c:

/* In multi-frame mode, duplicate the stroke in other frames. */
  if (GPENCIL_MULTIEDIT_SESSIONS_ON(p->gpd)) {
    const bool tail = (ts->gpencil_flags & GP_TOOL_FLAG_PAINT_ONBACK);
    BKE_gpencil_stroke_copy_to_keyframes(gpd, gpl, p->gpf, gps, tail);
  }

  gpencil_update_cache(p->gpd);
  BKE_gpencil_tag_full_update(p->gpd, gpl, p->gpf, NULL);

My guess is the function only updates the current gps, but not the strokes created by BKE_gpencil_stroke_copy_to_keyframes

Edit: The problem is the copy is only for the frame, my suggested change is call BKE_gpencil_tag_full_update passing frame as NULL if there is multiframe draw.

@filedescriptor Could you take a look of this? I guess the error is located in these lines of `gpencil_paint.c`: ``` /* In multi-frame mode, duplicate the stroke in other frames. */ if (GPENCIL_MULTIEDIT_SESSIONS_ON(p->gpd)) { const bool tail = (ts->gpencil_flags & GP_TOOL_FLAG_PAINT_ONBACK); BKE_gpencil_stroke_copy_to_keyframes(gpd, gpl, p->gpf, gps, tail); } gpencil_update_cache(p->gpd); BKE_gpencil_tag_full_update(p->gpd, gpl, p->gpf, NULL); ``` My guess is the function only updates the current `gps`, but not the strokes created by `BKE_gpencil_stroke_copy_to_keyframes` Edit: The problem is the copy is only for the frame, my suggested change is call `BKE_gpencil_tag_full_update` passing frame as NULL if there is multiframe draw.
Antonio Vazquez self-assigned this 2022-10-03 10:33:43 +02:00

This issue was referenced by 1bdb5542ff

This issue was referenced by 1bdb5542ff0d13a26fb9f94988cedd679a3172b7

This issue was referenced by 035c237d69

This issue was referenced by 035c237d69d196048cc2b56274aa98b04256f46c

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Member

@antoniov We could also tag frames in BKE_gpencil_stroke_copy_to_keyframes knowing that just tagging the layer can be slower.

@antoniov We could also tag frames in `BKE_gpencil_stroke_copy_to_keyframes` knowing that just tagging the layer can be slower.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#101548
No description provided.