Regression: Geometry Nodes: Crash when deleting Group Output inside a node group. #101642

New Issue

Dalai Felinto · 2022-10-06T12:02:03+02:00

Dalai Felinto commented

2022-10-06 12:02:03 +02:00

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-06 01:49, hash: 68ea6c85ab
Worked: 3.3

Caused by 4130f1e674

Short description of error
Crash when evaluating a node group that has no Node Group Output

Exact steps for others to reproduce the error
nodegroup.blend

Add a node (e.g., Arc), connect to the Output
Make a Node Group with it
Delete its own Node Output

Or open the file and just delete the selected Group Output node. Note that if the nodegroup itself is not evaluated the crash doesn't happen.
You can also reproduce this bug by disconnecting the node group first, deleting its Group Output, and then connecting the node group to the top Group Output.

**Blender Version** Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-06 01:49, hash: `68ea6c85ab` Worked: 3.3 Caused by 4130f1e674 **Short description of error** Crash when evaluating a node group that has no Node Group Output **Exact steps for others to reproduce the error** [nodegroup.blend](https://archive.blender.org/developer/F13622446/nodegroup.blend) 1. Add a node (e.g., Arc), connect to the Output 2. Make a Node Group with it 3. Delete its own Node Output Or open the file and just delete the selected Group Output node. Note that if the nodegroup itself is not evaluated the crash doesn't happen. You can also reproduce this bug by disconnecting the node group first, deleting its Group Output, and then connecting the node group to the top Group Output.

Dalai Felinto commented

2022-10-06 12:02:03 +02:00

Added subscriber: @dfelinto

Dalai Felinto commented

2022-10-06 12:02:26 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-10-06 12:23:58 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-10-06 12:23:58 +02:00

will check/bisect

Philipp Oeser commented

2022-10-06 12:48:42 +02:00

Added subscriber: @JacquesLucke

Philipp Oeser commented

2022-10-06 12:48:42 +02:00

Caused by 4130f1e674
In Debug builds, it also asserts here:

4   _BLI_assert_abort                                                                                                                                                                                                                                                                                                                     BLI_assert.c                    46   0xf3b29a3      
5   blender::fn::lazy_function::Executor::assert_expected_outputs_have_been_computed                                                                                                                                                                                                                                                      lazy_function_graph_executor.cc 740  0xca5c15a      
6   blender::fn::lazy_function::Executor::run_node_task(blender::fn::lazy_function::FunctionNode const&, blender::fn::lazy_function::CurrentTask&)::{lambda(blender::fn::lazy_function::LockedNode&)#2}::operator()(blender::fn::lazy_function::LockedNode&) const                                                                        lazy_function_graph_executor.cc 703  0xca5bce5      
7   blender::FunctionRef<void (blender::fn::lazy_function::LockedNode&)>::callback_fn<blender::fn::lazy_function::Executor::run_node_task(blender::fn::lazy_function::FunctionNode const&, blender::fn::lazy_function::CurrentTask&)::{lambda(blender::fn::lazy_function::LockedNode&)#2}>(long, blender::fn::lazy_function::LockedNode&) BLI_function_ref.hh             94   0xca5fc0c      
8   blender::FunctionRef<void (blender::fn::lazy_function::LockedNode&)>::operator()(blender::fn::lazy_function::LockedNode&) const                                                                                                                                                                                                       BLI_function_ref.hh             131  0xca5ec7d      
9   blender::fn::lazy_function::Executor::with_locked_node(blender::fn::lazy_function::Node const&, blender::fn::lazy_function::NodeState&, blender::fn::lazy_function::CurrentTask&, blender::FunctionRef<void (blender::fn::lazy_function::LockedNode&)>)                                                                               lazy_function_graph_executor.cc 581  0xca5b393      
10  blender::fn::lazy_function::Executor::run_node_task                                                                                                                                                                                                                                                                                   lazy_function_graph_executor.cc 700  0xca5bf0b      
11  blender::fn::lazy_function::Executor::run_task                                                                                                                                                                                                                                                                                        lazy_function_graph_executor.cc 611  0xca5b5a5      
12  blender::fn::lazy_function::Executor::execute                                                                                                                                                                                                                                                                                         lazy_function_graph_executor.cc 315  0xca59ab0      
13  blender::fn::lazy_function::GraphExecutor::execute_impl                                                                                                                                                                                                                                                                               lazy_function_graph_executor.cc 1184 0xca59224      
14  blender::fn::lazy_function::LazyFunction::execute                                                                                                                                                                                                                                                                                     FN_lazy_function.hh             326  0x16e64c5      
15  compute_geometry                                                                                                                                                                                                                                                                                                                      MOD_nodes.cc                    1183 0x16e1750      
16  modifyGeometry                                                                                                                                                                                                                                                                                                                        MOD_nodes.cc                    1305 0x16e1feb      
17  modifyGeometrySet                                                                                                                                                                                                                                                                                                                     MOD_nodes.cc                    1342 0x16e220a      
18  modifier_modify_mesh_and_geometry_set                                                                                                                                                                                                                                                                                                 DerivedMesh.cc                  626  0xdffc74       
19  mesh_calc_modifiers                                                                                                                                                                                                                                                                                                                   DerivedMesh.cc                  972  0xe00baf       
20  mesh_build_data                                                                                                                                                                                                                                                                                                                       DerivedMesh.cc                  1567 0xe02d12       
... <More>

CC @JacquesLucke

Caused by 4130f1e674 In Debug builds, it also asserts here: ``` 4 _BLI_assert_abort BLI_assert.c 46 0xf3b29a3 5 blender::fn::lazy_function::Executor::assert_expected_outputs_have_been_computed lazy_function_graph_executor.cc 740 0xca5c15a 6 blender::fn::lazy_function::Executor::run_node_task(blender::fn::lazy_function::FunctionNode const&, blender::fn::lazy_function::CurrentTask&)::{lambda(blender::fn::lazy_function::LockedNode&)#2}::operator()(blender::fn::lazy_function::LockedNode&) const lazy_function_graph_executor.cc 703 0xca5bce5 7 blender::FunctionRef<void (blender::fn::lazy_function::LockedNode&)>::callback_fn<blender::fn::lazy_function::Executor::run_node_task(blender::fn::lazy_function::FunctionNode const&, blender::fn::lazy_function::CurrentTask&)::{lambda(blender::fn::lazy_function::LockedNode&)#2}>(long, blender::fn::lazy_function::LockedNode&) BLI_function_ref.hh 94 0xca5fc0c 8 blender::FunctionRef<void (blender::fn::lazy_function::LockedNode&)>::operator()(blender::fn::lazy_function::LockedNode&) const BLI_function_ref.hh 131 0xca5ec7d 9 blender::fn::lazy_function::Executor::with_locked_node(blender::fn::lazy_function::Node const&, blender::fn::lazy_function::NodeState&, blender::fn::lazy_function::CurrentTask&, blender::FunctionRef<void (blender::fn::lazy_function::LockedNode&)>) lazy_function_graph_executor.cc 581 0xca5b393 10 blender::fn::lazy_function::Executor::run_node_task lazy_function_graph_executor.cc 700 0xca5bf0b 11 blender::fn::lazy_function::Executor::run_task lazy_function_graph_executor.cc 611 0xca5b5a5 12 blender::fn::lazy_function::Executor::execute lazy_function_graph_executor.cc 315 0xca59ab0 13 blender::fn::lazy_function::GraphExecutor::execute_impl lazy_function_graph_executor.cc 1184 0xca59224 14 blender::fn::lazy_function::LazyFunction::execute FN_lazy_function.hh 326 0x16e64c5 15 compute_geometry MOD_nodes.cc 1183 0x16e1750 16 modifyGeometry MOD_nodes.cc 1305 0x16e1feb 17 modifyGeometrySet MOD_nodes.cc 1342 0x16e220a 18 modifier_modify_mesh_and_geometry_set DerivedMesh.cc 626 0xdffc74 19 mesh_calc_modifiers DerivedMesh.cc 972 0xe00baf 20 mesh_build_data DerivedMesh.cc 1567 0xe02d12 ... <More> ``` CC @JacquesLucke

Philipp Oeser changed title from ~~Geometry Nodes: Crash when deleting Group Output inside a node group.~~ to Regression: Geometry Nodes: Crash when deleting Group Output inside a node group.

2022-10-06 12:48:57 +02:00

blender-admin commented

2022-10-18 16:15:12 +02:00

This issue was referenced by 7abd79398d

This issue was referenced by 7abd79398d712be54935c01f1d2eefb5eaba64a9

Jacques Lucke commented

2022-10-18 16:16:16 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Jacques Lucke closed this issue

2022-10-18 16:16:16 +02:00

Jacques Lucke self-assigned this 2022-10-18 16:16:16 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Geometry Nodes: Crash when deleting Group Output inside a node group. #101642