Regression: Crash in sculpt mode using shift+h #101699

New Issue

Nahuel Belich · 2022-10-08T12:55:01+02:00

Nahuel Belich commented

2022-10-08 12:55:01 +02:00

System Information
Operating system: Linux-5.15.0-48-generic-x86_64-with-glibc2.31 64 Bits
Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.103.01

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-07 22:54, hash: 3d209d1619
Worked: 3.3
Caused by 22c3db72ca

Short description of error
If you try to hide from object mode using shift+h without previously set a face set it crashes.
Crash will not happen with default cube (reads face_sets correctly)

Exact steps for others to reproduce the error

Delete default cube and add new
enter sculpt mode
Press shift+h (same goes for Alt+H but it wont crash if D16199 is applied)
Crash

**System Information** Operating system: Linux-5.15.0-48-generic-x86_64-with-glibc2.31 64 Bits Graphics card: NVIDIA GeForce GTX 1070/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.103.01 **Blender Version** Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-07 22:54, hash: `3d209d1619` Worked: 3.3 Caused by 22c3db72ca **Short description of error** If you try to hide from object mode using shift+h without previously set a face set it crashes. Crash will not happen with default cube (reads `face_sets` correctly) **Exact steps for others to reproduce the error** - Delete default cube and add new - enter sculpt mode - Press shift+h (same goes for Alt+H but it wont crash if [D16199](https://archive.blender.org/developer/D16199) is applied) - Crash

Nahuel Belich commented

2022-10-08 12:55:01 +02:00

Added subscriber: @NahuelBelich

Nahuel Belich commented

2022-10-08 13:03:47 +02:00

never mind found what cause the error, im not sure why it make it crash thoug, but its not a offical add on, ill poke the author in twitter.

Python: Traceback (most recent call last):

File "/home/belich/.config/blender/3.4/scripts/addons/b3dsdf/__init__.py", line 135, in poll
  return context.space_data.node_tree

AttributeError: 'SpaceView3D' object has no attribute 'node_tree' # Error
Preferences saved # Info
bpy.ops.sculpt.sculptmode_toggle() # Operator

blender.crash.txt

never mind found what cause the error, im not sure why it make it crash thoug, but its not a offical add on, ill poke the author in twitter. Python: Traceback (most recent call last): ``` File "/home/belich/.config/blender/3.4/scripts/addons/b3dsdf/__init__.py", line 135, in poll return context.space_data.node_tree ``` AttributeError: 'SpaceView3D' object has no attribute 'node_tree' # Error Preferences saved # Info bpy.ops.sculpt.sculptmode_toggle() # Operator [blender.crash.txt](https://archive.blender.org/developer/F13637326/blender.crash.txt)

Pratik Borhade commented

2022-10-10 10:48:26 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-10-10 10:48:26 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-10-10 10:48:26 +02:00

Thanks for the report. I can confirm the crash. I'll check

Pratik Borhade self-assigned this 2022-10-10 10:59:41 +02:00

Pratik Borhade commented

2022-10-10 11:36:24 +02:00

Added subscriber: @JosephEagar

Pratik Borhade commented

2022-10-10 11:36:24 +02:00

First bad commit: 22c3db72ca
@JosephEagar ^
Crash triggers due to accessing unreadable memory.

First bad commit: 22c3db72ca @JosephEagar ^ Crash triggers due to accessing unreadable memory.

Pratik Borhade changed title from ~~Crash in sculpt mode using shift+h~~ to Regression: Crash in sculpt mode using shift+h

2022-10-10 11:40:16 +02:00

Pratik Borhade removed their assignment 2022-10-10 11:40:16 +02:00

Pratik Borhade commented

2022-10-10 12:06:01 +02:00

easy fix would be: cancel sculpt_face_sets_change_visibility_exec operator when face_sets value is NULL
But it'll break the consistency: In previous versions newly added mesh also has one face set by default, I guess.

easy fix would be: cancel `sculpt_face_sets_change_visibility_exec` operator when `face_sets` value is NULL But it'll break the consistency: In previous versions newly added mesh also has one face set by default, I guess.

Pratik Borhade self-assigned this 2022-10-10 12:08:43 +02:00

Pratik Borhade commented

2022-10-10 12:08:43 +02:00

But it'll break the consistency: In previous versions newly added mesh also has one face set by default, I guess.

Commit responsible for it seems different. I'll open a separate report for that: #101722 (Regression: Missing default face set for primitive meshes)
For this report simple If check is the fix. Submitted the fix: D16206: Fix #101699: Crash on hiding all face sets

> But it'll break the consistency: In previous versions newly added mesh also has one face set by default, I guess. Commit responsible for it seems different. I'll open a separate report for that: #101722 (Regression: Missing default face set for primitive meshes) For this report simple `If check` is the fix. Submitted the fix: [D16206: Fix #101699: Crash on hiding all face sets](https://archive.blender.org/developer/D16206)

TheRedWaxPolice commented

2022-10-11 04:01:04 +02:00

Added subscriber: @TheRedWaxPolice