Regression: Geometry Node: Delete points created from curve will broken radius attribute #101711

Closed
opened 2022-10-09 19:28:20 +02:00 by Iliya Katushenock · 7 comments

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.49

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-08 02:26, hash: f9ab2214ae

Caused by 7536abbe16

Short description of error

image.png

3.4.0 Alpha, branch: master, commit date:

2022-09-15 18:14, hash: d5df23d758 2022-09-18 20:10, hash: ecf3435362 2022-10-08 02:26, hash: f9ab2214ae
image.png image.png image.png
Corrcet Only 0 Other memory

Exact steps for others to reproduce the error

  1. Create some curve primitive node
  2. Convert curve to points
  3. Delete points (use some non always-true input as selection)
    In Spreadsheets editor will see broken radius attribute

broken dele points.blend

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 496.49 **Blender Version** Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-08 02:26, hash: `f9ab2214ae` Caused by 7536abbe16 **Short description of error** ![image.png](https://archive.blender.org/developer/F13644712/image.png) `3.4.0 Alpha, branch: master, commit date:` | 2022-09-15 18:14, hash: `d5df23d758` | 2022-09-18 20:10, hash: `ecf3435362` | 2022-10-08 02:26, hash: `f9ab2214ae` | | -- | -- | -- | | ![image.png](https://archive.blender.org/developer/F13644710/image.png) | ![image.png](https://archive.blender.org/developer/F13644708/image.png) | ![image.png](https://archive.blender.org/developer/F13644705/image.png) | | Corrcet | Only 0 | Other memory | **Exact steps for others to reproduce the error** 1. Create some curve primitive node 2. Convert curve to points 3. Delete points (use some non always-true input as selection) In Spreadsheets editor will see broken radius attribute [broken dele points.blend](https://archive.blender.org/developer/F13644669/broken_dele_points.blend)
Author
Member

Added subscriber: @mod_moder

Added subscriber: @mod_moder
Author
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Author
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Iliya Katushenock changed title from Geometry Node: Delete points created from curve will broken radius attribute to Regression: Geometry Node: Delete points created from curve will broken radius attribute 2022-10-09 19:29:46 +02:00
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Member

Caused by 7536abbe16

commit message says:

There is one behavior change: If the radius attribute doesn't exist,
the node won't set the radius to 1 for the output point cloud anymore.
Instead, the default radius for point clouds will be used.

But following this

/* Move the curve point custom data to the pointcloud, to avoid any copying. */

the CustomData is just CustomData_reset, think this does not mean defaults are written (not sure where these are handled, I see CD_RADIUS is unused)?

Caused by 7536abbe16 commit message says: > There is one behavior change: If the radius attribute doesn't exist, > the node won't set the radius to 1 for the output point cloud anymore. > Instead, the default radius for point clouds will be used. But following this > /* Move the curve point custom data to the pointcloud, to avoid any copying. */ the `CustomData` is just `CustomData_reset`, think this does not mean defaults are written (not sure where these are handled, I see `CD_RADIUS` is unused)?
Hans Goudey self-assigned this 2022-10-10 17:23:03 +02:00

This issue was referenced by 0d25169dc5

This issue was referenced by 0d25169dc5181e2737599582f3009751d84356ca
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#101711
No description provided.