Incorrect call to set_app_id on Wayland #101779

New Issue

Nicolas Fella · 2022-10-12T21:33:01+02:00

Nicolas Fella commented

2022-10-12 21:33:01 +02:00

System Information
Operating system: Fedora 36

Blender Version
Broken: 3.4.0-alpha+master.f0e1089a33f4

When running Blender on Wayland the id reported to xdg-shell via set_app_id is incorrect.

In https://git.blender.org/gitweb/gitweb.cgi/blender.git/blob/HEAD:/intern/ghost/intern/GHOST_WindowWayland.cpp#l647 it is set to the same as the window title.
This results in it being "Blender". However, the id should match the desktop file name, which for the version downloaded from blender.org is "blender" (lowercase). For the version installed from Flathub the correct value would be "org.blender.Blender"

Quoting https://wayland.app/protocols/xdg-shell#xdg_toplevel:request:set_app_id:

As a best practice, it is suggested to select app ID's that match the basename of the application's .desktop file. For example, "org.freedesktop.FooViewer" where the .desktop file is "org.freedesktop.FooViewer.desktop".

This can be confirmed via "WAYLAND_DEBUG=1 ./blender 2>&1 | grep set_app_id", which shows the call to set_app_id with the wrong value.

This causes for example the window icon being wrong in Plasma Wayland, but there are potentially more things broken because of that.

**System Information** Operating system: Fedora 36 **Blender Version** Broken: 3.4.0-alpha+master.f0e1089a33f4 When running Blender on Wayland the id reported to xdg-shell via set_app_id is incorrect. In https://git.blender.org/gitweb/gitweb.cgi/blender.git/blob/HEAD:/intern/ghost/intern/GHOST_WindowWayland.cpp#l647 it is set to the same as the window title. This results in it being "Blender". However, the id should match the desktop file name, which for the version downloaded from blender.org is "blender" (lowercase). For the version installed from Flathub the correct value would be "org.blender.Blender" Quoting https://wayland.app/protocols/xdg-shell#xdg_toplevel:request:set_app_id: > As a best practice, it is suggested to select app ID's that match the basename of the application's .desktop file. For example, "org.freedesktop.FooViewer" where the .desktop file is "org.freedesktop.FooViewer.desktop". This can be confirmed via "WAYLAND_DEBUG=1 ./blender 2>&1 | grep set_app_id", which shows the call to set_app_id with the wrong value. This causes for example the window icon being wrong in Plasma Wayland, but there are potentially more things broken because of that.

Nicolas Fella commented

2022-10-12 21:33:01 +02:00

Added subscriber: @nicolasfella

Omar Emara commented

2022-10-12 22:01:03 +02:00

Added subscribers: @ideasman42, @OmarEmaraDev

Omar Emara commented

2022-10-12 22:01:03 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Omar Emara commented

2022-10-12 22:01:03 +02:00

While not exactly a bug, confirming since this is a best practice that apparently have functional consequences.

Omar Emara commented

2022-10-12 22:04:11 +02:00

@ideasman42 Which project should we tag Wayland/GHOST related reports? I tagged Platform: Linux, but that doesn't seem correct.

@ideasman42 Which project should we tag Wayland/GHOST related reports? I tagged `Platform: Linux`, but that doesn't seem correct.

blender-admin commented

2022-10-13 01:06:22 +02:00

This issue was referenced by 3980af7453

This issue was referenced by 3980af7453bfcf55dbf29a39475af17a6fcf897b

Campbell Barton commented

2022-10-13 01:14:56 +02:00

Changed status from 'Confirmed' to: 'Resolved'

Campbell Barton closed this issue

2022-10-13 01:14:56 +02:00

Campbell Barton self-assigned this 2022-10-13 01:14:56 +02:00

Campbell Barton commented

2022-10-13 01:18:52 +02:00

@OmarEmaraDev tagging Platform: Linux seems correct since there is likely to be increasing adoption of Wayland on Linux.

So I think this is fine unless we get many Wayland issues and triaging team prefer to mark separately to make them more managable.

@OmarEmaraDev tagging `Platform: Linux` seems correct since there is likely to be increasing adoption of Wayland on Linux. So I think this is fine unless we get many Wayland issues and triaging team prefer to mark separately to make them more managable.

Campbell Barton commented

2022-10-14 07:58:19 +02:00

Note that this fix didn't work with the blender builds distributed on blender.org, so now the name follows "blender.desktop".

Anyone packaging Blender will need to follow that convention for the desktop file.

Note that this fix didn't work with the blender builds distributed on blender.org, so now the name follows "blender.desktop". Anyone packaging Blender will need to follow that convention for the desktop file.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Incorrect call to set_app_id on Wayland #101779