Curves sculptmode: sculpting in deformed space breaks when using Duplicate Elements node (followed by Set Position) #101823

Closed
opened 2022-10-14 13:53:17 +02:00 by Philipp Oeser · 9 comments
Member

System Information
Operating system: Linux-5.19.6-200.fc36.x86_64-x86_64-with-glibc2.35 64 Bits
Graphics card: NVIDIA GeForce RTX 3080 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 515.65.01

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-10 00:22, hash: a24f11e0ec
Worked: -

Short description of error
Curves sculptmode: sculpting in deformed space breaks when using Duplicate Elements node (followed by Set Position)

Exact steps for others to reproduce the error
curves_sculptmode_duplicate_elements_crazyspace.blend

  • open .blend
  • try to comb in the "bad" area >> nothing happens
  • try to comb in the "good" area >> combing works

Probably needs something along the lines of 30113e54d2

**System Information** Operating system: Linux-5.19.6-200.fc36.x86_64-x86_64-with-glibc2.35 64 Bits Graphics card: NVIDIA GeForce RTX 3080 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 515.65.01 **Blender Version** Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-10 00:22, hash: `a24f11e0ec` Worked: - **Short description of error** Curves sculptmode: sculpting in deformed space breaks when using Duplicate Elements node (followed by Set Position) **Exact steps for others to reproduce the error** [curves_sculptmode_duplicate_elements_crazyspace.blend](https://archive.blender.org/developer/F13677442/curves_sculptmode_duplicate_elements_crazyspace.blend) - open .blend - try to comb in the "bad" area >> nothing happens - try to comb in the "good" area >> combing works Probably needs something along the lines of 30113e54d2
Author
Member

Added subscriber: @lichtwerk

Added subscriber: @lichtwerk
Philipp Oeser self-assigned this 2022-10-14 13:53:49 +02:00
Author
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Member

I think this is a limitation of the way the deformed positions storage works. The first non-deforming node saves the positions, and they aren't adjusted after that. In general this is fundamental to the way it works-- any future node can't be evaluated on the saved curves edit data with the same results that it has on the curves.
The simple fix in this situation is to just swap the two nodes, that would make it faster anyway.

In the past we talked about letting node group makers set this data directly so they can have more control. That could help here

I think this is a limitation of the way the deformed positions storage works. The first non-deforming node saves the positions, and they aren't adjusted after that. In general this is fundamental to the way it works-- any future node can't be evaluated on the saved curves edit data with the same results that it has on the curves. The simple fix in this situation is to just swap the two nodes, that would make it faster anyway. In the past we talked about letting node group makers set this data directly so they can have more control. That could help here
Author
Member

In #101823#1432536, @HooglyBoogly wrote:
The simple fix in this situation is to just swap the two nodes, that would make it faster anyway.

How would that work?
The Duplicate Elements needs to be before the Set Position (it uses the Duplicate Index as an input for Set Position)

Also just noticed that dropping a Deform Curves on Surface after a Duplicate Elements node will crash blender, will check/report that on Monday

> In #101823#1432536, @HooglyBoogly wrote: > The simple fix in this situation is to just swap the two nodes, that would make it faster anyway. How would that work? The `Duplicate Elements` needs to be before the `Set Position` (it uses the `Duplicate Index` as an input for `Set Position`) Also just noticed that dropping a `Deform Curves on Surface` after a `Duplicate Elements` node will crash blender, will check/report that on Monday
Member

How would that work?

Ah, right, it doesn't. Sorry, didn't have the file open when I wrote that.

>How would that work? Ah, right, it doesn't. Sorry, didn't have the file open when I wrote that.
Member

Added subscriber: @JacquesLucke

Added subscriber: @JacquesLucke
Member

Changed status from 'Confirmed' to: 'Archived'

Changed status from 'Confirmed' to: 'Archived'
Member

This case is indeed not supported currently and might never be automatically. Blender doesn't really know how to interpret the positions set by the Set Position node and how they relate to original curves.

In this specific case one should first offset all curves and only then duplicate elements and add some randomness.

As Hans mentioned already, we could add nodes that allow the user to help Blender in such cases in the future.

This case is indeed not supported currently and might never be automatically. Blender doesn't really know how to interpret the positions set by the Set Position node and how they relate to original curves. In this specific case one should first offset all curves and only then duplicate elements and add some randomness. As Hans mentioned already, we could add nodes that allow the user to help Blender in such cases in the future.
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#101823
No description provided.