Curves editmode: edit points are drawn from the fully evaluated curves #101889

New Issue

Philipp Oeser · 2022-10-18T09:30:18+02:00

Philipp Oeser commented

2022-10-18 09:30:18 +02:00

System Information
Operating system: Linux-5.19.6-200.fc36.x86_64-x86_64-with-glibc2.35 64 Bits
Graphics card: NVIDIA GeForce RTX 3080 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 515.65.01

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-17 00:16, hash: 1d1cade9a9
Worked: -

Short description of error
Curves editmode: edit points are drawn from the fully evaluated curves.
This does not only include deformation, also newly added points (e.g. by subdividing) are drawn.

Even though the transform system is not hooked up to editmode yet, we clearly only want to draw added/evaluated points (if at all) in a way that indicates that these cannot be transformed or interacted with in other ways.
Mesh editmode modifiers will never draw generated additional points and only draw "on cage" (in deformed space) with the option set in the modifier itself.

Greasepencil editmode modifiers will draw generated additional points (but greyed out / not selectable) and forced "on cage" (in deformed space)

NOTE: With the "on cage" behavior [which seems much more intuitive at first] we introduce crazyspace editing (e.g. translations on one axis might end up totally different on the result, also gizmos are drawn in the wrong place) which on the other hand is not intuitive at all if not done right. Crazyspace is an issue for both greasepencil and mesh atm. and might be an issue with curves too (if not done carefully -- not sure yet if mechanisms introduced in D15407 can help here and if so, if they ar general enough to work in all scenarios)

If we decide to drawn in original locations only (the following pic is doing this with D16281 applied), it becomes obvious that we not only need to draw the editpoints, but connecting lines as well.

NOTE: #102966 (Curves editmode: selection drawing not stable / flickering) should probably be fixed first

**System Information** Operating system: Linux-5.19.6-200.fc36.x86_64-x86_64-with-glibc2.35 64 Bits Graphics card: NVIDIA GeForce RTX 3080 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 515.65.01 **Blender Version** Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-17 00:16, hash: `1d1cade9a9` Worked: - **Short description of error** Curves editmode: edit points are drawn from the fully evaluated curves. This does not only include deformation, also newly added points (e.g. by subdividing) are drawn. ![image.png](https://archive.blender.org/developer/F13702503/image.png) Even though the transform system is not hooked up to editmode yet, we clearly only want to draw added/evaluated points (if at all) in a way that indicates that these cannot be transformed or interacted with in other ways. Mesh editmode modifiers will never draw generated additional points and only draw "on cage" (in deformed space) with the option set in the modifier itself. Greasepencil editmode modifiers will draw generated additional points (but greyed out / not selectable) and forced "on cage" (in deformed space) ![image.png](https://archive.blender.org/developer/F13702560/image.png) NOTE: With the "on cage" behavior [which seems much more intuitive at first] we introduce crazyspace editing (e.g. translations on one axis might end up totally different on the result, also gizmos are drawn in the wrong place) which on the other hand is not intuitive at all if not done right. Crazyspace is an issue for both greasepencil and mesh atm. and might be an issue with curves too (if not done carefully -- not sure yet if mechanisms introduced in [D15407](https://archive.blender.org/developer/D15407) can help here and if so, if they ar general enough to work in all scenarios) If we decide to drawn in original locations only (the following pic is doing this with [D16281](https://archive.blender.org/developer/D16281) applied), it becomes obvious that we not only need to draw the editpoints, but connecting lines as well. ![image.png](https://archive.blender.org/developer/F13702581/image.png) NOTE: #102966 (Curves editmode: selection drawing not stable / flickering) should probably be fixed first

Philipp Oeser commented

2022-10-18 09:30:18 +02:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-10-18 09:31:28 +02:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser self-assigned this 2022-10-18 09:31:28 +02:00

Philipp Oeser commented

2022-10-18 09:31:28 +02:00

Added subscribers: @HooglyBoogly, @JacquesLucke, @dfelinto

Philipp Oeser commented

2022-10-18 09:31:28 +02:00

CC @HooglyBoogly
CC @JacquesLucke
CC @dfelinto

CC @HooglyBoogly CC @JacquesLucke CC @dfelinto

Hans Goudey commented

2022-10-19 00:24:50 +02:00

We discussed this in the module meeting today and agreed that it's best to not draw the evaluated points, and just draw the curves. Otherwise the points end up being noise and get in the way.

I think it would be great to support crazyspace editing for curves edit mode. I'd hope the solution wouldn't be too different from what was necessary for sculpt mode.
I'm not quite sure at what point original indices will be necessary-- that might be another larger change in this area (could be totally unrelated to this for now though).

We discussed this in the [module meeting ](https://devtalk.blender.org/t/2022-10-18-geometry-nodes-sub-module-meeting/26071) today and agreed that it's best to not draw the evaluated points, and just draw the curves. Otherwise the points end up being noise and get in the way. I think it would be great to support crazyspace editing for curves edit mode. I'd hope the solution wouldn't be too different from what was necessary for sculpt mode. I'm not quite sure at what point original indices will be necessary-- that might be another larger change in this area (could be totally unrelated to this for now though).

Paul Larson commented

2022-10-19 19:14:10 +02:00

Added subscriber: @GeorgiaPacific

blender-admin commented

2022-12-06 14:49:44 +01:00

This issue was referenced by e5f139e99d

This issue was referenced by e5f139e99d1a89988c5d3383989ac4d2b308ac1f

Philipp Oeser commented

2022-12-15 08:45:43 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Philipp Oeser closed this issue

2022-12-15 08:45:43 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Curves editmode: edit points are drawn from the fully evaluated curves #101889