NLA Actions Stash remove doesn't work on overriden linked data #101930

Closed
opened 2022-10-19 13:59:56 +02:00 by Efim Petelin · 11 comments

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 522.30

Blender Version
Broken: version: 3.3.1, branch: master, commit date: 2022-10-04 18:35, hash: b292cfe5a9
Worked: (newest version of Blender that worked as expected)

Short description of error
There is no obvious way to remove Action Stash track in NLA Editor for linked armature/object.

Exact steps for others to reproduce the error

  • Download attached files and open ActionStash_on_linked_data.blend or
    • Open a new Blender instance
    • Optionally delete all objects
    • Link the objects from to_be_linked.blend
    • create library override on the Armature to be able animate it.
    • Go to Animation workspace
    • Animate a bone (rotation in 2 frames is enough)
    • Change the Dope Sheet mode to Action Editor
    • press the "Stash" button
    • Go to Nonlinear Animation editor
  • Try deleting the [Action Stash]
    You cannot delete this track or stripe in it with conventional way.
    Only with python:
  D.objects['My_Rig'].animation_data.nla_tracks[0].name
  '[Action Stash]'
  D.objects['My_Rig'].animation_data.nla_tracks.remove(D.objects['My_Rig'].animation_data.nla_tracks[0])

Example files here:
to_be_linked.blend

ActionStash_on_linked_data.blend

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3080/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 522.30 **Blender Version** Broken: version: 3.3.1, branch: master, commit date: 2022-10-04 18:35, hash: `b292cfe5a9` Worked: (newest version of Blender that worked as expected) **Short description of error** There is no obvious way to remove Action Stash track in NLA Editor for linked armature/object. **Exact steps for others to reproduce the error** - Download attached files and open `ActionStash_on_linked_data.blend` or - Open a new Blender instance - Optionally delete all objects - Link the objects from `to_be_linked.blend` - create library override on the `Armature` to be able animate it. - Go to `Animation` workspace - Animate a bone (rotation in 2 frames is enough) - Change the `Dope Sheet` mode to `Action Editor` - press the "Stash" button - Go to `Nonlinear Animation` editor - Try deleting the `[Action Stash]` You cannot delete this track or stripe in it with conventional way. Only with python: ``` D.objects['My_Rig'].animation_data.nla_tracks[0].name '[Action Stash]' ``` ``` D.objects['My_Rig'].animation_data.nla_tracks.remove(D.objects['My_Rig'].animation_data.nla_tracks[0]) ``` Example files here: [to_be_linked.blend](https://archive.blender.org/developer/F13718527/to_be_linked.blend) [ActionStash_on_linked_data.blend](https://archive.blender.org/developer/F13718526/ActionStash_on_linked_data.blend)
Author

Added subscriber: @efimpetelin

Added subscriber: @efimpetelin
Contributor

Added subscriber: @scurest

Added subscriber: @scurest
Contributor

Click on the track in the NLA editor and pick Edit > Delete Track.

Click on the track in the NLA editor and pick Edit > Delete Track.
Author

In #101930#1434462, @scurest wrote:
Click on the track in the NLA editor and pick Edit > Delete Track.

My bad: it doesn't work for linked armatures (and objects may be), only with python console.

> In #101930#1434462, @scurest wrote: > Click on the track in the NLA editor and pick Edit > Delete Track. My bad: it doesn't work for linked armatures (and objects may be), only with python console.
Contributor

Can you update the exact steps then?

Can you update the exact steps then?
Efim Petelin changed title from NLA Actions Stash remove doesn't work to NLA Actions Stash remove doesn't work on overriden linked data 2022-10-19 20:41:07 +02:00

Added subscribers: @mont29, @mano-wii

Added subscribers: @mont29, @mano-wii

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'

I can confirm the problem.
The NLA_OT_tracks_delete operator ignores the track if BKE_nlatrack_is_nonlocal_in_liboverride(ale->id, nlt).

This code was added in c0bd240ad0 (cc @mont29)

I can confirm the problem. The `NLA_OT_tracks_delete` operator ignores the track if `BKE_nlatrack_is_nonlocal_in_liboverride(ale->id, nlt)`. This code was added in c0bd240ad0 (cc @mont29)

This issue was referenced by 9f56021975

This issue was referenced by 9f560219751240cc15a8de0b2e485e1538fee642

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Bastien Montagne self-assigned this 2022-10-22 17:25:46 +02:00

Note that the fix cannot address the issue with existing strips, the required data was completely erased by the stashing code... New stashes will behave as expected though.

Note that the fix cannot address the issue with existing strips, the required data was completely erased by the stashing code... New stashes will behave as expected though.
Bastien Montagne added this to the Core project 2023-02-09 15:43:11 +01:00
Bastien Montagne removed this from the Core project 2023-02-09 18:19:07 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#101930
No description provided.