GN small color pick bug #102042

New Issue

Alexey · 2022-10-25T10:52:20+02:00

Alexey commented

2022-10-25 10:52:20 +02:00

System Information
Operating system: Windows-10-10.0.19044-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 522.30

Blender Version
Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-14 22:00, hash: bc06fcca47
Worked: (newest version of Blender that worked as expected)

Short description of error
2022-10-25 11-49-41.m4v

Exact steps for others to reproduce the error
not required

**System Information** Operating system: Windows-10-10.0.19044-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 522.30 **Blender Version** Broken: version: 3.4.0 Alpha, branch: master, commit date: 2022-10-14 22:00, hash: `bc06fcca47` Worked: (newest version of Blender that worked as expected) **Short description of error** [2022-10-25 11-49-41.m4v](https://archive.blender.org/developer/F13764021/2022-10-25_11-49-41.m4v) **Exact steps for others to reproduce the error** not required

Alexey commented

2022-10-25 10:52:20 +02:00

Added subscriber: @pseudoua

Iliya Katushenock commented

2022-10-25 10:58:12 +02:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2022-10-25 10:58:12 +02:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Iliya Katushenock commented

2022-10-25 10:58:12 +02:00

In fact I see that even copying the color of a socket on the same node makes different colors. Not sure if that's how it's intended.
Despite the transparency, it was the same in 2.78

In fact I see that even copying the color of a socket on the same node makes different colors. Not sure if that's how it's intended. Despite the transparency, it was the same in 2.78

Iliya Katushenock commented

2022-10-25 11:02:43 +02:00

And I also checked. It looks like the only problem is how the nodes use color. As the color in the palette, and in other parts of the blender, everything is correct.

Edward commented

2022-10-25 11:04:05 +02:00

Added subscriber: @edward88

Edward commented

2022-10-25 11:04:05 +02:00

This is the same issue as in #99603 i think, or at least might be related

Iliya Katushenock commented

2022-10-25 11:08:43 +02:00

I tested this on a socket which is not transparent. And also, the color in the palette is similar. So yes, there may be a problem with transparency. But changing the background color does not affect the hue of the node. Which is strange to say the least.

Iliya Katushenock commented

2022-10-25 11:10:40 +02:00

Yes. It looks like this is one problem. The only difference is that here and copying the color gives a broken color.

Edward commented

2022-10-25 11:16:12 +02:00

I've noticed that pure white does not get darker
In fact no rgb channel does if it's at it's max value

I've noticed that pure white does not get darker In fact no rgb channel does if it's at it's max value

Iliya Katushenock commented

2022-10-25 11:18:39 +02:00

In that report, the problem is darkening. Whether the white darkens is a detail that will help identify the problem. But this report still copies their information, only adding that the color is just as incorrect when copying as it is when drawing.

Edward commented

2022-10-25 11:27:55 +02:00

@mod_moder yes this task is a duplicate, my comment was just an additional confirmation that this is indeed a real bug

Pratik Borhade commented

2022-10-25 11:29:14 +02:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-10-25 11:29:14 +02:00

I don't think both are similar. Here, color picked by eye-dropper is affected by some factor (check value in N-panel)
While #99603 describes differences between actual node color and the color shown in the panel
This result is from the basic test. I have not checked this yet from code side.

I don't think both are similar. Here, color picked by eye-dropper is affected by some factor (check value in N-panel) While #99603 describes differences between actual node color and the color shown in the panel This result is from the basic test. I have not checked this yet from code side.

Iliya Katushenock commented

2022-10-25 11:31:25 +02:00

So far I see the problem only in display and copy (from display)
2022-10-25 12-30-37.mp4

So far I see the problem only in display and copy (from display) [2022-10-25 12-30-37.mp4](https://archive.blender.org/developer/F13764398/2022-10-25_12-30-37.mp4)

Edward commented

2022-10-25 11:34:39 +02:00

@PratikPB2123 My assumption was that the color picker works correctly, it just picks up the darker color

Philipp Oeser commented

2022-10-25 12:03:04 +02:00

Added subscriber: @lichtwerk

Philipp Oeser self-assigned this 2022-10-25 12:03:04 +02:00

Philipp Oeser commented

2022-10-25 12:03:04 +02:00

Think these just need to be colormanaged, so PROP_COLOR_GAMMA

Think these just need to be colormanaged, so `PROP_COLOR_GAMMA`

Pratik Borhade commented

2022-10-25 12:07:05 +02:00

What I found is, color picker picks the correct color but the value later changes at the time of srgb -> linear rgb conversion.
https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/eyedroppers/eyedropper_color.c$361

if (win) {
    /* Fallback to simple opengl picker. */
    WM_window_pixel_sample_read(wm, win, mval, r_col);
    IMB_colormanagement_display_to_scene_linear_v3(r_col, display);
  }

Findings might be wrong

What I found is, color picker picks the correct color but the value later changes at the time of srgb -> linear rgb conversion. https://developer.blender.org/diffusion/B/browse/master/source/blender/editors/interface/eyedroppers/eyedropper_color.c$361 ``` if (win) { /* Fallback to simple opengl picker. */ WM_window_pixel_sample_read(wm, win, mval, r_col); IMB_colormanagement_display_to_scene_linear_v3(r_col, display); } ``` Findings might be wrong

Philipp Oeser commented

2022-10-25 12:09:12 +02:00

This is indeed the same as #99603, will merge reports

Philipp Oeser commented

2022-10-25 12:09:23 +02:00

Closed as duplicate of #99603

Philipp Oeser closed this issue

2022-10-25 12:09:23 +02:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

GN small color pick bug #102042