Regression: Entering editmode will invalidate the driver associated with that mesh #102221

New Issue

Jun Takahashi · 2022-11-02T08:04:40+01:00

Jun Takahashi commented

2022-11-02 08:04:40 +01:00

System Information
Operating system: Windows-10-10.0.19043-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.59

Blender Version
Broken: version: 3.3.1, branch: master, commit date: 2022-10-04 18:35, hash: b292cfe5a9
Broken: 3.1.0
Worked: 3.0.1

Apparently caused by 0f89bcdbeb

NOTE: lite builds are not affected for some reason

Short description of error
Entering editmode will invalidate the driver associated with that mesh

3278f437dfe536cd3d9dba2cc21e9bcf.mp4

Exact steps for others to reproduce the error
Test.blend

open .blend
select the cube
(change the value of the Key 1 shapekey to something like 0.5)
toggle between editmode and objectmode until the Plane uses its driver (not deformed anymore)
Please check attached video and blend file

**System Information** Operating system: Windows-10-10.0.19043-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.59 **Blender Version** Broken: version: 3.3.1, branch: master, commit date: 2022-10-04 18:35, hash: `b292cfe5a9` Broken: 3.1.0 Worked: 3.0.1 Apparently caused by 0f89bcdbeb NOTE: lite builds are not affected for some reason **Short description of error** Entering editmode will invalidate the driver associated with that mesh [3278f437dfe536cd3d9dba2cc21e9bcf.mp4](https://archive.blender.org/developer/F13839088/3278f437dfe536cd3d9dba2cc21e9bcf.mp4) **Exact steps for others to reproduce the error** [Test.blend](https://archive.blender.org/developer/F13839090/Test.blend) - open .blend - select the cube - (change the value of the Key 1 shapekey to something like 0.5) - toggle between editmode and objectmode until the Plane uses its driver (not deformed anymore) Please check attached video and blend file

Jun Takahashi commented

2022-11-02 08:04:40 +01:00

Added subscriber: @Jun-Takahashi

Philipp Oeser commented

2022-11-02 10:12:27 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2022-11-02 10:12:27 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2022-11-02 10:12:27 +01:00

Can confirm, will check

Philipp Oeser commented

2022-11-02 12:17:12 +01:00

Added subscriber: @Sergey

Philipp Oeser commented

2022-11-02 12:17:12 +01:00

Apparently caused by 0f89bcdbeb

NOTE: lite builds are not affected

@Sergey: does this ring a bell?

Apparently caused by 0f89bcdbeb NOTE: lite builds are not affected @Sergey: does this ring a bell?

Philipp Oeser changed title from ~~Editing a vertex will invalidate the driver associated with that mesh~~ to Regression: Entering editmode will invalidate the driver associated with that mesh

2022-11-02 12:22:58 +01:00

Sergey Sharybin commented

2022-11-02 15:41:07 +01:00

Doesn't really ring a bell. An investigation is needed.

Sergey Sharybin commented

2022-11-02 17:25:20 +01:00

I gave it some investigation.

It seems that we need to do similar to D7785 thing in the editbmesh_build_data(): P3284: (An Untitled Masterwork)

diff --git a/source/blender/blenkernel/intern/DerivedMesh.cc b/source/blender/blenkernel/intern/DerivedMesh.cc
index 97ff45e93ce..bfdfc447baf 100644
--- a/source/blender/blenkernel/intern/DerivedMesh.cc
+++ b/source/blender/blenkernel/intern/DerivedMesh.cc
@@ -1648,6 +1648,12 @@ static void editbmesh_build_data(struct Depsgraph *depsgraph,
   const bool is_mesh_eval_owned = (me_final != mesh->runtime->mesh_eval);
   BKE_object_eval_assign_data(obedit, &me_final->id, is_mesh_eval_owned);

+  /* Make sure that drivers can target shapekey properties.
+   * Note that this causes a potential inconsistency, as the shapekey may have a
+   * different topology than the evaluated mesh. */
+  BLI_assert(mesh->key == nullptr || DEG_is_evaluated_id(&mesh->key->id));
+  me_final->key = mesh->key;
+
   obedit->runtime.editmesh_eval_cage = me_cage;

   obedit->runtime.geometry_set_eval = non_mesh_components;

Did not have time to give it really good test yet though.

P.S. There is another issue i've noticed with the file. Toggling edit mode, or even sliding the key value leads to memory leak of bAnimListElem.

I gave it some investigation. It seems that we need to do similar to [D7785](https://archive.blender.org/developer/D7785) thing in the `editbmesh_build_data()`: [P3284: (An Untitled Masterwork)](https://archive.blender.org/developer/P3284.txt) ``` diff --git a/source/blender/blenkernel/intern/DerivedMesh.cc b/source/blender/blenkernel/intern/DerivedMesh.cc index 97ff45e93ce..bfdfc447baf 100644 --- a/source/blender/blenkernel/intern/DerivedMesh.cc +++ b/source/blender/blenkernel/intern/DerivedMesh.cc @@ -1648,6 +1648,12 @@ static void editbmesh_build_data(struct Depsgraph *depsgraph, const bool is_mesh_eval_owned = (me_final != mesh->runtime->mesh_eval); BKE_object_eval_assign_data(obedit, &me_final->id, is_mesh_eval_owned); + /* Make sure that drivers can target shapekey properties. + * Note that this causes a potential inconsistency, as the shapekey may have a + * different topology than the evaluated mesh. */ + BLI_assert(mesh->key == nullptr || DEG_is_evaluated_id(&mesh->key->id)); + me_final->key = mesh->key; + obedit->runtime.editmesh_eval_cage = me_cage; obedit->runtime.geometry_set_eval = non_mesh_components; ``` Did not have time to give it really good test yet though. P.S. There is another issue i've noticed with the file. Toggling edit mode, or even sliding the key value leads to memory leak of `bAnimListElem`.

Sergey Sharybin self-assigned this 2022-11-03 15:45:04 +01:00

blender-admin commented

2022-11-03 15:48:54 +01:00

This issue was referenced by 2c0c431399

This issue was referenced by 2c0c43139962ee43db7235d39db22ec77d3349f3

Sergey Sharybin commented

2022-11-03 16:52:55 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Sergey Sharybin closed this issue

2022-11-03 16:52:55 +01:00

Bastien Montagne added this to the Core project 2023-02-09 15:43:10 +01:00

Bastien Montagne removed this from the Core project 2023-02-09 18:19:07 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Entering editmode will invalidate the driver associated with that mesh #102221