GHOST: Wayland: buildtime shader compilation option with Libdecor failling #102306

New Issue

Clément Foucault · 2022-11-06T13:28:03+01:00

Clément Foucault commented

2022-11-06 13:28:03 +01:00

System: 5.15.76-1-MANJARO Linux

When using the cmake option WITH_GPU_BUILDTIME_SHADER_COMPILATION, the executable for checking shader compilation (bin/shader_builder) fails to exit properly and lead to incomplete blender compilation. It seems to be a problem with LibDecor unloading.

Terminal output when built with asan.

ndof: spacenavd not found
Shader Test compilation result: 482 / 482 passed
AddressSanitizer:DEADLYSIGNAL
=================================================================
==133204==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000018 (pc 0x7ffff5e0d58d bp 0x60e0000006b0 sp 0x7fffffffde70 T0)
==133204==The signal is caused by a READ memory access.
==133204==Hint: address points to the zero page.
    - 0 0x7ffff5e0d58d in wl_proxy_destroy (/usr/lib/../lib/libwayland-client.so.0+0x858d)
    - 1 0x7ffff53a7649  (/usr/lib/libdecor/plugins-1/libdecor-cairo.so+0x4649)
    - 2 0x7ffff53d16a3 in libdecor_unref (/usr/lib/../lib/libdecor-0.so.0+0x56a3)
    - 3 0x9f7d9f in gwl_libdecor_system_destroy /mnt/data/Blender/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:564
    - 4 0x9f8e48 in gwl_display_destroy /mnt/data/Blender/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:856
    - 5 0xa2f677 in GHOST_SystemWayland::~GHOST_SystemWayland() /mnt/data/Blender/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:5073
    - 6 0xa2f795 in GHOST_SystemWayland::~GHOST_SystemWayland() /mnt/data/Blender/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:5074
    - 7 0x93a82b in GHOST_ISystem::disposeSystem() /mnt/data/Blender/blender/intern/ghost/intern/GHOST_ISystem.cpp:185
    - 8 0x924d46 in GHOST_DisposeSystem /mnt/data/Blender/blender/intern/ghost/intern/GHOST_C-api.cpp:52
    - 9 0x42384c in blender::gpu::shader_builder::ShaderBuilder::exit() /mnt/data/Blender/blender/source/blender/gpu/intern/gpu_shader_builder.cc:77
    - 10 0x423d7a in main /mnt/data/Blender/blender/source/blender/gpu/intern/gpu_shader_builder.cc:117
    - 11 0x7ffff73b828f  (/usr/lib/libc.so.6+0x2328f)
    - 12 0x7ffff73b8349 in __libc_start_main (/usr/lib/libc.so.6+0x23349)
    - 13 0x423194 in _start ../sysdeps/x86_64/start.S:115

AddressSanitizer can not provide additional info.
SUMMARY: AddressSanitizer: SEGV (/usr/lib/../lib/libwayland-client.so.0+0x858d) in wl_proxy_destroy
==133204==ABORTING

Steps to reproduce:

Enable WITH_GPU_BUILDTIME_SHADER_COMPILATION option.
Make sure you are building with wayland and libdecor enabled.
Try building blender

I am unsure if this is something on our side because WITH_GPU_BUILDTIME_SHADER_COMPILATION is quite special as it does not draw anything.
Note that this might also apply to draw manager unit tests but this was not tested.

System: 5.15.76-1-MANJARO Linux When using the cmake option `WITH_GPU_BUILDTIME_SHADER_COMPILATION`, the executable for checking shader compilation (`bin/shader_builder`) fails to exit properly and lead to incomplete blender compilation. It seems to be a problem with LibDecor unloading. Terminal output when built with asan. ``` ndof: spacenavd not found Shader Test compilation result: 482 / 482 passed AddressSanitizer:DEADLYSIGNAL ================================================================= ==133204==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000018 (pc 0x7ffff5e0d58d bp 0x60e0000006b0 sp 0x7fffffffde70 T0) ==133204==The signal is caused by a READ memory access. ==133204==Hint: address points to the zero page. - 0 0x7ffff5e0d58d in wl_proxy_destroy (/usr/lib/../lib/libwayland-client.so.0+0x858d) - 1 0x7ffff53a7649 (/usr/lib/libdecor/plugins-1/libdecor-cairo.so+0x4649) - 2 0x7ffff53d16a3 in libdecor_unref (/usr/lib/../lib/libdecor-0.so.0+0x56a3) - 3 0x9f7d9f in gwl_libdecor_system_destroy /mnt/data/Blender/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:564 - 4 0x9f8e48 in gwl_display_destroy /mnt/data/Blender/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:856 - 5 0xa2f677 in GHOST_SystemWayland::~GHOST_SystemWayland() /mnt/data/Blender/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:5073 - 6 0xa2f795 in GHOST_SystemWayland::~GHOST_SystemWayland() /mnt/data/Blender/blender/intern/ghost/intern/GHOST_SystemWayland.cpp:5074 - 7 0x93a82b in GHOST_ISystem::disposeSystem() /mnt/data/Blender/blender/intern/ghost/intern/GHOST_ISystem.cpp:185 - 8 0x924d46 in GHOST_DisposeSystem /mnt/data/Blender/blender/intern/ghost/intern/GHOST_C-api.cpp:52 - 9 0x42384c in blender::gpu::shader_builder::ShaderBuilder::exit() /mnt/data/Blender/blender/source/blender/gpu/intern/gpu_shader_builder.cc:77 - 10 0x423d7a in main /mnt/data/Blender/blender/source/blender/gpu/intern/gpu_shader_builder.cc:117 - 11 0x7ffff73b828f (/usr/lib/libc.so.6+0x2328f) - 12 0x7ffff73b8349 in __libc_start_main (/usr/lib/libc.so.6+0x23349) - 13 0x423194 in _start ../sysdeps/x86_64/start.S:115 AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV (/usr/lib/../lib/libwayland-client.so.0+0x858d) in wl_proxy_destroy ==133204==ABORTING ``` Steps to reproduce: - Enable `WITH_GPU_BUILDTIME_SHADER_COMPILATION` option. - Make sure you are building with wayland and libdecor enabled. - Try building blender I am unsure if this is something on our side because `WITH_GPU_BUILDTIME_SHADER_COMPILATION` is quite special as it does not draw anything. Note that this might also apply to draw manager unit tests but this was not tested.

Clément Foucault commented

2022-11-06 13:28:03 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Clément Foucault commented

2022-11-06 13:28:03 +01:00

Added subscriber: @fclem

Clément Foucault changed title from ~~GHOST: Wayland: buildtime shader compilation option with Libdecor~~ to GHOST: Wayland: buildtime shader compilation option with Libdecor failling

2022-11-06 13:30:18 +01:00

Campbell Barton self-assigned this 2022-11-08 10:41:23 +01:00

Campbell Barton commented

2022-11-08 11:10:15 +01:00

@fclem using GHOST_CreateSystemBackground()avoids using libdecor and resolves the issue in my tests, any problems with this patch P3294 ?

@fclem using `GHOST_CreateSystemBackground()`avoids using libdecor and resolves the issue in my tests, any problems with this patch [P3294](https://archive.blender.org/developer/P3294.txt) ?

Clément Foucault commented

2022-11-08 11:33:38 +01:00

@ideasman42 yes it solves the issue!