Regression: GPencil Line Art modifier creates extra (offset) strokes on collection instances #102503
Closed
opened 2022-11-14 19:42:10 +01:00 by Clément Busschaert
·
30 comments
No Branch/Tag Specified
main
blender-v3.3-release
blender-v3.6-release
asset-browser-frontend-split
universal-scene-description
temp-sculpt-dyntopo
brush-assets-project
asset-shelf
anim/armature-drawing-refactor-3
temp-sculpt-dyntopo-hive-alloc
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-projects-basics
blender-v2.93-release
temp-sculpt-attr-api
realtime-clock
sculpt-dev
gpencil-next
bevelv2
microfacet_hair
xr-dev
principled-v2
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels
This issue affects/is about backward or forward compatibility
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
Apply labels
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
This issue affects/is about backward or forward compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest: Wayland
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Set milestone
Clear milestone
No items
No Milestone
Projects
Set Project
Clear projects
No project
Assignees
Assign users
Clear assignees
No Assignees
7 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#102503
Reference in New Issue
There is no content yet.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?
System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 2080 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 522.30
Blender Version
Broken: version: 3.0.0, 3.5
Worked: version: 2.93.6
Caused by
d1e0059eac
Short description of error
A grease pencil lineart object in an instance of a collection that is in the same scene and contains the modifier's target will show extraneous lines corresponding to the projections of the instanced collection.
Exact steps for others to reproduce the error
From the default startup:
First 5 steps included in file
#102503.blend
Here is a screenshot of what I see:

Added subscriber: @SmugRainbowPony
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscriber: @ChengduLittleA
Added subscriber: @PratikPB2123
Grease Pencil Lineart modifier creates extra strokes on collection instancesto Regression: GPencil Line Art modifier creates extra strokes on collection instancesAdded subscriber: @lichtwerk
Changed status from 'Confirmed' to: 'Needs User Info'
Just to make this report somewhat complete:
Cannot repro, or better: I can repro the same bug in 2.93
@SmugRainbowPony : what makes you think it was working there?
@lichtwerk , neither I can repro in 2.93LTS. So I kept "working version" as it is in description :)
Could you check with following file?
#102503.blend
Initially when testing, I would go through the steps and see if I got extra strokes.
I opened 2.93.6 and tested again.

Opening the report file I provided with 2.93.6 does give extra strokes
but when I go through the steps in a new 2.93.6 file, the problem doesn't appear

@lichtwerk did you go through the steps or open the file?
Apparently my provided file isn't test-reliable, though, so it should be worth deleting it from the report.
That file has the
Source Type
set toObject
.If you set it to
Collection
and chooseCollection 2
and do the rest of the steps, then yes, I get duplicate lineart as reported here in 2.93@PratikPB2123 : you changed the report description to be obect instancing, but the title still says collection instancing.
But I can confirm THAT behavior was working in 2.93 and not master, so you just found another bug :)
btw. I would recommend setting the collection in the lineart modifier to TARGET and not ASSET in the original file (but that doesnt resolve the issue either).
Can indeed reproduce in 2.93 if I do so. But "Object" was mentioned as the source type for the modifier in the original report.
Maybe we can unify both the issues in this single report :)
Report title and description still suggests to create instance of a collection, no?
So there are two issues here, then?
am I correct?
Should I create another ticket for the collection version?
I would actually prefer to have two separate reports (reason being we can call one a regression, the other one not)
Changed status from 'Needs User Info' to: 'Confirmed'
Opened new report: #102649 (Instancing collection of LineArt with collection source creates extra strokes)
Added subscriber: @ZedDB
Caused by
d1e0059eac
CC @ChengduLittleA
CC @ZedDB
Regression: GPencil Line Art modifier creates extra strokes on collection instancesto Regression: GPencil Line Art modifier creates extra (offset) strokes on collection instancesIt's really weird. I shall take a look. From the look of it it's because line art recursively loaded linked collections. I'll see how to prevent it
I can confirm that this function never worked as one would assume. However... If you move the grease pencil object outside the Collection 2, there will be no ghosting, suggesting that it's not line art itself loading stuff twice, but the GP object being actually instanced... I tend to keep the the current logic as-is because it's doing what it supposed to do, and line art can't really control whether the line art object itself should be instanced (nor does it have any way to tell if itself is being instanced), so my suggestion is simply not putting line art inside any of the instanced collection.
I'm confused with "it's doing what it's supposed to do"
The lineart modifier is told to outline a specific object, not a collection, or several objects, just the one.
It should, when instanced with that object, behave as a copy after evaluation.
See these screenshots of 2.93:


Screenshot 1 is the ghosting situation we've been talking about, and doesn't ghost at all.
Screenshot 2 has been provided to further discuss "what I expect from instanced lineart".
It shows that the instance is obstructing the original cube to the camera, therefore the lineart doesn't draw some lines, and those are reflecting in the instance.
While unwanted in most cases, this is what I expect from an instanced lineart.
The repeating of the instances in the lineart doesn't strike me as "what it is supposed to do", because the instances are not part of the target, even when instanced.
What I see from all the ghosting screenshots is that the original GP object gets fed the instanced object as a source for the lineart modifier, thus it appearing as well on the instanced GP lineart.
Now things would be different if the manual and the UI were clearer about the nature of the lineart object's source type. "Object" sounds like a single object to me. But if it is meant to include instances of said objects, then yes it's doing what it's supposed to do, it just was never clear to the user that it was supposed to do this.
I am noting now that the lineart modifier has a setting checkbox to include or exclude instanced objects in the computation. When turned off, the ghosting doesn't appear, while the instanced lineart stays.
This makes sense. I think the manual (and maybe the UI) should be clearer about what having "object source type" and "instanced objects" together means.
I personally would expect the "Object" source type to mean a single object, not all of its instances, and the "instanced objects" setting to have meaning only when targeting several objects with, say, the scene or collection source types.
I'd like to know what others think about this.
At any rate, the behaviour changed after 2.93, and if it's not a regression, then it's a change of specs that hasn't been made clear in the UI and manual.
Added subscribers: @mendio, @antoniov
What I see from all the ghosting screenshots is that the original GP object gets fed the instanced object as a source for the lineart modifier, thus it appearing as well on the instanced GP lineart.
Ahh I see. Yeah I can confirm the behaviour is like in your screenshot when object is selected as source. The way line art works now does imply that instanced object would be selected together with the original one. I believe the change from 2.93 is we introduced a new object loading method for line art and it behaves this way to make sure that child particle (instanced object) being selected by the source object, rather than with the parent for better control when there's a lot of particles in the scene. This behaviour change in collection instance+object source selection is likely the by-product of this.
Yes, that option is also used to quickly toggle instances (original intention is for particles) so it won't take too long to calculate when you adjust parameters.
I agree... I need to think of a better way to reflect this in the manual and the UI. The current "object source" logic does allow finer controls over particles, but it made it weird when it's from collection instanced objects rather than particles. I need to check if code-wise line art could distinguish these two types of scenarios when loading objects. If not then we might need to come up with something different at least on the interface.
Thanks for the feedback. Let's see if GP guys have some more input on this.
@antoniov @mendio @ZedDB
I haven't looked at the code, but I think it probably should be possible to determine what cube should be used as the render engine does render the cube correctly?
It feels a bit weird otherwise that the workbench render engine can get the correct triangles while the modifier can not.
Of course I know it is not as simple because we can't use the same API and the render engine.
However it doesn't seems like it should be impossible either.
Added subscriber: @ThomasDinges
Any updates here please? @antoniov @mendio would be good to get your feedback so this high priority report can be solved.
@ThomasDinges Sorry, but we don't know this area of the code... @ChengduLittleA Do you have any update of this high priority bug?
Changed status from 'Confirmed' to: 'Resolved'
I don't think the current code logic is gonna change unless there's modification to the dg evaluation path. So as long as this can be mitigated by either putting the gp object out of the instanced collection or disable instanced objects in line art, I think this problem can be marked as resolved.