Make available for Capture Attribute node laziness evaluation #102511

Open
opened 2022-11-14 23:41:56 +01:00 by Iliya Katushenock · 7 comments

Nodes whose result may not be required should not cause inputs to be evaluated. The Capture Node already has compute disabled if it is not connected. But this is not enough. The node should support laziness and only call compute inputs when needed.

image.png

Nodes whose result may not be required should not cause inputs to be evaluated. The Capture Node already has compute disabled if it is not connected. But this is not enough. The node should support laziness and only call compute inputs when needed. ![image.png](https://archive.blender.org/developer/F13914609/image.png)
Author
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Author
Member

Added subscriber: @mod_moder

Added subscriber: @mod_moder
Member

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Member

If everything else is set up properly, this is probably pretty simple as params.set_input_unused(..).

It's a bit annoying to call it for every single input socket though-- all the different types. So maybe it would be easier to wait for dynamic socket types.
If someone did it earlier though, that would be fine too, it's a nice improvement.

If everything else is set up properly, this is probably pretty simple as `params.set_input_unused(..)`. It's a bit annoying to call it for every single input socket though-- all the different types. So maybe it would be easier to wait for dynamic socket types. If someone did it earlier though, that would be fine too, it's a nice improvement.
Author
Member

As it turned out, both #99563 (Store Named Attribute requires evaluation even if it does not used) have a hidden complexity. Now laziness for nodes connected by more than one link works a little differently than intended in these tasks. Because of this, these tasks will require deeper changes.

As it turned out, both #99563 (Store Named Attribute requires evaluation even if it does not used) have a hidden complexity. Now laziness for nodes connected by more than one link works a little differently than intended in these tasks. Because of this, these tasks will require deeper changes.

Added subscriber: @Bradley_G

Added subscriber: @Bradley_G

Not sure if it's relevant to this post.
I want to add that if you output a capture attribute in a group node at the time when making an asset, this capture attribute will be computed even if that linkage is not used outside the node group. In such a case, Transfer attribute seems kind of better option for making a group node, as it won't be computed when its linkage is not being used regardless. However, when it's used, it also seems to be slower than capture attribute.

Not sure if it's relevant to this post. I want to add that if you output a capture attribute in a group node at the time when making an asset, this capture attribute will be computed even if that linkage is not used outside the node group. In such a case, Transfer attribute seems kind of better option for making a group node, as it won't be computed when its linkage is not being used regardless. However, when it's used, it also seems to be slower than capture attribute.
Iliya Katushenock self-assigned this 2023-01-28 20:21:21 +01:00
Philipp Oeser removed the
Interest
Nodes & Physics
label 2023-02-10 08:43:30 +01:00
Iliya Katushenock removed the
Status
Confirmed
Module
Nodes & Physics
labels 2024-02-19 18:33:55 +01:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#102511
No description provided.