Clickable area of Current File Assets in 'template_asset_view' is reduced when no 'drag_operator' is used #102856

New Issue

Mysteryem · 2022-11-29T18:00:44+01:00

Mysteryem commented

2022-11-29 18:00:44 +01:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94

Blender Version
Broken: version: 3.3.1, branch: master, commit date: 2022-10-04 18:35, hash: b292cfe5a9 and 3.3.2 Release Candidate, branch: master, commit date: 2022-11-24 14:33, hash: 2124bfb211
Worked: (newest version of Blender that worked as expected)

Short description of error
The clickable area of Current File Assets in template_asset_view is reduced when no drag_operator is used. To be precise, it looks like the clickable area of the text and asset preview isn't expanding with UI. The green regions roughly show the clickable area of the Cube asset in both Panels:

Exact steps for others to reproduce the error

Open the attached .blend (authored in 3.3.1, it has the default Camera, Cube and Light marked as Assets and a script to run in the Text Editor)
Run the script in the Text Editor to create two Operators and two Panels shown in the Test category of the UI region (right shelf) of the 3D View.

Observe the difference in the clickable area of Current File Assets in both Panels (the ActivateAsset Operator will report whenever an Asset is clicked on and expanding the width of the Panels makes the issue more obvious).

template_asset_view_drag_test.blend
The included script is reproduced below:

import bpy


class ActivateAsset(bpy.types.Operator):
    bl_idname = 'test.activate_asset'
    bl_label = "Test Activate"
    
    @classmethod
    def poll(cls, context):
        return context.asset_file_handle is not None
    
    def execute(self, context):
        asset = context.asset_file_handle
        self.report({'INFO'}, f"Activated asset '{asset.name}'")
        return {'FINISHED'}


class DragAsset(bpy.types.Operator):
    bl_idname = 'test.drag_asset'
    bl_label = "Test Drag"
    
    @classmethod
    def poll(cls, context):
        return context.asset_file_handle is not None
    
    def execute(self, context):
        asset = context.asset_file_handle
        self.report({'INFO'}, f"Dragged asset '{asset.name}'")
        return {'FINISHED'}


def draw_asset_view(self, context, use_drag):
    layout = self.layout
    workspace = context.workspace
    wm = context.window_manager
    if use_drag:
        drag_operator=DragAsset.bl_idname
    else:
        drag_operator=""
    - list_id must be unique otherwise behaviour gets weird when the template_asset_view is shown twice
    - (drag operator stops working in AssetPanelDrag, clickable area of all Assets in AssetPanelNoDrag gets
    - reduced to below the Asset name and clickable area of Current File Assets in AssetPanelDrag gets
    - reduced as if it didn't have a drag operator)
    list_id = "test_assets_drag" if use_drag else "test_assets_no_drag"
    _activate_op_props, _drag_op_props = layout.template_asset_view(
        list_id,
        workspace,
        "asset_library_ref",
        wm,
        "test_assets",
        wm,
        "test_active_index",
        activate_operator=ActivateAsset.bl_idname,
        drag_operator=drag_operator,
    )


class AssetPanelDrag(bpy.types.Panel):
    bl_idname = 'TEST_PT_asset_panel_drag'
    bl_label = "Panel With Drag"
    bl_space_type = 'VIEW_3D'
    bl_region_type = 'UI'
    bl_category = "Test"
    
    def draw(self, context):
        draw_asset_view(self, context, True)


class AssetPanelNoDrag(bpy.types.Panel):
    bl_idname = 'TEST_PT_asset_panel_no_drag'
    bl_label = "Without Drag"
    bl_space_type = 'VIEW_3D'
    bl_region_type = 'UI'
    bl_category = "Test"
    
    def draw(self, context):
        draw_asset_view(self, context, False)
    
    

bpy.types.WindowManager.test_assets = bpy.props.CollectionProperty(type=bpy.types.AssetHandle)
bpy.types.WindowManager.test_active_index = bpy.props.IntProperty()
bpy.utils.register_class(ActivateAsset)
bpy.utils.register_class(DragAsset)
bpy.utils.register_class(AssetPanelDrag)
bpy.utils.register_class(AssetPanelNoDrag)

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1070 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 516.94 **Blender Version** Broken: version: 3.3.1, branch: master, commit date: 2022-10-04 18:35, hash: `b292cfe5a9` and 3.3.2 Release Candidate, branch: master, commit date: 2022-11-24 14:33, hash: `2124bfb211` Worked: (newest version of Blender that worked as expected) **Short description of error** The clickable area of Current File Assets in `template_asset_view` is reduced when no drag_operator is used. To be precise, it looks like the clickable area of the text and asset preview isn't expanding with UI. The green regions roughly show the clickable area of the Cube asset in both Panels: ![image.png](https://archive.blender.org/developer/F13979348/image.png) **Exact steps for others to reproduce the error** - Open the attached .blend (authored in 3.3.1, it has the default Camera, Cube and Light marked as Assets and a script to run in the Text Editor) - Run the script in the Text Editor to create two Operators and two Panels shown in the `Test` category of the `UI` region (right shelf) of the 3D View. # Observe the difference in the clickable area of Current File Assets in both Panels (the ActivateAsset Operator will report whenever an Asset is clicked on and expanding the width of the Panels makes the issue more obvious). [template_asset_view_drag_test.blend](https://archive.blender.org/developer/F13979369/template_asset_view_drag_test.blend) The included script is reproduced below: ``` import bpy class ActivateAsset(bpy.types.Operator): bl_idname = 'test.activate_asset' bl_label = "Test Activate" @classmethod def poll(cls, context): return context.asset_file_handle is not None def execute(self, context): asset = context.asset_file_handle self.report({'INFO'}, f"Activated asset '{asset.name}'") return {'FINISHED'} class DragAsset(bpy.types.Operator): bl_idname = 'test.drag_asset' bl_label = "Test Drag" @classmethod def poll(cls, context): return context.asset_file_handle is not None def execute(self, context): asset = context.asset_file_handle self.report({'INFO'}, f"Dragged asset '{asset.name}'") return {'FINISHED'} def draw_asset_view(self, context, use_drag): layout = self.layout workspace = context.workspace wm = context.window_manager if use_drag: drag_operator=DragAsset.bl_idname else: drag_operator="" - list_id must be unique otherwise behaviour gets weird when the template_asset_view is shown twice - (drag operator stops working in AssetPanelDrag, clickable area of all Assets in AssetPanelNoDrag gets - reduced to below the Asset name and clickable area of Current File Assets in AssetPanelDrag gets - reduced as if it didn't have a drag operator) list_id = "test_assets_drag" if use_drag else "test_assets_no_drag" _activate_op_props, _drag_op_props = layout.template_asset_view( list_id, workspace, "asset_library_ref", wm, "test_assets", wm, "test_active_index", activate_operator=ActivateAsset.bl_idname, drag_operator=drag_operator, ) class AssetPanelDrag(bpy.types.Panel): bl_idname = 'TEST_PT_asset_panel_drag' bl_label = "Panel With Drag" bl_space_type = 'VIEW_3D' bl_region_type = 'UI' bl_category = "Test" def draw(self, context): draw_asset_view(self, context, True) class AssetPanelNoDrag(bpy.types.Panel): bl_idname = 'TEST_PT_asset_panel_no_drag' bl_label = "Without Drag" bl_space_type = 'VIEW_3D' bl_region_type = 'UI' bl_category = "Test" def draw(self, context): draw_asset_view(self, context, False) bpy.types.WindowManager.test_assets = bpy.props.CollectionProperty(type=bpy.types.AssetHandle) bpy.types.WindowManager.test_active_index = bpy.props.IntProperty() bpy.utils.register_class(ActivateAsset) bpy.utils.register_class(DragAsset) bpy.utils.register_class(AssetPanelDrag) bpy.utils.register_class(AssetPanelNoDrag) ```

Mysteryem commented

2022-11-29 18:00:44 +01:00

Added subscriber: @Mysteryem-2