Crash when Undo after Removing color attribute #102875

New Issue

Alex Zhornyak · 2022-11-30T13:06:18+01:00

Alex Zhornyak commented

2022-11-30 13:06:18 +01:00

System Information
Operating system: macOS-12.4-arm64-arm-64bit 64 Bits
Graphics card: Apple M1 Apple 4.1 Metal - 76.3

Blender Version
Broken: version: 3.3.1, branch: master, commit date: 2022-10-04 18:35, hash: b292cfe5a9
Worked: version: 3.2.1, branch: master, commit date: 2022-07-05 15:44, hash: a2d59b2dac

Short description of error

Crash when Undo after Remove Color Layer - bpy.ops.geometry.color_attribute_remove()
Crash when accessing bmesh vents in depsgraph_update_post handler after Remove Color Layer

Exact steps for others to reproduce the error
Option 1:

Load zen_button_test_color_del.blend
Execute Remove Color Layer - bpy.ops.geometry.color_attribute_remove()
Execute Undo

Option 2 (it acctually breaks my add-on):

Load zen_button_test_color_del.blend
Load and Run script test_color_layer_remove.py
Execute Remove Color Layer - bpy.ops.geometry.color_attribute_remove()

[Based on zen_button_test_color_del.blend]

P.S. It was also on Windows 3.3.1 and Windows 3.4 beta, the crash is happened there too

zen_button_test_color_del.blend

test_color_layer_remove.py

Screen Recording 2022-11-30 at 13.32.53.mp4

**System Information** Operating system: `macOS-12.4-arm64-arm-64bit 64 Bits` Graphics card: `Apple M1 Apple 4.1 Metal - 76.3` **Blender Version** Broken: version: 3.3.1, branch: master, commit date: 2022-10-04 18:35, hash: `b292cfe5a9` Worked: version: 3.2.1, branch: master, commit date: 2022-07-05 15:44, hash: `a2d59b2dac` **Short description of error** 1. Crash when Undo after Remove Color Layer - bpy.ops.geometry.color_attribute_remove() 2. Crash when accessing bmesh vents in depsgraph_update_post handler after Remove Color Layer **Exact steps for others to reproduce the error** Option 1: 1. Load **zen_button_test_color_del.blend** 2. Execute Remove Color Layer - bpy.ops.geometry.color_attribute_remove() 3. Execute Undo Option 2 (it acctually breaks my add-on): 1. Load **zen_button_test_color_del.blend** 2. Load and Run script **test_color_layer_remove.py** 3. Execute Remove Color Layer - bpy.ops.geometry.color_attribute_remove() [Based on zen_button_test_color_del.blend] P.S. It was also on Windows 3.3.1 and Windows 3.4 beta, the crash is happened there too [zen_button_test_color_del.blend](https://archive.blender.org/developer/F13981842/zen_button_test_color_del.blend) [test_color_layer_remove.py](https://archive.blender.org/developer/F13981897/test_color_layer_remove.py) [Screen Recording 2022-11-30 at 13.32.53.mp4](https://archive.blender.org/developer/F13981869/Screen_Recording_2022-11-30_at_13.32.53.mp4)

Alex Zhornyak commented

2022-11-30 13:06:18 +01:00

Added subscriber: @azhornyak

Iliya Katushenock commented

2022-11-30 14:24:51 +01:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2022-11-30 14:24:51 +01:00

Checking...

Pratik Borhade commented

2022-11-30 14:29:41 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2022-11-30 14:29:41 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2022-11-30 14:29:41 +01:00

Thanks for the report. I can redo the crash in 3.3.1 but not in current master/3.4
I'll check in latest 3.3.2 build and find the resolving commit if it has not been pushed to LTS branch

Sorry @mod_moder, didn't see your comment. Are you bisecting too?

Thanks for the report. I can redo the crash in 3.3.1 but not in current master/3.4 I'll check in latest 3.3.2 build and find the resolving commit if it has not been pushed to LTS branch - - - Sorry @mod_moder, didn't see your comment. Are you bisecting too?

Iliya Katushenock commented

2022-11-30 14:32:40 +01:00

(I suspected that you were on duty right now. :) )
At the beginning of the month it was at 3.3 and at 3.4
I was just downloading the 3.3 candidate release to test
Since in 3.4 today this is not.
I suspect it's just not fixed in 3.3

(I suspected that you were on duty right now. :) ) At the beginning of the month it was at 3.3 and at 3.4 I was just downloading the 3.3 candidate release to test Since in 3.4 today this is not. I suspect it's just not fixed in 3.3

Pratik Borhade commented

2022-11-30 14:39:07 +01:00

Thanks @mod_moder
I can repro in current 3.3 branch. Will bisect.

Thanks @mod_moder I can repro in current 3.3 branch. Will bisect.

Iliya Katushenock commented

2022-11-30 14:39:52 +01:00

It was in 3.5. I bisect to find a fix

Iliya Katushenock commented

2022-11-30 14:42:07 +01:00

It fixed (2022-11-22 00:01, hash: 89349067b6) -- (2022-11-23 18:35, hash: f4e1f62c62) for 3.4 and 3.5

It fixed (2022-11-22 00:01, hash: `89349067b6`) -- (2022-11-23 18:35, hash: `f4e1f62c62`) for 3.4 and 3.5

Iliya Katushenock commented

2022-11-30 14:44:30 +01:00

Potential fix: {461cb550cc07}

Alex Zhornyak commented

2022-11-30 15:05:01 +01:00

I can confirm that bug is not reproduced on version: 3.4.0 Beta, branch: blender-v3.4-release, commit date: 2022-11-29 22:36, hash: b7d27ce914. So only 3.3 issue

I can confirm that bug is not reproduced on version: 3.4.0 Beta, branch: blender-v3.4-release, commit date: 2022-11-29 22:36, hash: `b7d27ce914`. So only 3.3 issue

Pratik Borhade commented

2022-11-30 15:06:20 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Pratik Borhade closed this issue

2022-11-30 15:06:20 +01:00

Hans Goudey was assigned by Pratik Borhade

2022-11-30 15:06:20 +01:00

Pratik Borhade commented

2022-11-30 15:06:20 +01:00

@mod_moder, that was fast :)
indeed the same commit has fixed the crash 461cb550cc
@azhornyak, fix is already mentioned in LTS list, will be backported soon.
I'm closing your report.

@mod_moder, that was fast :) indeed the same commit has fixed the crash 461cb550cc @azhornyak, fix is already mentioned in LTS list, will be backported soon. I'm closing your report.

Thomas Dinges added this to the 3.3 LTS milestone 2023-02-08 15:37:44 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Crash when Undo after Removing color attribute #102875