"view3d.view_roll" operator conflicts with Right Mouse button #102937

New Issue

Blendy · 2022-12-04T07:22:21+01:00

Blendy commented

2022-12-04 07:22:21 +01:00

System Information
Operating system: Windows 10
Graphics card:

Blender Version
Broken:
3.3, 3.5 alpha
Worked:
2.90
Short description of error
Because I use a ZBrush style navigation keymap. So I want to use right mouse button to rotate or roll viewport. If I bind view3d.view_roll to Shift+Right Mouse (press), the viewport can roll normally during right mouse button pressed, but once I release right mouse button, viewport angle resets back to previous status instantly. I'd already changed all right mouse menu keymaps when I tested it.
And it worked perfectly in Blender 2.90.

**System Information** Operating system: Windows 10 Graphics card: **Blender Version** Broken: 3.3, 3.5 alpha Worked: 2.90 **Short description of error** Because I use a ZBrush style navigation keymap. So I want to use right mouse button to rotate or roll viewport. If I bind view3d.view_roll to Shift+Right Mouse (press), the viewport can roll normally during right mouse button pressed, but once I release right mouse button, viewport angle resets back to previous status instantly. I'd already changed all right mouse menu keymaps when I tested it. And it worked perfectly in Blender 2.90.

Blendy commented

2022-12-04 07:22:21 +01:00

Added subscriber: @Rays-Lv

Omar Emara commented

2022-12-05 09:37:30 +01:00

Added subscribers: @lichtwerk, @OmarEmaraDev

Omar Emara commented

2022-12-05 09:37:30 +01:00

Changed status from 'Needs Triage' to: 'Needs Developer To Reproduce'

Omar Emara commented

2022-12-05 09:37:30 +01:00

This seems to be the operator getting canceled on right click key release. Which was introduced in 3.0 in 5d5504d8a4. So not sure if this is a bug.
Perhaps it should only cancel on pressed not releases? Perhaps you should handle this report @lichtwerk.

diff --git a/source/blender/editors/space_view3d/view3d_navigate_roll.c b/source/blender/editors/space_view3d/view3d_navigate_roll.c
index af93aa50238..cbc5a86f636 100644
--- a/source/blender/editors/space_view3d/view3d_navigate_roll.c
+++ b/source/blender/editors/space_view3d/view3d_navigate_roll.c
@@ -106,7 +106,7 @@ static int viewroll_modal(bContext *C, wmOperator *op, const wmEvent *event)
         break;
     }
   }
-  else if (ELEM(event->type, EVT_ESCKEY, RIGHTMOUSE)) {
+  else if (ELEM(event->type, EVT_ESCKEY, RIGHTMOUSE) && event->val == KM_PRESS) {
     /* Note this does not remove auto-keys on locked cameras. */
     copy_qt_qt(vod->rv3d->viewquat, vod->init.quat);
     ED_view3d_camera_lock_sync(vod->depsgraph, vod->v3d, vod->rv3d);

This seems to be the operator getting canceled on right click key release. Which was introduced in 3.0 in 5d5504d8a4. So not sure if this is a bug. Perhaps it should only cancel on pressed not releases? Perhaps you should handle this report @lichtwerk. ``` diff --git a/source/blender/editors/space_view3d/view3d_navigate_roll.c b/source/blender/editors/space_view3d/view3d_navigate_roll.c index af93aa50238..cbc5a86f636 100644 --- a/source/blender/editors/space_view3d/view3d_navigate_roll.c +++ b/source/blender/editors/space_view3d/view3d_navigate_roll.c @@ -106,7 +106,7 @@ static int viewroll_modal(bContext *C, wmOperator *op, const wmEvent *event) break; } } - else if (ELEM(event->type, EVT_ESCKEY, RIGHTMOUSE)) { + else if (ELEM(event->type, EVT_ESCKEY, RIGHTMOUSE) && event->val == KM_PRESS) { /* Note this does not remove auto-keys on locked cameras. */ copy_qt_qt(vod->rv3d->viewquat, vod->init.quat); ED_view3d_camera_lock_sync(vod->depsgraph, vod->v3d, vod->rv3d); ```

Philipp Oeser commented

2022-12-05 09:51:03 +01:00

The times I see ELEM(event->type, EVT_ESCKEY, RIGHTMOUSE) in context of cancelling, it is not used on KM_PRESS only.
So not sure what the "rules" are here.

Guess this is something the #user_interface module has to decide.

The times I see `ELEM(event->type, EVT_ESCKEY, RIGHTMOUSE)` in context of cancelling, it is not used on `KM_PRESS` only. So not sure what the "rules" are here. Guess this is something the #user_interface module has to decide.

Blendy commented

2022-12-05 18:10:51 +01:00

In #102937#1455002, @OmarEmaraDev wrote:
This seems to be the operator getting canceled on right click key release. Which was introduced in 3.0 in 5d5504d8a4. So not sure if this is a bug.
Perhaps it should only cancel on pressed not releases? Perhaps you should handle this report @lichtwerk.

I don't think view3d.view_roll should be canceled by right mouse, while right mouse can be remapped to roll viewport. And it's an unnecessary design. At least I'd never seen any scenario where I had to cancel rolling the viewport in practice.
If you want to make this design robust, you should add a customizable modal for view3d.view_roll like view3d.rotate with a "Cancel" event, so that user can set another key to cancel this operator.

> In #102937#1455002, @OmarEmaraDev wrote: > This seems to be the operator getting canceled on right click key release. Which was introduced in 3.0 in 5d5504d8a4. So not sure if this is a bug. > Perhaps it should only cancel on pressed not releases? Perhaps you should handle this report @lichtwerk. I don't think view3d.view_roll should be canceled by right mouse, while right mouse can be remapped to roll viewport. And it's an unnecessary design. At least I'd never seen any scenario where I had to cancel rolling the viewport in practice. If you want to make this design robust, you should add a customizable modal for view3d.view_roll like view3d.rotate with a "Cancel" event, so that user can set another key to cancel this operator.

blender-admin commented

2022-12-06 10:49:38 +01:00

This issue was referenced by 31943d1313

This issue was referenced by 31943d13134675abca4c1c35a86ffe2fe3f89af5

Campbell Barton commented

2022-12-06 10:54:11 +01:00

Changed status from 'Needs Developer To Reproduce' to: 'Resolved'

Campbell Barton closed this issue

2022-12-06 10:54:11 +01:00

Campbell Barton self-assigned this 2022-12-06 10:54:11 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

"view3d.view_roll" operator conflicts with Right Mouse button #102937