Cycles: The sun lamp from Nitisha sky is not included in the light tree. #103094

New Issue

Alaska · 2022-12-10T03:54:49+01:00

Alaska commented

2022-12-10 03:54:49 +01:00

System Information
Operating system: Linux-6.0.0-5-amd64-x86_64-with-glibc2.36 64 Bits
Graphics card: NA

Blender Version
Broken version: 3.5.0 Alpha, branch: master, commit date: 2022-12-09 22:10, hash: 19d90c7a33
Worked: NA

Short description of error
The sun lamp used as part of the Nitisha sky texture is not included in the light tree which can lead to a increase in noise in some situations.

Exact steps for others to reproduce the error

Open Blender.
Change the render engine to Cycles.
Add a sky texture to the "World Shader" and set the type to "Nishita" (Nishita is the default)
Remove everything from the Nishita sky texture except the sun. (This can be down by setting Air, Dust, and Ozone to 0).
Enter the rendered viewport and notice how the sun isn't being sampled often, and this is because the sun light isn't included in the light tree.
Turn off the light tree and see the sun is being sampled.

Or download the file I've attached below (steps 1-4 already done).
Sky texture sun missing from light tree.blend

Notes:

Adjusting the sun elevation and rotation will sometimes result in the sun being properly sampled. I assume this is because the sun is now in the right position to be captured in the importance map used by the light tree to help with sampling background lights.
Increasing the sun disk size in the Nishita sky texture node will also result in improved sampling of sun with the light tree. I assume this is for the same reason as before. The sun disk is now captured in the importance map.

Here's a video showing the issue:
Light tree sky texture issue.mp4

**System Information** Operating system: Linux-6.0.0-5-amd64-x86_64-with-glibc2.36 64 Bits Graphics card: NA **Blender Version** Broken version: 3.5.0 Alpha, branch: master, commit date: 2022-12-09 22:10, hash: `19d90c7a33` Worked: NA **Short description of error** The sun lamp used as part of the Nitisha sky texture is not included in the light tree which can lead to a increase in noise in some situations. **Exact steps for others to reproduce the error** 1. Open Blender. 2. Change the render engine to Cycles. 3. Add a sky texture to the "World Shader" and set the type to "Nishita" (Nishita is the default) 4. Remove everything from the Nishita sky texture except the sun. (This can be down by setting `Air`, `Dust`, and `Ozone` to `0`). 5. Enter the rendered viewport and notice how the sun isn't being sampled often, and this is because the sun light isn't included in the light tree. 6. Turn off the `light tree` and see the sun is being sampled. Or download the file I've attached below (steps 1-4 already done). [Sky texture sun missing from light tree.blend](https://archive.blender.org/developer/F14048808/Sky_texture_sun_missing_from_light_tree.blend) Notes: 1. Adjusting the sun elevation and rotation will sometimes result in the sun being properly sampled. I assume this is because the sun is now in the right position to be captured in the importance map used by the light tree to help with sampling background lights. 2. Increasing the sun disk size in the Nishita sky texture node will also result in improved sampling of sun with the light tree. I assume this is for the same reason as before. The sun disk is now captured in the importance map. Here's a video showing the issue: [Light tree sky texture issue.mp4](https://archive.blender.org/developer/F14048804/Light_tree_sky_texture_issue.mp4)

Alaska commented

2022-12-10 03:54:49 +01:00

Added subscriber: @Alaska

Alaska commented

2022-12-10 03:55:57 +01:00

Added subscribers: @weizhen, @brecht

Alaska commented

2022-12-10 03:55:57 +01:00

CC @weizhen or @brecht

Richard Antalik commented

2022-12-10 17:48:06 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Brecht Van Lommel commented

2022-12-12 18:31:50 +01:00

Marking as high priority to ensure we look at this before the 3.5 release.

Jakub Jaszewski commented

2022-12-13 16:11:52 +01:00

Added subscriber: @silex

Max Edge commented

2022-12-15 16:47:33 +01:00

Added subscriber: @Max-49

Jeffrey Liu commented

2022-12-20 07:01:16 +01:00

Added subscriber: @Jebbly

Alaska commented

2022-12-21 05:46:39 +01:00

This information might be useful in fixing the issue.

During the development of the Nishita sky texture some changes had to be made to how the sun was sampled to make sure it worked in a consistent manner. Patch and the changes made can be found in here D7896

This information might be useful in fixing the issue. During the development of the Nishita sky texture some changes had to be made to how the sun was sampled to make sure it worked in a consistent manner. Patch and the changes made can be found in here [D7896](https://archive.blender.org/developer/D7896)

Cassidy Graces Incandela commented

2022-12-22 09:49:27 +01:00

Added subscriber: @cassidy

Jeffrey Liu self-assigned this 2022-12-30 06:00:53 +01:00

blender-admin commented

2023-01-20 01:22:47 +01:00

This issue was referenced by 05bdef7ce6

This issue was referenced by 05bdef7ce64fe3125b95d72d80f1f4f60c2b1274

Jeffrey Liu commented

2023-01-20 01:33:46 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Jeffrey Liu closed this issue

2023-01-20 01:33:46 +01:00

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Cycles: The sun lamp from Nitisha sky is not included in the light tree. #103094