Regression: NODE_OT_add_search ignores NodeItems entries #103108

New Issue

Blender Version
Broken: 3.4
Worked: 3.3
Caused by bdb5754147

Short description of error
NodeItems entries are not taken into account when using the node Shift+A search functionality.

Exact steps for others to reproduce the error

Load and register the Python > Custom Nodes script template.
Use the Shift + A search functionality.
In 3.4 Node A and Node B are missing.

3.3	3.4

Reproduction File
NodeItemsSearchRegression.blend

More Context
In Malt (https:*github.com/bnpr/Malt), we generate most nodes from a few node classes (https:*github.com/bnpr/Malt/tree/Development/BlenderMalt/MaltNodes/Nodes) and auto-generated GLSL reflection data.
We also use NodeItems to allow searching directly for node drop-down subcategories. (ie. you can search directly for Dot Product, instead of searching for Vector and then selecting the Dot Product option)
But none of this works in 3.4

**Blender Version** Broken: 3.4 Worked: 3.3 Caused by bdb5754147 **Short description of error** NodeItems entries are not taken into account when using the node `Shift+A` search functionality. **Exact steps for others to reproduce the error** - Load and register the `Python > Custom Nodes` script template. - Use the `Shift + A` search functionality. - In 3.4 `Node A` and `Node B` are missing. | 3.3 | 3.4 | | -- | -- | | ![imagen.png](https://archive.blender.org/developer/F14050371/imagen.png) | ![imagen.png](https://archive.blender.org/developer/F14050375/imagen.png) | **Reproduction File** [NodeItemsSearchRegression.blend](https://archive.blender.org/developer/F14050377/NodeItemsSearchRegression.blend) **More Context** In Malt (https:*github.com/bnpr/Malt), we generate most nodes from a few node classes (https:*github.com/bnpr/Malt/tree/Development/BlenderMalt/MaltNodes/Nodes) and auto-generated GLSL reflection data. We also use NodeItems to allow searching directly for node drop-down subcategories. (ie. you can search directly for `Dot Product`, instead of searching for `Vector` and then selecting the `Dot Product` option) But none of this works in 3.4

Added subscriber: @pragma37

Added subscriber: @HooglyBoogly

Changed status from 'Needs Triage' to: 'Confirmed'

Added subscriber: @mod_moder

2022-09-18 20:10, hash: ecf3435362 -- 2022-09-24 17:57, hash: 4e7983e073

2022-09-18 20:10, hash: `ecf3435362` -- 2022-09-24 17:57, hash: `4e7983e073`

Potential caused by: bdb5754147

Potential caused by: bdb5754147

Added subscriber: @EAW

Unfortunately I didn't consider this case in the commit mentioned here. The addons I knew about implemented their own search menus, so I didn't think about this case.
There isn't a simple way to fix this in 3.4. Longer term, I would like this sort of information to be a callback on the node type.

Unfortunately I didn't consider this case in the commit mentioned here. The addons I knew about implemented their own search menus, so I didn't think about this case. There isn't a simple way to fix this in 3.4. Longer term, I would like this sort of information to be a callback on the node type.

I don't know why this is marked as a known issue and high priority. If it's high priority it's a bug to be fixed.

It was a functional regression. But now, looking at the history available to me, not sure who set the sub type.

With cc925b9282 we can now add a Python node type callback for adding items to the search menu. However, that commit is only in 3.6, so the fix will have to be postponed until then unfortunately.

With cc925b92828991f42de9c17d04999630033bc23b we can now add a Python node type callback for adding items to the search menu. However, that commit is only in 3.6, so the fix will have to be postponed until then unfortunately.

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: NODE_OT_add_search ignores NodeItems entries #103108