Regression: NODE_OT_add_search ignores NodeItems entries #103108
Short description of error
NodeItems entries are not taken into account when using the node
Shift+A search functionality.
Exact steps for others to reproduce the error
- Load and register the
Python > Custom Nodesscript template.
- Use the
Shift + Asearch functionality.
- In 3.4
Node Bare missing.
In Malt (https:*github.com/bnpr/Malt), we generate most nodes from a few node classes (https:*github.com/bnpr/Malt/tree/Development/BlenderMalt/MaltNodes/Nodes) and auto-generated GLSL reflection data.
We also use NodeItems to allow searching directly for node drop-down subcategories. (ie. you can search directly for
Dot Product, instead of searching for
Vector and then selecting the
Dot Product option)
But none of this works in 3.4
Changed status from 'Needs Triage' to: 'Confirmed'
2022-09-18 20:10, hash:
ecf3435362 -- 2022-09-24 17:57, hash:
Unfortunately I didn't consider this case in the commit mentioned here. The addons I knew about implemented their own search menus, so I didn't think about this case.
There isn't a simple way to fix this in 3.4. Longer term, I would like this sort of information to be a callback on the node type.
I don't know why this is marked as a known issue and high priority. If it's high priority it's a bug to be fixed.
It was a functional regression. But now, looking at the history available to me, not sure who set the sub type.
cc925b9282 we can now add a Python node type callback for adding items to the search menu. However, that commit is only in 3.6, so the fix will have to be postponed until then unfortunately.
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?