Regression: NODE_OT_add_search ignores NodeItems entries #103108
Labels
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: blender/blender#103108
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Blender Version
Broken: 3.4
Worked: 3.3
Caused by
bdb5754147Short description of error
NodeItems entries are not taken into account when using the node
Shift+Asearch functionality.Exact steps for others to reproduce the error
Python > Custom Nodesscript template.Shift + Asearch functionality.Node AandNode Bare missing.Reproduction File
NodeItemsSearchRegression.blend
More Context
In Malt (https:*github.com/bnpr/Malt), we generate most nodes from a few node classes (https:*github.com/bnpr/Malt/tree/Development/BlenderMalt/MaltNodes/Nodes) and auto-generated GLSL reflection data.
We also use NodeItems to allow searching directly for node drop-down subcategories. (ie. you can search directly for
Dot Product, instead of searching forVectorand then selecting theDot Productoption)But none of this works in 3.4
Added subscriber: @pragma37
Added subscriber: @HooglyBoogly
Changed status from 'Needs Triage' to: 'Confirmed'
Added subscriber: @mod_moder
2022-09-18 20:10, hash:
ecf3435362-- 2022-09-24 17:57, hash:4e7983e073Potential caused by:
bdb5754147Added subscriber: @EAW
Unfortunately I didn't consider this case in the commit mentioned here. The addons I knew about implemented their own search menus, so I didn't think about this case.
There isn't a simple way to fix this in 3.4. Longer term, I would like this sort of information to be a callback on the node type.
I don't know why this is marked as a known issue and high priority. If it's high priority it's a bug to be fixed.
It was a functional regression. But now, looking at the history available to me, not sure who set the sub type.
With
cc925b9282we can now add a Python node type callback for adding items to the search menu. However, that commit is only in 3.6, so the fix will have to be postponed until then unfortunately.