Regression: Area lamps ignore the Shadow Catcher property on objects in light group passes #103403

Closed
opened 2022-12-22 12:06:49 +01:00 by rafek yousef · 10 comments

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA RTX A6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 527.27

Blender Version
Broken: version: 3.3.2, branch: master, commit date: 2022-12-06 18:19, hash: bf24652e38
Broken: 3.2.2
Worked: 3.2.1

Seems this broke with d26c29d8e4

Short description of error

Area lamps ignore the Shadow Cather property on objects in light group passes. Other lamp types work correctly.

20221222-140637.png

Exact steps for others to reproduce the error

  • The attached file contains a shadow catcher plane with a light group pass containing a single area light.
  • Rendering the scene will result in the plane receiving the direct light from the area light.
  • Changing the type of the light to something else works correctly.

shadow captrue issue.blend

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA RTX A6000/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 527.27 **Blender Version** Broken: version: 3.3.2, branch: master, commit date: 2022-12-06 18:19, hash: `bf24652e38` Broken: 3.2.2 Worked: 3.2.1 Seems this broke with d26c29d8e4 **Short description of error** Area lamps ignore the Shadow Cather property on objects in light group passes. Other lamp types work correctly. ![20221222-140637.png](https://archive.blender.org/developer/F14083125/20221222-140637.png) **Exact steps for others to reproduce the error** - The attached file contains a shadow catcher plane with a light group pass containing a single area light. - Rendering the scene will result in the plane receiving the direct light from the area light. - Changing the type of the light to something else works correctly. [shadow captrue issue.blend](https://archive.blender.org/developer/F14082947/shadow_captrue_issue.blend)
Author

Added subscriber: @rfc

Added subscriber: @rfc
Omar Emara changed title from Shadow catcher does not work in light groups with Area lamps only to Area lamps ignore the Shadow Cather property on objects in light group passes 2022-12-22 13:10:21 +01:00
Member

Changed status from 'Needs Triage' to: 'Confirmed'

Changed status from 'Needs Triage' to: 'Confirmed'
Philipp Oeser changed title from Area lamps ignore the Shadow Cather property on objects in light group passes to Area lamps ignore the Shadow Catcher property on objects in light group passes 2023-01-02 07:18:33 +01:00
Member

Added subscribers: @LukasStockner, @lichtwerk

Added subscribers: @LukasStockner, @lichtwerk
Member

Seems this broke with d26c29d8e4

@LukasStockner : mind checking?

Seems this broke with d26c29d8e4 @LukasStockner : mind checking?
Philipp Oeser changed title from Area lamps ignore the Shadow Catcher property on objects in light group passes to Regression: Area lamps ignore the Shadow Catcher property on objects in light group passes 2023-01-02 11:39:50 +01:00
Lukas Stockner self-assigned this 2023-01-06 01:49:30 +01:00
Member

This appears to be connected to MIS - while it's most obvious with area lights, you can also reproduce it with point lights by setting them to a high radius, and the problem goes away when you disable MIS on the lamp.
I'll have a closer look.

This appears to be connected to MIS - while it's most obvious with area lights, you can also reproduce it with point lights by setting them to a high radius, and the problem goes away when you disable MIS on the lamp. I'll have a closer look.
Member

Fun fact: The reason why this "worked" before d26c29d8e4 is that back then, light groups were completely broken when using shadow catcher, so what you actually got was the Combined pass without alpha channel. The real lightgroup pass already had the bug reported here, you just didn't see it because of the other bug.
Therefore, I'd argue that it's debatable whether this really is a regression - but meh, it needs to be fixed anyways.

Fun fact: The reason why this "worked" before d26c29d8e4 is that back then, light groups were completely broken when using shadow catcher, so what you actually got was the Combined pass without alpha channel. The real lightgroup pass already had the bug reported here, you just didn't see it because of the other bug. Therefore, I'd argue that it's debatable whether this really is a regression - but meh, it needs to be fixed anyways.

This issue was referenced by d290b8b2b9

This issue was referenced by d290b8b2b9ecaa5c9b477aa1868b69db15a84cd3

This issue was referenced by 00a20aec07

This issue was referenced by 00a20aec074c3a10a2d2e1142c14cc533c90a6b3
Member

Changed status from 'Confirmed' to: 'Resolved'

Changed status from 'Confirmed' to: 'Resolved'
Member

Thx doing the digging and fixing!

Thx doing the digging and fixing!
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#103403
No description provided.