Regression: Crash on Insert Keyframe #103426

New Issue

Tony Reason · 2022-12-23T01:22:58+01:00

Tony Reason commented

2022-12-23 01:22:58 +01:00

System Information
Operating system: Windows-10-10.0.22621-SP0 64 Bits
Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 527.56

Blender Version
Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-12-22 21:14, hash: 15c433d7d5
Worked: version: 3.5.0 Alpha, branch: master, commit date: 2022-12-19 20:56, hash: c2a8d8b18d
Caused by a7ad2dea62

Short description of error
Blender crashes when inserting a Keyframe: from the Insert Keyframe menu, Animate Property Button, and Context Menu.

Exact steps for others to reproduce the error
Insert a Keyframe

I have tried disabling every Add-on, but it still occurs.

Insert Keyframe Crash.mp4

**System Information** Operating system: Windows-10-10.0.22621-SP0 64 Bits Graphics card: NVIDIA GeForce RTX 3090/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 527.56 **Blender Version** Broken: version: 3.5.0 Alpha, branch: master, commit date: 2022-12-22 21:14, hash: `15c433d7d5` Worked: version: 3.5.0 Alpha, branch: master, commit date: 2022-12-19 20:56, hash: `c2a8d8b18d` Caused by a7ad2dea62 **Short description of error** Blender crashes when inserting a Keyframe: from the Insert Keyframe menu, Animate Property Button, and Context Menu. **Exact steps for others to reproduce the error** Insert a Keyframe I have tried disabling every Add-on, but it still occurs. [Insert Keyframe Crash.mp4](https://archive.blender.org/developer/F14084688/Insert_Keyframe_Crash.mp4)

Tony Reason commented

2022-12-23 01:22:58 +01:00

Added subscriber: @drpontchartrain

blender-admin commented

2022-12-23 01:22:58 +01:00

#103446 was marked as duplicate of this issue

Iliya Katushenock commented

2022-12-23 01:39:21 +01:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2022-12-23 01:39:21 +01:00

Check if you have extraneous addons?
Try using factory settings

Check if you have extraneous addons? Try using factory settings

Tony Reason commented

2022-12-23 01:58:55 +01:00

As mentioned in the original post, I already disabled all add-ons.

Here is a screencast where I reset to Factory settings...
Factory.mp4

As mentioned in the original post, I already disabled all add-ons. Here is a screencast where I reset to Factory settings... [Factory.mp4](https://archive.blender.org/developer/F14084770/Factory.mp4)

Iliya Katushenock commented

2022-12-23 02:07:40 +01:00

Can't confirm

Jesse Yurkovich commented

2022-12-23 02:22:35 +01:00

Added subscribers: @EimearC, @fclem, @deadpin

Jesse Yurkovich commented

2022-12-23 02:22:35 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Jesse Yurkovich commented

2022-12-23 02:22:35 +01:00

I can confirm. The crash happens when displaying the keyframes in the Graph editor there. It will be accompanied with the following on the terminal:

ERROR (gpu.shader): gpu_shader_2D_point_uniform_size_uniform_color_aa FragShader:
      |
    9 | #extension GL_ARB_gpu_shader5 : enable
      |            ^
      | Error: 'srgbTarget' : undeclared identifier
      | Error: '' : boolean expression expected

Looks like this was caused by a7ad2dea62
CC @fclem @EimearC

Crashing stack:

>	blender.exe!GPU_shader_get_builtin_uniform(GPUShader * shader, int builtin) Line 590	C++

 	blender.exe!GPU_matrix_bind(GPUShader * shader) Line 617	C++
 	blender.exe!GPU_shader_bind(GPUShader * gpu_shader) Line 524	C++
 	blender.exe!immBindShader(GPUShader * shader) Line 56	C++
 	blender.exe!immBindBuiltinProgram(eGPUBuiltinShader shader_id) Line 64	C++
 	blender.exe!draw_fcurve_keyframe_vertices(FCurve * fcu, View2D * v2d, bool edit, unsigned int pos) Line 238	C
 	blender.exe!draw_fcurve_vertices(ARegion * region, FCurve * fcu, bool do_handles, bool sel_handle_only) Line 373	C
 	blender.exe!draw_fcurve(bAnimContext * ac, SpaceGraph * sipo, ARegion * region, bAnimListElem * ale) Line 1155	C
 	blender.exe!graph_draw_curves(bAnimContext * ac, SpaceGraph * sipo, ARegion * region, short sel) Line 1367	C
 	blender.exe!graph_main_region_draw(const bContext * C, ARegion * region) Line 219	C
 	blender.exe!ED_region_do_draw(bContext * C, ARegion * region) Line 551	C

I can confirm. The crash happens when displaying the keyframes in the Graph editor there. It will be accompanied with the following on the terminal: ``` ERROR (gpu.shader): gpu_shader_2D_point_uniform_size_uniform_color_aa FragShader: | 9 | #extension GL_ARB_gpu_shader5 : enable | ^ | Error: 'srgbTarget' : undeclared identifier | Error: '' : boolean expression expected ``` Looks like this was caused by a7ad2dea62 CC @fclem @EimearC Crashing stack: ``` > blender.exe!GPU_shader_get_builtin_uniform(GPUShader * shader, int builtin) Line 590 C++ blender.exe!GPU_matrix_bind(GPUShader * shader) Line 617 C++ blender.exe!GPU_shader_bind(GPUShader * gpu_shader) Line 524 C++ blender.exe!immBindShader(GPUShader * shader) Line 56 C++ blender.exe!immBindBuiltinProgram(eGPUBuiltinShader shader_id) Line 64 C++ blender.exe!draw_fcurve_keyframe_vertices(FCurve * fcu, View2D * v2d, bool edit, unsigned int pos) Line 238 C blender.exe!draw_fcurve_vertices(ARegion * region, FCurve * fcu, bool do_handles, bool sel_handle_only) Line 373 C blender.exe!draw_fcurve(bAnimContext * ac, SpaceGraph * sipo, ARegion * region, bAnimListElem * ale) Line 1155 C blender.exe!graph_draw_curves(bAnimContext * ac, SpaceGraph * sipo, ARegion * region, short sel) Line 1367 C blender.exe!graph_main_region_draw(const bContext * C, ARegion * region) Line 219 C blender.exe!ED_region_do_draw(bContext * C, ARegion * region) Line 551 C ```

Pratik Borhade changed title from ~~Crash on Insert Keyframe~~ to Regression: Crash on Insert Keyframe

2022-12-23 07:23:28 +01:00

Eimear Crotty commented

2022-12-23 08:57:38 +01:00

Thanks for looping me in, I'm looking into it now. I believe there were some other shaders using the same source as in https://developer.blender.org/D16831, and I didn't add the "additional_info" function call with the "gpu_srgb_to_framebuffer_space" specifier. Testing the fix now.

I've also confirmed that the graph editor must be open for this crash to occur.

Thanks for looping me in, I'm looking into it now. I believe there were some other shaders using the same source as in https://developer.blender.org/D16831, and I didn't add the "additional_info" function call with the "gpu_srgb_to_framebuffer_space" specifier. Testing the fix now. I've also confirmed that the graph editor must be open for this crash to occur.

Eimear Crotty self-assigned this 2022-12-23 10:03:40 +01:00

blender-admin commented

2022-12-23 11:19:43 +01:00

This issue was referenced by a521960fdd

This issue was referenced by a521960fddf2544b1eeab1f29e03c8d9d4abf86b

Clément Foucault commented

2022-12-23 11:40:08 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Clément Foucault closed this issue

2022-12-23 11:40:08 +01:00

Pratik Borhade commented

2022-12-24 05:20:43 +01:00