Unit Scale change undone when using redo menu #103647

New Issue

jon denning · 2023-01-04T22:51:25+01:00

jon denning commented

2023-01-04 22:51:25 +01:00

System Information
Operating system: Linux-5.11.0-49-generic-x86_64-with-glibc2.33 64 Bits
Graphics card: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.86

Blender Version
Broken: version: 3.4.1, branch: blender-v3.4-release, commit date: 2022-12-19 17:00, hash: 55485cb379
Worked: (haven't tested)

Short description of error
Whenever the redo menu is used, any recent changes to unit scale are undone. When this happens, the redone action can be scaled incorrectly.

Exact steps for others to reproduce the error

start blender with factory settings
delete default cube, then re-add cube (lol)
expand the redo panel for Add Cube, and notice that the cube has Size 2m
open the N panel, switch to Item tab, and notice Dimensions are 2m
under properties, switch to scene tab, and change Unit Scale to 0.1
notice that the cube's Dimensions are now 0.2m and Size in redo panel says 0.2m also
in redo panel for Add Cube, change Size to 2m

The last step is where the problem occurs.

the Scene's Unit Scale are reset back to 1.0 (the 0.1 change was undone)
the Dimensions of cube are now 20m instead of the 2m entered in redo panel
the Size of cube in redo panel is now 20m instead of the 2m entered in redo panel

Changing Unit Scale does trigger an undo step (changes can be undone). Redo rolls all changes done since the redone action was performed. But, weirdly the inputted redo field is computed before redo's undoing happens (so the field has the value based on the settings at exact time of changing, before the action is undone then redone).

Workaround is to change Unit Scale before adding cube, or delete and re-add cube manually.

**System Information** Operating system: Linux-5.11.0-49-generic-x86_64-with-glibc2.33 64 Bits Graphics card: NVIDIA GeForce GTX 1050 Ti/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 470.86 **Blender Version** Broken: version: 3.4.1, branch: blender-v3.4-release, commit date: 2022-12-19 17:00, hash: `55485cb379` Worked: (haven't tested) **Short description of error** Whenever the redo menu is used, any recent changes to unit scale are undone. When this happens, the redone action can be scaled incorrectly. **Exact steps for others to reproduce the error** 1. start blender with factory settings 2. delete default cube, then re-add cube (lol) 3. expand the redo panel for `Add Cube`, and notice that the cube has Size `2m` 4. open the `N` panel, switch to `Item` tab, and notice Dimensions are `2m` 4. under properties, switch to scene tab, and change Unit Scale to `0.1` 5. notice that the cube's Dimensions are now `0.2m` and Size in redo panel says `0.2m` also 6. in redo panel for `Add Cube`, change Size to `2m` The last step is where the problem occurs. - the Scene's Unit Scale are reset back to `1.0` (the `0.1` change was undone) - the Dimensions of cube are now `20m` instead of the `2m` entered in redo panel - the Size of cube in redo panel is now `20m` instead of the `2m` entered in redo panel Changing Unit Scale does trigger an undo step (changes can be undone). Redo rolls all changes done since the redone action was performed. But, weirdly the inputted redo field is computed before redo's undoing happens (so the field has the value based on the settings at exact time of changing, before the action is undone then redone). Workaround is to change Unit Scale before adding cube, or delete and re-add cube manually.

jon denning commented

2023-01-04 22:51:25 +01:00

Added subscriber: @gfxcoder

Pratik Borhade commented

2023-01-05 06:45:30 +01:00

Added subscriber: @PratikPB2123

Pratik Borhade commented

2023-01-05 06:45:30 +01:00

Hi, thanks for the report. As far as I understand root issue is same as #78171 (Adjust Last Operation: Other changes outside that panel are reverted back automatically)
I'll mark this as duplicate. Feel free to reopen if you think both are different :)

Hi, thanks for the report. As far as I understand root issue is same as #78171 (Adjust Last Operation: Other changes outside that panel are reverted back automatically) I'll mark this as duplicate. Feel free to reopen if you think both are different :)

Pratik Borhade commented

2023-01-05 06:45:48 +01:00

Closed as duplicate of #78171

Pratik Borhade closed this issue

2023-01-05 06:45:48 +01:00

Pratik Borhade referenced this issue

2023-02-20 17:08:55 +01:00

Reset Unit setting in Scence Properties menu #104871

Sign in to join this conversation.