Node Editor: Node pasted at double the mouse position #103739

New Issue

kim yongbin · 2023-01-08T15:43:54+01:00

kim yongbin commented

2023-01-08 15:43:54 +01:00

System Information
Operating system: M1 Mac Mini
Graphics card: M1 GPU

Blender Version
Daily 2022-01-08

Short description of error
Node not pasted at mouse cursor position, but double the position in Node Editors (Both Shader and Geometry).

Exact steps for others to reproduce the error
Copy a node.
Paste the node.
It places not the same place.
I assume the pasted position is mouse position * 2.

**System Information** Operating system: M1 Mac Mini Graphics card: M1 GPU **Blender Version** Daily 2022-01-08 **Short description of error** Node not pasted at mouse cursor position, but double the position in Node Editors (Both Shader and Geometry). **Exact steps for others to reproduce the error** Copy a node. Paste the node. It places not the same place. I assume the pasted position is mouse position * 2.

kim yongbin commented

2023-01-08 15:43:54 +01:00

Added subscriber: @kim-yong-bin

Iliya Katushenock commented

2023-01-08 15:58:41 +01:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2023-01-08 15:58:41 +01:00

Hello, check in new versions, it seems it has already been fixed.

Wouter Stomp commented

2023-01-08 16:26:00 +01:00

Added subscriber: @blenderrocket

Leon Schittek commented

2023-01-08 17:21:43 +01:00

Added subscriber: @lone_noel

Leon Schittek commented

2023-01-08 17:21:43 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Leon Schittek commented

2023-01-08 17:21:44 +01:00

Thanks for the report, @kim-yong-bin!

I can confirm the issue in latest master. It seems like a small error with the handling of the UI scale in 7355d64f2b and can be reproduced by setting the UI scale to something other than 1.0 (macs with retina displays have some scaling by default so there it's visible with a UI scale of 1.0).

The following fixes it for me:

diff --git a/source/blender/editors/space_node/clipboard.cc b/source/blender/editors/space_node/clipboard.cc
index beda081eec8..95c1c25e343 100644
--- a/source/blender/editors/space_node/clipboard.cc
+++ b/source/blender/editors/space_node/clipboard.cc
@@ -257,11 +257,10 @@ static int node_clipboard_paste_exec(bContext *C, wmOperator *op)
     }
     /* DPI factor needs to be removed when computing a View2D offset from drawing rects. */
     center /= clipboard.nodes.size();
-    center /= UI_DPI_FAC;
 
     float2 mouse_location;
     RNA_property_float_get_array(op->ptr, offset_prop, mouse_location);
-    const float2 offset = mouse_location - center;
+    const float2 offset = (mouse_location - center) / UI_DPI_FAC;
 
     for (bNode *new_node : node_map.values()) {
       new_node->locx += offset.x;

Thanks for the report, @kim-yong-bin! I can confirm the issue in latest master. It seems like a small error with the handling of the UI scale in 7355d64f2b and can be reproduced by setting the UI scale to something other than `1.0` (macs with retina displays have some scaling by default so there it's visible with a UI scale of `1.0`). The following fixes it for me: ``` diff --git a/source/blender/editors/space_node/clipboard.cc b/source/blender/editors/space_node/clipboard.cc index beda081eec8..95c1c25e343 100644 --- a/source/blender/editors/space_node/clipboard.cc +++ b/source/blender/editors/space_node/clipboard.cc @@ -257,11 +257,10 @@ static int node_clipboard_paste_exec(bContext *C, wmOperator *op) } /* DPI factor needs to be removed when computing a View2D offset from drawing rects. */ center /= clipboard.nodes.size(); - center /= UI_DPI_FAC; float2 mouse_location; RNA_property_float_get_array(op->ptr, offset_prop, mouse_location); - const float2 offset = mouse_location - center; + const float2 offset = (mouse_location - center) / UI_DPI_FAC; for (bNode *new_node : node_map.values()) { new_node->locx += offset.x; ```

Philipp Oeser commented

2023-01-09 10:14:50 +01:00

Added subscribers: @HooglyBoogly, @lichtwerk

Philipp Oeser commented

2023-01-09 10:14:50 +01:00

CC @HooglyBoogly : mind checking provided fix?

blender-admin commented

2023-01-09 17:37:27 +01:00

This issue was referenced by 891fe70d7f

This issue was referenced by 891fe70d7f0a84573b94379d067f00fb0469b0c2

Hans Goudey commented

2023-01-09 17:38:11 +01:00

Changed status from 'Confirmed' to: 'Resolved'

Hans Goudey closed this issue

2023-01-09 17:38:11 +01:00

Hans Goudey self-assigned this 2023-01-09 17:38:11 +01:00

David Black commented

2023-03-09 02:12:35 +01:00

@HooglyBoogly

Hi, Firstly, thank you Hans for your continued and impressive Blender developments.

Recently encountered your node editor changes. Could the functionality of commit 7355d64f2b be further expanded?

Shift+V = paste at mouse position
Ctrl+Shift+V = paste in place

While there’s benefits of the new paste at mouse position, the former paste in place can also be very useful. For example, previously created 72 flag shaders for a particle system (same shader was duplicated & modified). Later the shaders were refined by creating a group node, since shaders nodes were aligned, pasting in place allowed rapid updating of all 72 shaders.

Kind regards.

@HooglyBoogly Hi, Firstly, thank you Hans for your continued and impressive Blender developments. Recently encountered your node editor changes. Could the functionality of commit 7355d64f2be5 be further expanded? Shift+V = paste at mouse position Ctrl+Shift+V = paste in place While there’s benefits of the new paste at mouse position, the former paste in place can also be very useful. For example, previously created 72 flag shaders for a particle system (same shader was duplicated & modified). Later the shaders were refined by creating a group node, since shaders nodes were aligned, pasting in place allowed rapid updating of all 72 shaders. Kind regards.

Hans Goudey commented

2023-03-21 19:32:16 +01:00

Hi @david_black, I think that is reasonable and I've seen other people mention it. However the best place for that sort of request is rightclickselect, it's much easier for an idea to get momentum there and it makes it easier for developers to gauge the interest.

Hi @david_black, I think that is reasonable and I've seen other people mention it. However the best place for that sort of request is [rightclickselect](https://blender.community/c/rightclickselect/), it's much easier for an idea to get momentum there and it makes it easier for developers to gauge the interest.

David Black commented

2023-03-23 22:39:36 +01:00

Hi @HooglyBoogly, Thank you for your feedback, the idea wasn't so much a request, rather a method of maintaining the current Blender 3.4 (and older) behavior, while also featuring the new Blender 3.5 implementation.

Sign in to join this conversation.

No Label

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Node Editor: Node pasted at double the mouse position #103739