Library override problem for non rigify-generated armature #103796

Closed
opened 2023-01-11 05:33:28 +01:00 by johan tri handoyo · 8 comments

System Information
Operating system: Windows 10 or Ubuntu 20.04
Graphics card: GTX 1080

Blender Version
Broken: (3.3.2)
Worked: -

Short Description
When i try to link and library override armature that is not generated in rigify or basic human metarig, the datablock doesn't automatically override, so i have to manually set it up. This will cause problems, for example when duplicating the same props.

image.png

Exact steps for others to reproduce the error

  • Open default scene and link the human collection
  • make it library override.
    As you can see in the screenshot, the status or the icon of the data is different, the metarig is still in direct link to the master file.

override problem for non rigify.blend

**System Information** Operating system: Windows 10 or Ubuntu 20.04 Graphics card: GTX 1080 **Blender Version** Broken: (3.3.2) Worked: - **Short Description** When i try to link and library override armature that is not generated in rigify or basic human metarig, the datablock doesn't automatically override, so i have to manually set it up. This will cause problems, for example when duplicating the same props. ![image.png](https://archive.blender.org/developer/F14138951/image.png) **Exact steps for others to reproduce the error** - Open default scene and link the human collection - make it library override. As you can see in the screenshot, the status or the icon of the data is different, the metarig is still in direct link to the master file. [override problem for non rigify.blend](https://archive.blender.org/developer/F14138960/override_problem_for_non_rigify.blend)

Added subscriber: @JohanTriHandoyo

Added subscriber: @JohanTriHandoyo
Member

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Member

When i try to link and library override armature that is not generated in rigify or basic human metarig, the datablock doesn't automatically override, so i have to manually set it up.

Hi, thanks for the report. This behavior is even noticeable with default armature object. Not sure whether this is a bug (behavior is same in older version too)
I think only icon is not changing? Meta-rig doesn't appear as linked to original file

> When i try to link and library override armature that is not generated in rigify or basic human metarig, the datablock doesn't automatically override, so i have to manually set it up. Hi, thanks for the report. This behavior is even noticeable with default armature object. Not sure whether this is a bug (behavior is same in older version too) I think only icon is not changing? Meta-rig doesn't appear as linked to original file
Member

The interesting bit is probably the fact that the rig object has more users:

>>> bpy.data.user_map(subset=(bpy.data.objects['rig'], ))
{bpy.data.objects['rig']: {bpy.data.scenes['Scene'], bpy.data.collections['human'], bpy.data.objects['rig'], bpy.data.armatures['metarig'], bpy.data.armatures['rig']}}

>>> bpy.data.user_map(subset=(bpy.data.objects['metarig'], ))
{bpy.data.objects['metarig']: {bpy.data.scenes['Scene'], bpy.data.collections['human']}}

Why is this so?

Because the rig armature has drivers relating to the rig object.
In the case of the metarig armature, this does not have drivers relating to the metarig object.

image

So if you have anything for the metarig armature as well that makes it depend on the metarig object, e.g. by blindly driving bpy.data.armatures["metarig"].show_names by bpy.data.objects["metarig"].show_in_front (this is just a stupid example), you will equally get the drivers for the metarig armature:

image

When you now save, link and override (like in the report description steps), the metarig armature will receive its override automatically as well

image

I assume this is all expected behavior @dr.sybren / @mont29 ?
Or should we blindly put overrides down the whole hierarchy regardless of actual dependencies? (dont think so)

The interesting bit is probably the fact that the rig object has more users: ``` >>> bpy.data.user_map(subset=(bpy.data.objects['rig'], )) {bpy.data.objects['rig']: {bpy.data.scenes['Scene'], bpy.data.collections['human'], bpy.data.objects['rig'], bpy.data.armatures['metarig'], bpy.data.armatures['rig']}} >>> bpy.data.user_map(subset=(bpy.data.objects['metarig'], )) {bpy.data.objects['metarig']: {bpy.data.scenes['Scene'], bpy.data.collections['human']}} ``` Why is this so? Because the rig **armature** has drivers relating to the rig **object**. In the case of the metarig armature, this does not have drivers relating to the metarig object. ![image](/attachments/f6aa58de-48b5-41ea-bca3-ec7fa0165aa7) So if you have anything for the metarig **armature** as well that makes it depend on the metarig **object**, e.g. by blindly driving `bpy.data.armatures["metarig"].show_names` by `bpy.data.objects["metarig"].show_in_front` (this is just a stupid example), you will equally get the drivers for the metarig armature: ![image](/attachments/f0dd3560-4b53-4f26-9e86-1481dedfc324) When you now save, link and override (like in the report description steps), the metarig armature will receive its override automatically as well ![image](/attachments/52861af0-ea44-4289-b340-9035aed64124) I assume this is all expected behavior @dr.sybren / @mont29 ? Or should we blindly put overrides down the whole hierarchy regardless of actual dependencies? (dont think so)

This is indeed expected behavior, obdata in general (Armature, Mesh, etc.) are only overridden if they have relationships to other overridden data (like other objects).

I am not sure what problems this may cause though? Can't say I understand this statement:

This will cause problems, for example when duplicating the same props.

This is indeed expected behavior, obdata in general (Armature, Mesh, etc.) are only overridden if they have relationships to other overridden data (like other objects). I am not sure what problems this may cause though? Can't say I understand this statement: > This will cause problems, for example when duplicating the same props.
Member

I am not sure what problems this may cause though? Can't say I understand this statement:

This will cause problems, for example when duplicating the same props.

@JohanTriHandoyo : could you elaborate?

> I am not sure what problems this may cause though? Can't say I understand this statement: > > This will cause problems, for example when duplicating the same props. @JohanTriHandoyo : could you elaborate?
Philipp Oeser added
Status
Needs Information from User
and removed
Status
Needs Info from Developers
labels 2023-03-23 09:27:01 +01:00

Hi, Apologize for confusion. The first time i found this issue is when i was trying to duplicate the same prop for my scene and then lib override it. To my surprise, the problem didn't occur on the generated rigify character. So that's why the example i use here is rigify's metarig and generated one, as a comparison.

Hi, Apologize for confusion. The first time i found this issue is when i was trying to duplicate the same prop for my scene and then lib override it. To my surprise, the problem didn't occur on the generated rigify character. So that's why the example i use here is rigify's metarig and generated one, as a comparison.
Member

So if I understand correctly, the duplication does not really cause additional problems, it is basically the same as un-duplicated, right?

If that is the case, and the current behavior is indeed expected behavior (for the reasons demonstrated here), I think we have to close this report.

Of course feel free to comment again if this is a misunderstanding, we can always reopen in such case.

So if I understand correctly, the duplication does not really cause additional problems, it is basically the same as un-duplicated, right? If that is the case, and the current behavior is indeed expected behavior (for the reasons demonstrated here), I think we have to close this report. Of course feel free to comment again if this is a misunderstanding, we can always reopen in such case.
Blender Bot added
Status
Archived
and removed
Status
Needs Information from User
labels 2023-03-31 14:26:51 +02:00
Sign in to join this conversation.
No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
No Milestone
No project
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#103796
No description provided.