output_node.inputs.new() crash blender #103824

New Issue

bar · 2023-01-12T11:40:30+01:00

bar commented

2023-01-12 11:40:30 +01:00

System Information
Operating system: Linux-5.15.0-57-generic-x86_64-with-glibc2.35 64 Bits
Graphics card: NVIDIA GeForce RTX 3080 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 515.86.01

Blender Version
Broken: version: 3.4.1, branch: blender-v3.4-release, commit date: 2022-12-19 17:00, hash: 55485cb379
Worked: (newest version of Blender that worked as expected)

Short description of error
input = output_node.inputs.new(type = 'RGBA',name = 'bob_sfog',identifier='bob_sfog')
crash blender

Exact steps for others to reproduce the error
Open blender
execute line by line this srcript:

scene = bpy.data.scenes[0]
scene.use_nodes = True
output_node = scene.node_tree.nodes.new(type='CompositorNodeOutputFile')
output_node.inputs.clear()
input = output_node.inputs.new(type = 'RGBA',name = 'bob_sfog',identifier='bob_sfog')

**System Information** Operating system: Linux-5.15.0-57-generic-x86_64-with-glibc2.35 64 Bits Graphics card: NVIDIA GeForce RTX 3080 Laptop GPU/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 515.86.01 **Blender Version** Broken: version: 3.4.1, branch: blender-v3.4-release, commit date: 2022-12-19 17:00, hash: `55485cb379` Worked: (newest version of Blender that worked as expected) **Short description of error** input = output_node.inputs.new(type = 'RGBA',name = 'bob_sfog',identifier='bob_sfog') crash blender **Exact steps for others to reproduce the error** Open blender execute line by line this srcript: ``` scene = bpy.data.scenes[0] scene.use_nodes = True output_node = scene.node_tree.nodes.new(type='CompositorNodeOutputFile') output_node.inputs.clear() input = output_node.inputs.new(type = 'RGBA',name = 'bob_sfog',identifier='bob_sfog') ```

bar commented

2023-01-12 11:40:30 +01:00

Added subscriber: @barakooda

bar changed title from ~~output_node.inputs.new crash blender~~ to output_node.inputs.new() crash blender

2023-01-12 11:42:24 +01:00

Iliya Katushenock commented

2023-01-12 13:02:37 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Philipp Oeser commented

2023-01-26 13:40:16 +01:00

Added subscriber: @lichtwerk

Philipp Oeser commented

2023-01-26 13:40:16 +01:00

Think adding inputs to such node is not really expected to work, the crash is a regression though, checking...

bar commented

2023-01-26 13:49:25 +01:00

Not sure what you mean.
Output node support multi inputs either outputing to multi layer exr or multi files.
The ui support it.

How will you add inputs then in proper
Python way ? (Not realying on context)

Not sure what you mean. Output node support multi inputs either outputing to multi layer exr or multi files. The ui support it. How will you add inputs then in proper Python way ? (Not realying on context)

Iliya Katushenock commented

2023-01-26 13:53:55 +01:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2023-01-26 13:53:55 +01:00

This issue was covered in another meeting report. You can't just create a socket. Node must have a method to do this, or you're just breaking it (#103150 (Runtime error on trying to create new input/output to node groups via python)).

Philipp Oeser commented

2023-01-27 10:33:29 +01:00

Hard to bisect (since in a lite build it would still crash, even if it created the socket, shortly after), in an case, behavior changed between b9123b806f (good) and e2e4c1daaa (bad)

In any case, the "proper" way to do it would probably be to use these two (instead of node.inputs.new() / node.inputs.clear()):

bpy.ops.node.output_file_add_socket()
bpy.ops.node.output_file_remove_active_socket()

Hard to bisect (since in a lite build it would still crash, even if it created the socket, shortly after), in an case, behavior changed between b9123b806f (good) and e2e4c1daaa (bad) In any case, the "proper" way to do it would probably be to use these two (instead of `node.inputs.new()` / `node.inputs.clear()`): ``` bpy.ops.node.output_file_add_socket() bpy.ops.node.output_file_remove_active_socket() ```

Philipp Oeser commented

2023-01-27 10:40:22 +01:00

Changed status from 'Confirmed' to: 'Needs User Info'

Philipp Oeser commented

2023-01-27 10:40:22 +01:00

Hold on, you dont even need to use the operator, this is exposed in the API like this

import bpy

scene = bpy.data.scenes[0]
scene.use_nodes = True
output_node = scene.node_tree.nodes.new(type='CompositorNodeOutputFile')

output_node.file_slots.clear()
output_node.file_slots.new("bob_sfog")

@barakooda : does this work for you?

Hold on, you dont even need to use the operator, this is exposed in the API like this ``` import bpy scene = bpy.data.scenes[0] scene.use_nodes = True output_node = scene.node_tree.nodes.new(type='CompositorNodeOutputFile') output_node.file_slots.clear() output_node.file_slots.new("bob_sfog") ``` @barakooda : does this work for you?

Iliya Katushenock commented

2023-01-27 10:41:52 +01:00

I think crash needs to be investigated as a problem in itself.

bar commented

2023-01-27 10:49:04 +01:00

In #103824#1480326, @lichtwerk wrote:
Hold on, you dont even need to use the operator, this is exposed in the API like this
import bpy

scene = bpy.data.scenes[0]
scene.use_nodes = True
output_node = scene.node_tree.nodes.new(type='CompositorNodeOutputFile')

output_node.file_slots.clear()
output_node.file_slots.new("bob_sfog")
@barakooda : does this work for you?

Hi philip,
Thank you for the update,

Sorry but i dont see how using the
"ops" is a proper pythonic way.

Programing wise, we prefer to use objects, manipulate data directly and not thru context manager.

For some cases the "ops" is source of all evil when you have a large code base.
The performance hit in some cases can be huge.

Please, hear our pain 💔,
Keep up the great work !

Thank you !

> In #103824#1480326, @lichtwerk wrote: > Hold on, you dont even need to use the operator, this is exposed in the API like this > > > ``` > import bpy > > scene = bpy.data.scenes[0] > scene.use_nodes = True > output_node = scene.node_tree.nodes.new(type='CompositorNodeOutputFile') > > output_node.file_slots.clear() > output_node.file_slots.new("bob_sfog") > ``` > > @barakooda : does this work for you? Hi philip, Thank you for the update, Sorry but i dont see how using the "ops" is a proper pythonic way. Programing wise, we prefer to use objects, manipulate data directly and not thru context manager. For some cases the "ops" is source of all evil when you have a large code base. The performance hit in some cases can be huge. Please, hear our pain 💔, Keep up the great work ! Thank you !

bar commented

2023-01-27 11:11:31 +01:00

In #103824#1480326, @lichtwerk wrote:
Hold on, you dont even need to use the operator, this is exposed in the API like this
import bpy

scene = bpy.data.scenes[0]
scene.use_nodes = True
output_node = scene.node_tree.nodes.new(type='CompositorNodeOutputFile')

output_node.file_slots.clear()
output_node.file_slots.new("bob_sfog")
@barakooda : does this work for you?

Will check next week.
Thank you.

> In #103824#1480326, @lichtwerk wrote: > Hold on, you dont even need to use the operator, this is exposed in the API like this > > > ``` > import bpy > > scene = bpy.data.scenes[0] > scene.use_nodes = True > output_node = scene.node_tree.nodes.new(type='CompositorNodeOutputFile') > > output_node.file_slots.clear() > output_node.file_slots.new("bob_sfog") > ``` > > @barakooda : does this work for you? Will check next week. Thank you.

bar commented

2023-01-29 08:30:34 +01:00

Thanks @lichtwerk
Its works.

Off topic of this thread.
for the multi channel EXR file case it will be good to add this inputs types:
UINT32 : 1 channel,2 channel,rgb,rgba
HALF-FLOAT :1 channel,2 channel,rgb,rgba
FLOAT : 1 channel,2 channel,rgb,rgba

Then,
I think we it will be good start to utilize the EXR container as it meant to be used.

will link this comment in relevant thread.

Thanks again.

Thanks @lichtwerk Its works. Off topic of this thread. for the multi channel EXR file case it will be good to add this inputs types: UINT32 : 1 channel,2 channel,rgb,rgba HALF-FLOAT :1 channel,2 channel,rgb,rgba FLOAT : 1 channel,2 channel,rgb,rgba Then, I think we it will be good start to utilize the EXR container as it meant to be used. will link this comment in relevant thread. Thanks again.

😕 1

Philipp Oeser removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

output_node.inputs.new() crash blender #103824