Regression: Click-Drag to select channels in Graph Editor no longer working #104026

New Issue

Christoph Lendenfeld · 2023-01-20T13:59:47+01:00

2023-01-20 13:59:47 +01:00

System Information
Operating system: Linux
Graphics card: RTX 3070

Blender Version
Broken: 3.2 - latest
Worked: 3.1
Caused by 4d0f846b93

Short description of error
Up until version 3.1 of Blender you could click-drag in the channels from the graph editor/dope sheet to select multiple channels.
From 3.2 onwards the box select never triggers and you can only select 1 channel.

Looking at the code, the keymappings are still there, presumably the event just gets caught before it hits the operator.

Exact steps for others to reproduce the error
Based on the default startup or an attached .blend file (as simple as possible).

channel_drag.blend

Open the attached blend file
try box selecting the channels in the graph editor/dope sheet

**System Information** Operating system: Linux Graphics card: RTX 3070 **Blender Version** Broken: 3.2 - latest Worked: 3.1 Caused by 4d0f846b93 **Short description of error** Up until version 3.1 of Blender you could click-drag in the channels from the graph editor/dope sheet to select multiple channels. From 3.2 onwards the box select never triggers and you can only select 1 channel. Looking at the code, the keymappings are still there, presumably the event just gets caught before it hits the operator. **Exact steps for others to reproduce the error** Based on the default startup or an attached .blend file (as simple as possible). [channel_drag.blend](https://archive.blender.org/developer/F14179299/channel_drag.blend) * Open the attached blend file * try box selecting the channels in the graph editor/dope sheet

Christoph Lendenfeld commented

2023-01-20 13:59:47 +01:00

Added subscriber: @ChrisLend

Christoph Lendenfeld self-assigned this 2023-01-20 14:00:12 +01:00

Christoph Lendenfeld commented

2023-01-20 14:19:58 +01:00

Added subscriber: @ideasman42

Christoph Lendenfeld commented

2023-01-20 14:19:58 +01:00

@ideasman42 I am not 100% sure but I think this stems from the change from EVT_TWEAK_L to LEFTMOUSE in the blender_default.py keymap.

was there anything inherent to EVT_TWEAK_L that made it execute before LEFTMOUSE ?

@ideasman42 I am not 100% sure but I think this stems from the change from `EVT_TWEAK_L` to `LEFTMOUSE` in the `blender_default.py` keymap. was there anything inherent to `EVT_TWEAK_L` that made it execute before `LEFTMOUSE` ?

Pratik Borhade commented

2023-01-20 14:24:29 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'

Pratik Borhade commented

2023-01-20 14:24:34 +01:00

Added subscriber: @PratikPB2123

Christoph Lendenfeld commented

2023-01-20 15:07:50 +01:00

I found a potential fix by changing the keymap for anim.channels_click from PRESS to CLICK

I found a potential fix by changing the keymap for `anim.channels_click` from `PRESS` to `CLICK`

Campbell Barton commented

2023-01-23 10:35:12 +01:00

In #104026#1477278, @ChrisLend wrote:
@ideasman42 I am not 100% sure but I think this stems from the change from EVT_TWEAK_L to LEFTMOUSE in the blender_default.py keymap.

was there anything inherent to EVT_TWEAK_L that made it execute before LEFTMOUSE ?

Yes it would have, previously handling the PRESS did not suppress the TWEAK event (so selection could optionally tweak afterwards). There were quite a few cases where this bit us, as far as I knew they were all handled. This one slipped through, your fix looks fine (replied).

> In #104026#1477278, @ChrisLend wrote: > @ideasman42 I am not 100% sure but I think this stems from the change from `EVT_TWEAK_L` to `LEFTMOUSE` in the `blender_default.py` keymap. > > was there anything inherent to `EVT_TWEAK_L` that made it execute before `LEFTMOUSE` ? Yes it would have, previously handling the PRESS did not suppress the TWEAK event (so selection could optionally tweak afterwards). There were quite a few cases where this bit us, as far as I knew they were all handled. This one slipped through, your fix looks fine (replied).

Christoph Lendenfeld referenced a pull request that will close this issue

2023-02-09 12:20:29 +01:00

Fix #104026: Click-Drag to select graph editor channels no longer working #104505

Christoph Lendenfeld added a new dependency 2023-02-09 12:22:30 +01:00

#104505 Fix #104026: Click-Drag to select graph editor channels no longer working

Philipp Oeser removed the