blender
/
blender
133
398
Fork 579
Code Issues 6.3k Pull Requests 746 Projects 19 Wiki Activity

Regression: screw modifier effect is invisible in edit mode (wireframe display) #104188

New Issue
Closed
opened 2023-01-27 20:59:57 +01:00 by Recep · 14 comments
Recep commented 2023-01-27 20:59:57 +01:00
Copy Link

Operating system: Windows 11 Pro
Graphics card: Asus Tuf RX 6800 , Rtx 3060
i5 12400F , Amd threatripper 1920x

Blender Versions
Broken: 3.4.1
Worked: 3.3
Caused by 25237d2625

Short Description
In wireframe display mode, screw modifier effect is invisible in object is in edit mode

Steps to Reproduce

  • Open default scene
  • Add screw modifier
  • Switch to edit mode
  • Select Wireframe from viewport shading options
    problem.png
Operating system: Windows 11 Pro Graphics card: Asus Tuf RX 6800 , Rtx 3060 i5 12400F , Amd threatripper 1920x **Blender Versions** Broken: 3.4.1 Worked: 3.3 Caused by 25237d2625 **Short Description** In wireframe display mode, screw modifier effect is invisible in object is in edit mode **Steps to Reproduce** - Open default scene - Add screw modifier - Switch to edit mode - Select Wireframe from viewport shading options ![problem.png](https://archive.blender.org/developer/F14204466/problem.png)
Recep commented 2023-01-27 20:59:57 +01:00
Author
Copy Link

Added subscriber: @Recsoft

Added subscriber: @Recsoft
Pratik Borhade commented 2023-01-30 12:17:52 +01:00
Member
Copy Link

Added subscriber: @PratikPB2123

Added subscriber: @PratikPB2123
Pratik Borhade commented 2023-01-30 12:17:52 +01:00
Member
Copy Link

Changed status from 'Needs Triage' to: 'Needs User Info'

Changed status from 'Needs Triage' to: 'Needs User Info'
Pratik Borhade commented 2023-01-30 12:17:52 +01:00
Member
Copy Link

Hi, thanks for the report. I'm not able to repro this locally. Does this happen in particular .blend file? If so, can you share it?
Please also test in recent 3.5 build: https://builder.blender.org/download/daily/

Hi, thanks for the report. I'm not able to repro this locally. Does this happen in particular .blend file? If so, can you share it? Please also test in recent 3.5 build: https://builder.blender.org/download/daily/
Pratik Borhade commented 2023-01-30 12:20:33 +01:00
Member
Copy Link

Changed status from 'Needs User Info' to: 'Confirmed'

Changed status from 'Needs User Info' to: 'Confirmed'
Pratik Borhade commented 2023-01-30 12:20:33 +01:00
Member
Copy Link

Sorry, I can repro actually.

Sorry, I can repro actually.
Pratik Borhade changed title from Blender 3.4.1 screw modifier invisible problem to Regression: screw modifier effect is invisible in edit mode (wireframe display) 2023-01-30 12:24:27 +01:00
Pratik Borhade commented 2023-01-30 12:55:40 +01:00
Member
Copy Link

Added subscriber: @HooglyBoogly

Added subscriber: @HooglyBoogly
Pratik Borhade commented 2023-01-30 12:55:40 +01:00
Member
Copy Link

Caused by 25237d2625
@HooglyBoogly ^

Caused by 25237d2625 @HooglyBoogly ^
Recep commented 2023-01-30 13:37:57 +01:00
Author
Copy Link

3.5 has same problem

problem.blend

3.5 has same problem [problem.blend](https://archive.blender.org/developer/F14213604/problem.blend)
Hans Goudey self-assigned this 2023-02-02 16:01:57 +01:00
Hans Goudey commented 2023-02-02 16:01:57 +01:00
Member
Copy Link

Thanks for the patch and for the bisect.

Thanks for the patch and for the bisect.
Hans Goudey removed their assignment 2023-02-03 20:47:25 +01:00
Hans Goudey commented 2023-02-03 20:47:25 +01:00
Member
Copy Link

Hmm, I can't reproduce the difference in the file above. The file looks like this in 3.3:

{F14238051 size=full}

However, based on the code and the design as I understand it, this is the behavior I expect actually. The screw modifier has no handling of original indices, which is required for the edge to be visible. Previously the original index was set to zero, which was wrong, but it happened to make the edge show up.
Maybe I'm misunderstanding the design or the intentions of the code. But unless this is a more widespread issue, I'm not sure it makes sense to spend time fixing the screw modifier original index handling.

Hmm, I can't reproduce the difference in the file above. The file looks like this in 3.3: {[F14238051](https://archive.blender.org/developer/F14238051/image.png) size=full} However, based on the code and the design as I understand it, this is the behavior I expect actually. The screw modifier has no handling of original indices, which is required for the edge to be visible. Previously the original index was set to zero, which was wrong, but it happened to make the edge show up. Maybe I'm misunderstanding the design or the intentions of the code. But unless this is a more widespread issue, I'm not sure it makes sense to spend time fixing the screw modifier original index handling.
Pratik Borhade commented 2023-02-04 04:10:43 +01:00
Member
Copy Link

@HooglyBoogly, this issue would show up in wireframe mode

3.3.2 3.5
image.png image.png
@HooglyBoogly, this issue would show up in [wireframe mode ](https://docs.blender.org/manual/en/latest/editors/3dview/display/shading.html#wireframe) | 3.3.2 | 3.5 | | -- | -- | | ![image.png](https://archive.blender.org/developer/F14239921/image.png) | ![image.png](https://archive.blender.org/developer/F14239923/image.png) |
Hans Goudey self-assigned this 2023-02-04 04:12:39 +01:00
Hans Goudey commented 2023-02-04 04:12:39 +01:00
Member
Copy Link

Huh, I even noticed that but didn't put together that was the problem. A bit spacey.. Thanks, I'll take another look. That seems bad enough that it would be worth fixing even if it ended up looking like a "new feature' in the code.

Huh, I even noticed that but didn't put together that was the problem. A bit spacey.. Thanks, I'll take another look. That seems bad enough that it would be worth fixing even if it ended up looking like a "new feature' in the code.
Philipp Oeser removed the
Interest
Modeling
 label 2023-02-09 15:27:03 +01:00
Brecht Van Lommel added this to the 3.5 milestone 2023-02-15 10:26:16 +01:00
Hans Goudey commented 2023-02-17 22:20:02 +01:00
Member
Copy Link

Okay, looking into this further, I do think this was working "by mistake" in previous versions. There doesn't seem to be a design internally for this, since original indices were set to 0, which is wrong because the original edge for all result edges isn't the first, and there is no original face.

diff --git a/source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines.cc b/source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines.cc
index d7625cb81d4..49bcbd8989f 100644
--- a/source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines.cc
+++ b/source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines.cc
@@ -59,6 +59,7 @@ static void extract_lines_iter_poly_mesh(const MeshRenderData *mr,
   /* Using poly & loop iterator would complicate accessing the adjacent loop. */
   const MLoop *mloop = mr->mloop;
   const int *e_origindex = (mr->edit_bmesh) ? mr->e_origindex : nullptr;
+  e_origindex = nullptr;
   if (mr->use_hide || (e_origindex != nullptr)) {
     const int ml_index_last = mp->loopstart + (mp->totloop - 1);
     int ml_index = ml_index_last, ml_index_next = mp->loopstart;
@@ -110,6 +111,7 @@ static void extract_lines_iter_ledge_mesh(const MeshRenderData *mr,
   const int l_index_offset = mr->edge_len + ledge_index;
   const int e_index = mr->ledges[ledge_index];
   const int *e_origindex = (mr->edit_bmesh) ? mr->e_origindex : nullptr;
+  e_origindex = nullptr;
   if (!((mr->use_hide && mr->hide_edge && mr->hide_edge[med - mr->medge]) ||
         ((e_origindex) && (e_origindex[e_index] == ORIGINDEX_NONE)))) {
     const int l_index = mr->loop_len + ledge_index * 2;

image

As a workaround, I'll just remove the layers in the modifier's result mesh. This isn't great design, but for the screw modifier I'd rather just have it working as before than get into a design discussion which should be had in the context of newer features like geometry nodes.

Okay, looking into this further, I do think this was working "by mistake" in previous versions. There doesn't seem to be a design internally for this, since original indices were set to 0, which is wrong because the original edge for all result edges isn't the first, and there is no original face. --- ```diff diff --git a/source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines.cc b/source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines.cc index d7625cb81d4..49bcbd8989f 100644 --- a/source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines.cc +++ b/source/blender/draw/intern/mesh_extractors/extract_mesh_ibo_lines.cc @@ -59,6 +59,7 @@ static void extract_lines_iter_poly_mesh(const MeshRenderData *mr, /* Using poly & loop iterator would complicate accessing the adjacent loop. */ const MLoop *mloop = mr->mloop; const int *e_origindex = (mr->edit_bmesh) ? mr->e_origindex : nullptr; + e_origindex = nullptr; if (mr->use_hide || (e_origindex != nullptr)) { const int ml_index_last = mp->loopstart + (mp->totloop - 1); int ml_index = ml_index_last, ml_index_next = mp->loopstart; @@ -110,6 +111,7 @@ static void extract_lines_iter_ledge_mesh(const MeshRenderData *mr, const int l_index_offset = mr->edge_len + ledge_index; const int e_index = mr->ledges[ledge_index]; const int *e_origindex = (mr->edit_bmesh) ? mr->e_origindex : nullptr; + e_origindex = nullptr; if (!((mr->use_hide && mr->hide_edge && mr->hide_edge[med - mr->medge]) || ((e_origindex) && (e_origindex[e_index] == ORIGINDEX_NONE)))) { const int l_index = mr->loop_len + ledge_index * 2; ``` ![image](/attachments/1ba00e5e-27bf-4e03-974d-c8d60e2fde7a) --- As a workaround, I'll just remove the layers in the modifier's result mesh. This isn't great design, but for the screw modifier I'd rather just have it working as before than get into a design discussion which should be had in the context of newer features like geometry nodes.
image.png
138 KiB
Blender Bot added
Status
Resolved
 and removed
Status
Confirmed
 labels 2023-02-17 22:26:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
brush-assets-project
universal-scene-description
fix-121021
blender-v4.1-release
blender-v3.3-release
blender-v3.6-release
blender-v3.6-temp_wmoss_animrig_public
temp-sculpt-dyntopo
gpencil-next
anim/animation-id-113594
blender-v4.0-release
blender-projects-basics
bridge-curves
sculpt-blender
asset-browser-frontend-split
asset-shelf
tmp-usd-python-mtl
tmp-usd-3.6
blender-v3.5-release
blender-v2.93-release
realtime-clock
sculpt-dev
bevelv2
xr-dev
v4.1.1
v3.6.11
v3.3.18
v4.1.0
v3.3.17
v3.6.10
v3.6.9
v3.3.16
v3.6.8
v3.6.7
v3.3.14
v4.0.2
v4.0.1
v4.0.0
v3.6.5
v3.3.12
v3.6.4
v3.6.3
v3.3.11
v3.6.2
v3.3.10
v3.6.1
v3.3.9
v3.6.0
v3.3.8
v3.3.7
v2.93.18
v3.5.1
v3.3.6
v2.93.17
v3.5.0
v2.93.16
v3.3.5
v3.3.4
v2.93.15
v2.93.14
v3.3.3
v2.93.13
v2.93.12
v3.4.1
v3.3.2
v3.4.0
v3.3.1
v2.93.11
v3.3.0
v3.2.2
v2.93.10
v3.2.1
v3.2.0
v2.83.20
v2.93.9
v3.1.2
v3.1.1
v3.1.0
v2.83.19
v2.93.8
v3.0.1
v2.93.7
v3.0.0
v2.93.6
v2.93.5
v2.83.18
v2.93.4
v2.93.3
v2.83.17
v2.93.2
v2.93.1
v2.83.16
v2.93.0
v2.83.15
v2.83.14
v2.83.13
v2.92.0
v2.83.12
v2.91.2
v2.83.10
v2.91.0
v2.83.9
v2.83.8
v2.83.7
v2.90.1
v2.83.6.1
v2.83.6
v2.90.0
v2.83.5
v2.83.4
v2.83.3
v2.83.2
v2.83.1
v2.83
v2.82a
v2.82
v2.81a
v2.81
v2.80
v2.80-rc3
v2.80-rc2
v2.80-rc1
v2.79b
v2.79a
v2.79
v2.79-rc2
v2.79-rc1
v2.78c
v2.78b
v2.78a
v2.78
v2.78-rc2
v2.78-rc1
v2.77a
v2.77
v2.77-rc2
v2.77-rc1
v2.76b
v2.76a
v2.76
v2.76-rc3
v2.76-rc2
v2.76-rc1
v2.75a
v2.75
v2.75-rc2
v2.75-rc1
v2.74
v2.74-rc4
v2.74-rc3
v2.74-rc2
v2.74-rc1
v2.73a
v2.73
v2.73-rc1
v2.72b
2.72b
v2.72a
v2.72
v2.72-rc1
v2.71
v2.71-rc2
v2.71-rc1
v2.70a
v2.70
v2.70-rc2
v2.70-rc
v2.69
v2.68a
v2.68
v2.67b
v2.67a
v2.67
v2.66a
v2.66
v2.65a
v2.65
v2.64a
v2.64
v2.63a
v2.63
v2.61
v2.60a
v2.60
v2.59
v2.58a
v2.58
v2.57b
v2.57a
v2.57
v2.56a
v2.56
v2.55
v2.54
v2.53
v2.52
v2.51
v2.50
v2.49b
v2.49a
v2.49
v2.48a
v2.48
v2.47
v2.46
v2.45
v2.44
v2.43
v2.42a
v2.42
v2.41
v2.40
v2.37a
v2.37
v2.36
v2.35a
v2.35
v2.34
v2.33a
v2.33
v2.32
v2.31a
v2.31
v2.30
v2.28c
v2.28a
v2.28
v2.27
v2.26
v2.25
Labels
Clear labels   
Interest
Alembic

  
Interest
Animation & Rigging

  
Interest
Asset Browser

  
Interest
Asset Browser Project Overview

  
Interest
Audio

  
Interest
Automated Testing

  
Interest
Blender Asset Bundle

  
Interest
BlendFile

  
Interest
Collada

  
Interest
Compatibility
This issue affects/is about backward or forward compatibility

  
Interest
Compositing

  
Interest
Core

  
Interest
Cycles

  
Interest
Dependency Graph

  
Interest
Development Management

  
Interest
EEVEE

  
Interest
EEVEE & Viewport

  
Interest
Freestyle

  
Interest
Geometry Nodes

  
Interest
Grease Pencil

  
Interest
ID Management

  
Interest
Images & Movies

  
Interest
Import Export

  
Interest
Line Art

  
Interest
Masking

  
Interest
Metal

  
Interest
Modeling

  
Interest
Modifiers

  
Interest
Motion Tracking

  
Interest
Nodes & Physics

  
Interest
OpenGL

  
Interest
Overlay

  
Interest
Overrides

  
Interest
Performance

  
Interest
Physics

  
Interest
Pipeline, Assets & IO

  
Interest
Platforms, Builds & Tests

  
Interest
Python API

  
Interest
Render & Cycles

  
Interest
Render Pipeline

  
Interest
Sculpt, Paint & Texture

  
Interest
Text Editor

  
Interest
Translations

  
Interest
Triaging

  
Interest
Undo

  
Interest
USD

  
Interest
User Interface

  
Interest
UV Editing

  
Interest
VFX & Video

  
Interest
Video Sequencer

  
Interest
Virtual Reality

  
Interest
Vulkan

  
Interest
Wayland
Issues relating to Wayland windowing support.

  
Interest
Workbench

  
Interest: X11

Issues relating to Xorg/X11 support.

  
Legacy
Blender 2.8 Project

  
Legacy
Milestone 1: Basic, Local Asset Browser

  
Legacy
OpenGL Error

  
Meta
Good First Issue

  
Meta
Papercut

  
Meta
Retrospective

  
Meta
Security
Issues relating to security: https://wiki.blender.org/wiki/Process/Vulnerability_Reports

  
Module
Animation & Rigging

  
Module
Core

  
Module
Development Management

  
Module
EEVEE & Viewport

  
Module
Grease Pencil

  
Module
Modeling

  
Module
Nodes & Physics

  
Module
Pipeline, Assets & IO

  
Module
Platforms, Builds & Tests

  
Module
Python API

  
Module
Render & Cycles

  
Module
Sculpt, Paint & Texture

  
Module
Triaging

  
Module
User Interface

  
Module
VFX & Video

  
Platform
FreeBSD

  
Platform
Linux

  
Platform
macOS

  
Platform
Windows

  
Priority
High

  
Priority
Low

  
Priority
Normal

  
Priority
Unbreak Now!

  
Status
Archived

  
Status
Confirmed

  
Status
Duplicate

  
Status
Needs Info from Developers

  
Status
Needs Information from User

  
Status
Needs Triage

  
Status
Resolved

  
Type
Bug

  
Type
Design

  
Type
Known Issue

  
Type
Patch

  
Type
Report

  
Type
To Do

No Label
Interest
Alembic
Interest
Animation & Rigging
Interest
Asset Browser
Interest
Asset Browser Project Overview
Interest
Audio
Interest
Automated Testing
Interest
Blender Asset Bundle
Interest
BlendFile
Interest
Collada
Interest
Compatibility
Interest
Compositing
Interest
Core
Interest
Cycles
Interest
Dependency Graph
Interest
Development Management
Interest
EEVEE
Interest
EEVEE & Viewport
Interest
Freestyle
Interest
Geometry Nodes
Interest
Grease Pencil
Interest
ID Management
Interest
Images & Movies
Interest
Import Export
Interest
Line Art
Interest
Masking
Interest
Metal
Interest
Modeling
Interest
Modifiers
Interest
Motion Tracking
Interest
Nodes & Physics
Interest
OpenGL
Interest
Overlay
Interest
Overrides
Interest
Performance
Interest
Physics
Interest
Pipeline, Assets & IO
Interest
Platforms, Builds & Tests
Interest
Python API
Interest
Render & Cycles
Interest
Render Pipeline
Interest
Sculpt, Paint & Texture
Interest
Text Editor
Interest
Translations
Interest
Triaging
Interest
Undo
Interest
USD
Interest
User Interface
Interest
UV Editing
Interest
VFX & Video
Interest
Video Sequencer
Interest
Virtual Reality
Interest
Vulkan
Interest
Wayland
Interest
Workbench
Interest: X11
Legacy
Blender 2.8 Project
Legacy
Milestone 1: Basic, Local Asset Browser
Legacy
OpenGL Error
Meta
Good First Issue
Meta
Papercut
Meta
Retrospective
Meta
Security
Module
Animation & Rigging
Module
Core
Module
Development Management
Module
EEVEE & Viewport
Module
Grease Pencil
Module
Modeling
Module
Nodes & Physics
Module
Pipeline, Assets & IO
Module
Platforms, Builds & Tests
Module
Python API
Module
Render & Cycles
Module
Sculpt, Paint & Texture
Module
Triaging
Module
User Interface
Module
VFX & Video
Platform
FreeBSD
Platform
Linux
Platform
macOS
Platform
Windows
Priority
High
Priority
Low
Priority
Normal
Priority
Unbreak Now!
Status
Archived
Status
Confirmed
Status
Duplicate
Status
Needs Info from Developers
Status
Needs Information from User
Status
Needs Triage
Status
Resolved
Type
Bug
Type
Design
Type
Known Issue
Type
Patch
Type
Report
Type
To Do
Milestone
Clear milestone
No items
No Milestone
3.5
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
Hans Goudey
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: blender/blender#104188
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?