Regression: Geometry Node: Radius input don't propageted on input curve for Set Curve Radius node #104223

New Issue

Tom Benedett · 2023-01-29T23:26:58+01:00

Tom Benedett commented

2023-01-29 23:26:58 +01:00

System Information
Operating system: Windows 10
Graphics card: RTX 3090

Blender Version
Broken: version: 3.5.0 Alpha, branch: arcpatch-D16928, commit date: 2023-01-06 04:01, hash: c1003a5edf
Worked: version: 3.5.0 Alpha, branch: master, commit date: 2023-01-04 23:36, hash: a7cc6e015c

Caused by 2ffd08e952

Simplified short description of error

The node does not propagate the radius input attribute.

Exact steps for others to reproduce the error
File example. If you open it, you will see that the attribute captured for the point does not propagate to curves.

Set Curve Radius missing field_on_all.blend

Possible fix

diff --git a/source/blender/nodes/geometry/nodes/node_geo_set_curve_radius.cc b/source/blender/nodes/geometry/nodes/node_geo_set_curve_radius.cc
index f03f5aa0413..1224ef5dfb6 100644
    - a/source/blender/nodes/geometry/nodes/node_geo_set_curve_radius.cc
+++ b/source/blender/nodes/geometry/nodes/node_geo_set_curve_radius.cc
@@ -13,7 +13,7 @@ static void node_declare(NodeDeclarationBuilder &b)

b.add_inputdecl::Float(N_("Radius"))
.min(0.0f)
.default_value(0.005f)

- .supports_field()
+      .field_on_all()

 .subtype(PROP_DISTANCE);

b.add_outputdecl::Geometry(N_("Curve")).propagate_all();

##Original short description of error

Short description of error
The attached file presents a trunk-and-branches Geometry Nodes example where the radii of the points that are used for instancing are used to affect the properties of the (realized) instances. Expected behavior / behavior consistent with old files is shown in the first image:
{F14210541}
And the new behavior is shown in the second image. The value from the "capture attribute" on the points used for instancing is read by all the realized geometry as zero.
{F14210543}
This can be fixed with a "capture attribute" node put after the instancing/realization and before the "set radius" node.
{F14210553}
This problem does not apply to using the uncaptured value for "scale instances" on unrealized instances, nor does it apply to using the uncaptured value for an offset for "set position;" it appears isolated to "set radius" from what I can tell.

Exact steps for others to reproduce the error
See attached file.
{F14210536}

**System Information** Operating system: Windows 10 Graphics card: RTX 3090 **Blender Version** Broken: version: 3.5.0 Alpha, branch: arcpatch-[D16928](https://archive.blender.org/developer/D16928), commit date: 2023-01-06 04:01, hash: `c1003a5edf` Worked: version: 3.5.0 Alpha, branch: master, commit date: 2023-01-04 23:36, hash: `a7cc6e015c` Caused by 2ffd08e952 ## Simplified short description of error The node does not propagate the radius input attribute. **Exact steps for others to reproduce the error** File example. If you open it, you will see that the attribute captured for the point does not propagate to curves. [Set Curve Radius missing field_on_all.blend](https://archive.blender.org/developer/F14211034/Set_Curve_Radius_missing_field_on_all.blend) **Possible fix** ```lang=Diff diff --git a/source/blender/nodes/geometry/nodes/node_geo_set_curve_radius.cc b/source/blender/nodes/geometry/nodes/node_geo_set_curve_radius.cc index f03f5aa0413..1224ef5dfb6 100644 - a/source/blender/nodes/geometry/nodes/node_geo_set_curve_radius.cc +++ b/source/blender/nodes/geometry/nodes/node_geo_set_curve_radius.cc @@ -13,7 +13,7 @@ static void node_declare(NodeDeclarationBuilder &b) ``` b.add_input<decl::Float>(N_("Radius")) .min(0.0f) .default_value(0.005f) ``` - .supports_field() + .field_on_all() ``` .subtype(PROP_DISTANCE); b.add_output<decl::Geometry>(N_("Curve")).propagate_all(); ``` } ``` ##Original short description of error **Short description of error** The attached file presents a trunk-and-branches Geometry Nodes example where the radii of the points that are used for instancing are used to affect the properties of the (realized) instances. Expected behavior / behavior consistent with old files is shown in the first image: {F14210541} And the new behavior is shown in the second image. The value from the "capture attribute" on the points used for instancing is read by all the realized geometry as zero. {F14210543} This can be fixed with a "capture attribute" node put after the instancing/realization and before the "set radius" node. {F14210553} This problem does not apply to using the uncaptured value for "scale instances" on unrealized instances, nor does it apply to using the uncaptured value for an offset for "set position;" it appears isolated to "set radius" from what I can tell. **Exact steps for others to reproduce the error** See attached file. {F14210536}

Tom Benedett commented

2023-01-29 23:26:58 +01:00

Added subscriber: @moak

blender-admin commented

2023-01-29 23:26:58 +01:00

#104312 was marked as duplicate of this issue

Iliya Katushenock commented

2023-01-30 02:12:07 +01:00

Added subscriber: @mod_moder

Iliya Katushenock commented

2023-01-30 02:12:07 +01:00

will check...

Iliya Katushenock changed title from ~~[Geometry Nodes] Regression: radius no longer propagates from points to realized instances~~ to Regression: Geometry Node: Radius input don't propageted on input curve for Set Curve Radius node

2023-01-30 02:25:16 +01:00

Iliya Katushenock commented

2023-01-30 02:25:16 +01:00

Changed status from 'Needs Triage' to: 'Confirmed'