Regression: Light direction gizmo not working #104282

New Issue

Robert Hagström · 2023-02-01T13:32:49+01:00

Robert Hagström commented

2023-02-01 13:32:49 +01:00

System Information
Operating system: Mac OS Ventura
Graphics card: Mac Studio Ultra

Blender Version
3.5 alpha
Broken by

Short description of error

When trying to point a light at something by using the yellow dot handle in the viewport, the light instead points at the viewer.

Steps to reproduce

Enable Metal GPUBackend, On OpenGL it works as expected.
Add spot light
Use direction gizmo

Light will point into viewport cameras

**System Information** Operating system: Mac OS Ventura Graphics card: Mac Studio Ultra **Blender Version** 3.5 alpha Broken by **Short description of error** When trying to point a light at something by using the yellow dot handle in the viewport, the light instead points at the viewer. **Steps to reproduce** - Enable Metal GPUBackend, On OpenGL it works as expected. - Add spot light - Use direction gizmo Light will point into viewport cameras

Robert Hagström commented

2023-02-01 13:32:49 +01:00

Added subscriber: @Brallan

Richard Antalik commented

2023-02-02 11:44:52 +01:00

Added subscriber: @iss

Richard Antalik commented

2023-02-02 11:44:52 +01:00

Changed status from 'Needs Triage' to: 'Needs User Info'

Richard Antalik commented

2023-02-02 11:44:52 +01:00

Can you rephrase the issue? I don't understand it. Perhaps a video recording would help too.

Robert Hagström commented

2023-02-02 20:15:44 +01:00

Ok, in the attached video you can see me trying to point a light at the default cube, but it instead points back at me :-)Light problem.mov

Ok, in the attached video you can see me trying to point a light at the default cube, but it instead points back at me :-)[Light problem.mov](https://archive.blender.org/developer/F14233075/Light_problem.mov)

Richard Antalik commented

2023-02-03 14:19:13 +01:00

Changed status from 'Needs User Info' to: 'Confirmed'

Richard Antalik commented

2023-02-03 14:19:13 +01:00

Thanks for video, I can reproduce only on Mac machine

Broken between 40e5954e39 and 8b1edff6b5, will bisect, even though before it didn't work quite as expected still.

Thanks for video, I can reproduce only on Mac machine Broken between 40e5954e3967 and 8b1edff6b50e, will bisect, even though before it didn't work quite as expected still.

Richard Antalik changed title from ~~Light target handle in viewport not working~~ to Regression: Light target handle in viewport not working

2023-02-03 14:26:22 +01:00

Richard Antalik changed title from ~~Regression: Light target handle in viewport not working~~ to Regression: Light direction gizmo not working

2023-02-03 14:27:22 +01:00

Michael Parkin-White commented

2023-02-03 17:39:22 +01:00

Added subscriber: @Michael-Parkin-White-Apple

Richard Antalik commented

2023-02-05 20:52:51 +01:00

Added subscriber: @Jeroen-Bakker

Richard Antalik commented

2023-02-05 20:52:51 +01:00

@Jeroen-Bakker Can you check?

Jeroen Bakker self-assigned this 2023-02-08 09:37:29 +01:00

Jeroen Bakker commented

2023-02-09 08:59:35 +01:00

Seems like the issue is Metal backend only. When doing depth picking a GPU texture is read. This texture doesn't have the GPU_TEXTURE_USAGE_HOST_READ flag set. In debug mode this is also reported with an assert statement. This isn't the cause of the issue, but found during investigation.

My first guess is that the depth that is returned by the depth test is always 0 when using the Metal backend.

Metal
(depth stencil hex:converted depth)

3b7fff01:0.003906

OpenGL

3f800000:1.000000

Seems like a missing part (was expected) during the Metal Backend implementation.
I would assume some bit sizzling needs to happen to convert the depth stencil to an expected value.

@Michael-Parkin-White-Apple can you have a look at this? Check view3d_depths_create for reference.

Seems like the issue is Metal backend only. When doing depth picking a GPU texture is read. This texture doesn't have the `GPU_TEXTURE_USAGE_HOST_READ` flag set. In debug mode this is also reported with an assert statement. This isn't the cause of the issue, but found during investigation. My first guess is that the depth that is returned by the depth test is always 0 when using the Metal backend. **Metal** (depth stencil hex:converted depth) ``` 3b7fff01:0.003906 ``` **OpenGL** ``` 3f800000:1.000000 ``` Seems like a missing part (was expected) during the Metal Backend implementation. I would assume some bit sizzling needs to happen to convert the depth stencil to an expected value. @Michael-Parkin-White-Apple can you have a look at this? Check `view3d_depths_create` for reference.

Jeroen Bakker referenced this issue from a commit

2023-02-09 09:02:40 +01:00

GPU: Fix assert when using light gizmo.

Jeroen Bakker added

and removed

labels 2023-02-09 09:03:40 +01:00

Jeroen Bakker commented

2023-02-09 09:05:12 +01:00

Lowering the priority as it isn't a regression. Still it needs to be fixed for Blender 3.5, but can be handled as regular bug fixing as the changes are expected to be localized to the Metal backend.

Jeroen Bakker removed the

Download

What's New

Blender Studio

Manual

Developers Blog

Documentation

Benchmark

Blender Conference

Development Fund

One-time Donations

Regression: Light direction gizmo not working #104282