selecting a grease pencil layer in dopesheet and timeline does NOT register anywhere #104601

New Issue

Alex Mehler · 2023-02-11T00:32:14+01:00

Alex Mehler commented

2023-02-11 00:32:14 +01:00

When you select a grease pencil layer in the Object Data Properties, blender registers this in the Info tab and also possible to register a bpy.msgbus.subscribe_rna callback to the active layer.

But when selecting a layer in dopesheet, even though it also changes the active layer in Object Data Properties, blender doesnt register this at all.

Would be nice if this is added as its kind of missing.

In actual animation work you would select the layer 98% of times through the dopesheet and not Object Data Properties.

Writing an addon which does something on layer activation is now only possible with polling or bpy.app.handlers.depsgraph_update_post.append

When you select a grease pencil layer in the Object Data Properties, blender registers this in the Info tab and also possible to register a bpy.msgbus.subscribe_rna callback to the active layer. But when selecting a layer in dopesheet, even though it also changes the active layer in Object Data Properties, blender doesnt register this at all. Would be nice if this is added as its kind of missing. In actual animation work you would select the layer 98% of times through the dopesheet and not Object Data Properties. Writing an addon which does something on layer activation is now only possible with polling or bpy.app.handlers.depsgraph_update_post.append

20230211-181109-2023-02-11 18-10-04.20230211-181746.mp4

1.1 MiB

Alex Mehler added the

labels 2023-02-11 00:32:15 +01:00

Philipp Oeser commented

2023-02-13 13:19:00 +01:00

Which blender version are you using?
Has this ever worked before?

Could you attach a simple .blend example (including some py code) that shows the difference? (this should help speed up the process when multiple devs are looking at this issue)

Which blender version are you using? Has this ever worked before? Could you attach a simple .blend example (including some py code) that shows the difference? (this should help speed up the process when multiple devs are looking at this issue)

Philipp Oeser added

Status

Needs Information from User

and removed

Status

Needs Triage

labels 2023-02-13 13:19:08 +01:00

Alex Mehler commented

2023-03-29 03:32:42 +02:00

this is the default 2d animation file, just look at the info panel and switch layers in dopesheet and in object data properties. in properties it registers in dopesheet it doesnt.

This affects msgbus too, the signal isnt send

this is the default 2d animation file, just look at the info panel and switch layers in dopesheet and in object data properties. in properties it registers in dopesheet it doesnt. This affects msgbus too, the signal isnt send

default_2danimation.blend

1.0 MiB

Philipp Oeser added

Status

Needs Triage

and removed

Status

Needs Information from User

labels 2023-03-29 12:42:59 +02:00

Pratik Borhade commented

2023-04-12 14:16:48 +02:00

Hi, channel selection in anim-editors and layer selection in UI list are both handled differently.

For animation editor:
For operators, report is generated after execution only if OPTYPE_REGISTER flag is set, see:
https://projects.blender.org/blender/blender/src/branch/main/source/blender/windowmanager/intern/wm_event_system.cc#L1081

    if (op->type->flag & OPTYPE_REGISTER) {
      if (G.background == 0) { /* Ends up printing these in the terminal, gets annoying. */
        /* Report the python string representation of the operator. */
        char *buf = WM_operator_pystring(C, op, false, true);
        BKE_report(CTX_wm_reports(C), RPT_OPERATOR, buf);
        MEM_freeN(buf);
      }
    }

Clicking on channel invokes ANIM_OT_channels_click operator and register flag is not set purposefully for this operator (to not expose redo panel?).

In case of Object Data Properties tab:
These Layers are button list, clicking/selecting them calls rna function rna_GPencil_active_layer_index_set to update the property.
For these UI, report is generated in ui_apply_but_autokey

even though it also changes the active layer in Object Data Properties

Not sure which exact function does the syncing of animchannels with UI.

AFAICS this is working as expected. The issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors.

For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests

For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug

Closing this report. Feel free to comment if there is misunderstanding.

Hi, channel selection in anim-editors and layer selection in UI list are both handled differently. **For animation editor:** For operators, report is generated after execution only if `OPTYPE_REGISTER` flag is set, see: https://projects.blender.org/blender/blender/src/branch/main/source/blender/windowmanager/intern/wm_event_system.cc#L1081 ``` if (op->type->flag & OPTYPE_REGISTER) { if (G.background == 0) { /* Ends up printing these in the terminal, gets annoying. */ /* Report the python string representation of the operator. */ char *buf = WM_operator_pystring(C, op, false, true); BKE_report(CTX_wm_reports(C), RPT_OPERATOR, buf); MEM_freeN(buf); } } ``` Clicking on channel invokes `ANIM_OT_channels_click` operator and `register` flag is not set purposefully for this operator (to not expose redo panel?). - - - **In case of Object Data Properties tab:** These Layers are button list, clicking/selecting them calls rna function `rna_GPencil_active_layer_index_set` to update the property. For these UI, report is generated in `ui_apply_but_autokey` - - - > even though it also changes the active layer in Object Data Properties Not sure which exact function does the syncing of animchannels with UI. - - - AFAICS this is working as expected. The issue reported here is a request for modified/improved behavior and not a bug in current behavior. Closing as this bug tracker is only for bugs and errors. For user requests and feedback, please use other channels: https://wiki.blender.org/wiki/Communication/Contact#User_Feedback_and_Requests For more information on why this isn't considered a bug, visit: https://wiki.blender.org/wiki/Reference/Not_a_bug Closing this report. Feel free to comment if there is misunderstanding.

Pratik Borhade closed this issue

2023-04-12 14:16:49 +02:00

Blender Bot added

and removed

labels 2023-04-12 14:16:50 +02:00

Sign in to join this conversation.