Nodes: Removing and freeing the next one during a linkbase iterating #104604

New Issue

Iliya Katushenock · 2023-02-11T04:09:02+01:00

Iliya Katushenock commented

2023-02-11 04:09:02 +01:00

System Information
Operating system: Windows-10-10.0.19045-SP0 64 Bits
Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 527.56

Blender Version
Broken: version: 3.5.0 Alpha, branch: main, commit date: 2023-02-10 20:06, hash: rBefabe81c916c (ninja lite)
Worked: version: 3.5.0 Alpha, branch: main, commit date: 2023-02-10 20:06, hash: rBefabe81c916c (ninja)

Caused by: a827864e6b

Short description of error
Blender crashed for lite build during nodeInternalRelink.
As i can see, crash happen during LISTBASE_FOREACH_MUTABLE iterate other links after delete some links (maybe due to another one nested LISTBASE_FOREACH_MUTABLE).

Exact steps for others to reproduce the error

Reproduce example file:
a. Create new geometry node tree. Group Input -> Group Output nodes.
b. Create on Convex Hull node and past this on link. Call this node as Second
c. Create Join Geometry and past this between Convex Hull and Group Output
d. Put another one link from Group Input in to Join Geometry.
e. Past another one Convex Hull node on second link. Call this node as First
In this file:
a. {key Alt LMB} on First node, move somether.
b. {key Alt LMB} on Second node. Expect crash in lite build.

**System Information** Operating system: Windows-10-10.0.19045-SP0 64 Bits Graphics card: NVIDIA GeForce GTX 1060 6GB/PCIe/SSE2 NVIDIA Corporation 4.5.0 NVIDIA 527.56 **Blender Version** Broken: version: 3.5.0 Alpha, branch: main, commit date: 2023-02-10 20:06, hash: `rBefabe81c916c` (`ninja lite`) Worked: version: 3.5.0 Alpha, branch: main, commit date: 2023-02-10 20:06, hash: `rBefabe81c916c` (`ninja`) Caused by: a827864e6b1ee34af759dea61f832076c0e67c44 **Short description of error** Blender crashed for lite build during `nodeInternalRelink`. As i can see, crash happen during `LISTBASE_FOREACH_MUTABLE` iterate other links after delete some links (maybe due to another one nested `LISTBASE_FOREACH_MUTABLE`). **Exact steps for others to reproduce the error** 1. Reproduce example file: a. Create new geometry node tree. `Group Input` -> `Group Output` nodes. b. Create on `Convex Hull` node and past this on link. Call this node as `Second` c. Create `Join Geometry` and past this between `Convex Hull` and `Group Output` d. Put another one link from `Group Input` in to `Join Geometry`. e. Past another one `Convex Hull` node on second link. Call this node as `First` 2. In this file: a. {key Alt LMB} on `First` node, move somether. b. {key Alt LMB} on `Second` node. Expect crash in lite build.

crash on relink.blend

792 KiB

Iliya Katushenock added the

labels 2023-02-11 04:09:03 +01:00

Philipp Oeser commented

2023-02-13 11:53:42 +01:00

@mod_moder : please always set the Module tag when you confirm an issue (otherwise it is not a fully triaged bug)

@mod_moder : please always set the `Module` tag when you confirm an issue (otherwise it is not a [fully triaged bug](https://wiki.blender.org/wiki/Process/A_Bugs_Life))

👍 1

Philipp Oeser added

and removed

labels 2023-02-13 11:53:57 +01:00

Iliya Katushenock added

and removed

labels 2023-02-13 19:29:01 +01:00

Iliya Katushenock commented

2023-02-13 19:29:32 +01:00

I found the culprit :)

Iliya Katushenock changed title from ~~Crash in Little Build. Correct in full build. Nodes and linked list.~~ to Nodes: Removing and freeing the next one during a linkbase iterating

2023-02-13 19:31:06 +01:00

Iliya Katushenock commented

2023-02-13 19:32:40 +01:00

I can try to fix it, anyway I found it when cleaning. Now there's just one more reason

Iliya Katushenock self-assigned this 2023-02-13 20:16:15 +01:00

Iliya Katushenock added a new dependency 2023-02-13 20:29:50 +01:00

#104716 Cleanup: Move draw_attributes.hh to C++

Iliya Katushenock removed a dependency 2023-02-13 20:30:12 +01:00

#104716 Cleanup: Move draw_attributes.hh to C++

~~Iliya Katushenock referenced this issue 2023-02-13 20:35:34 +01:00~~

Cleanup: Node internal link relink #104605

~~Iliya Katushenock referenced this issue 2023-02-13 20:38:15 +01:00~~